Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driving Clown Car Into the SM Doesn't Kill Anyone #82135

Closed
IndieanaJones opened this issue Mar 21, 2024 · 5 comments · Fixed by #82137
Closed

Driving Clown Car Into the SM Doesn't Kill Anyone #82135

IndieanaJones opened this issue Mar 21, 2024 · 5 comments · Fixed by #82137
Labels
Consistency Issue The dev team didn't think of everything Priority: CRITICAL We really messed up Tested/Reproduced There might be a hope in hell of getting this fixed.

Comments

@IndieanaJones
Copy link
Contributor

IndieanaJones commented Mar 21, 2024 •
edited by github-actions bot

Issue Summary

Driving the clown car into the supermatter results in the clown car's destruction, with all occupants being left on the tile where the clown car was unharmed.

Round ID: 225836

Testmerges:

#82085: 'Canonical Movement' by Kapu1178 at commit d8a650b](https://www.github.com/tgstation/tgstation/pull/82085)

Reproduction:

  • Get clown car
  • Get passengers
  • Drive clown car into SM
  • Note the passengers are deposited safely on the tile where the clown car was, free to escape what should be an iconic death for all
@optimumtact optimumtact added Priority: CRITICAL We really messed up Test Merge Bug Nobody tested this code and now you're testing it live labels Mar 21, 2024
@Blacklist897
Copy link
Contributor

Its not from the test merge its been around for ages
https://www.youtube.com/watch?v=Ov2ihvRtfwM

@Kapu1178
Copy link
Contributor

Reproduced on master. Not a TM bug.

@optimumtact optimumtact added Bug Correct Functionality Tested/Reproduced There might be a hope in hell of getting this fixed. Consistency Issue The dev team didn't think of everything and removed Test Merge Bug Nobody tested this code and now you're testing it live Bug Correct Functionality labels Mar 21, 2024
@Jacquerel Jacquerel mentioned this issue Mar 21, 2024
Merged
@moocowswag
Copy link
Contributor

moocowswag commented Mar 21, 2024 •
edited

This has been and on and off issue i think actually, ive had times where the clown car instantly dusted everyone and times when it didnt and i learned to loop around the sm crystal to consistently get everyone with it or atleast try to hit the sm crystal on the side with the vents so the scrubbers pull them.

@moocowswag
Copy link
Contributor

moocowswag commented Mar 21, 2024 •
edited

Oh thats my video being linked by blacklist897 and i even talked about it briefly back then, ya its a timeless quirk with sm dusting im just not sure if there is other variables at play because it didnt always happen.

@Kapu1178
Copy link
Contributor

This has been and on and off issue i think actually, ive had times where the clown car instantly dusted everyone and times when it didnt and i learned to loop around the sm crystal to consistently get everyone with it or atleast try to hit the sm crystal on the side with the vents so the scrubbers pull them.

The clowncar will throw people in random directions after they leave. So its pure RNG.

Ghommie pushed a commit that referenced this issue Mar 22, 2024
@Jacquerel @san7890
Driving any vehicle into the supermatter will dust all passengers (#8…
c95890c 
…2137)

## About The Pull Request

Fixes #82135
All occupants of vehicles (including mobs you can ride) will now die if
anyone drives that vehicle into the supermatter crystal.

## Why It's Good For The Game

It may not be canonically true that driving the clown car into the
supermatter dusts all occupants but by god, it should be.
This is the result that you expect to occur upon doing such a thing.

## Changelog

:cl:
fix: Driving a vehicle into the supermatter will kill everyone riding
the vehicle
/:cl:

---------

Co-authored-by: san7890 <the@san7890.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Consistency Issue The dev team didn't think of everything Priority: CRITICAL We really messed up Tested/Reproduced There might be a hope in hell of getting this fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Driving any vehicle into the supermatter will dust all passengers Jacquerel/orbstation
5 participants
@optimumtact @IndieanaJones @moocowswag @Kapu1178 @Blacklist897