Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes restriction against implanting nuke disk #13533

Merged
merged 2 commits into from Dec 16, 2015

Conversation

imtakingabreakdontatme
Copy link
Contributor

A) The code doesn't work

B) Nuke ops have a surgery table on their shuttle, they can just kidnap the clowns body

Removes the GetTypeInAllContents proc that was literally only ever used here and was shitcode according to @tkdrg

馃啈 Kor
rscadd: There are no longer restrictions against implanting the nuclear disk in people.
/:cl:

@@ -25,7 +25,7 @@

/datum/surgery_step/handle_cavity/success(mob/user, mob/living/carbon/target, target_zone, obj/item/tool, datum/surgery/surgery)
if(tool)
if(IC || tool.w_class > 3 || NODROP in tool.flags || tool.GetTypeInAllContents(/obj/item/weapon/disk/nuclear) || istype(tool, /obj/item/weapon/disk/nuclear) || istype(tool, /obj/item/organ))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well remove the rest.

tool.GetTypeInAllContents(/obj/item/weapon/disk/nuclear)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also im pretty sure this is the only time that this proc is ever called

@Fox-McCloud
Copy link
Contributor

馃憥

This should be fixed, not removed; implanting the disk pretty much means nukies are going to lose, no matter what--surgery table on their ship or not.

@imtakingabreakdontatme
Copy link
Contributor Author

Half the time the ops already steal the captains body and strip it in rather than dig through his stuff in a hallway

@WJohn WJohn added the Removal This was too fun, too fun! I'm turning this feature around label Dec 9, 2015
@Zilenan91
Copy link

This is awful, please no. Fix the code rather than remove it outright because it's gonna be pretty tiring to see the captain implanting their disk into the HoS every single round.

@imtakingabreakdontatme
Copy link
Contributor Author

So shoot the HoS and go operate on him safely on Z2.

Or drop a minibomb on his body

@Zilenan91
Copy link

rip backpack space. Ops barely have enough ammo already to kill enough people to get by in high pop. A shotty with 3 or 4 spare slug magazines is pretty standard, leaving little space for things like minibombs between eshields, eswords, or other backup gear you might have.

@imtakingabreakdontatme
Copy link
Contributor Author

Lucky for ops ctrl+click takes no bag space

@Zilenan91
Copy link

Help intent is a bit buggy currently, meaning if you're walking around with someones body being dragged behind you it's basically a random chance to break your grip on them if a crew or Op walks through you. Really fucks them over if they get that far.

Spacewind too, but it happens very very rarely ever since the change to it. I've had it happen once as a wizard (which killed me) and another time as a detective dragging a dead assistant to Medbay.

@PKPenguin321
Copy link
Contributor

馃憤 to this change

@Robustin
Copy link
Contributor

Yea I don't see this being an issue.

Implanting the disk is already a significant time consuming distraction and it would only take ops a moment to realize the disk was implanted and just pull the body back to the shuttle.

@Bawhoppen
Copy link
Contributor

nuke disks in PDAs anyone? 馃惓

@harmonyn
Copy link

they can just kidnap the clowns body

FEATURE

@KazeEspada
Copy link
Contributor

Gibbing a body drops its contents so, they could just kill the eater and then bomb him.

@tkdrg
Copy link
Contributor

tkdrg commented Dec 16, 2015

@KorPhaeron remove gettypeinallcontents this is literally the only place where it is called i said as much 1 week ago there is no reason to keep it around

tkdrg added a commit that referenced this pull request Dec 16, 2015
Removes restriction against implanting nuke disk
@tkdrg tkdrg merged commit dcb0500 into tgstation:master Dec 16, 2015
@imtakingabreakdontatme imtakingabreakdontatme deleted the disk_implant branch December 17, 2015 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal This was too fun, too fun! I'm turning this feature around
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet