[REVIEW-READY] removes simulated turfs (and asteroid station) #16026

duncathan · 2016-03-10T23:34:32Z

Disclaimer: this PR removes asteroid station. Reasons include:

Ass is unmaintained
Ass is incompatible with TGM due to a byond bug
Ass is incompatible with lavaland
It would take another hour of work to update ass to work properly with this PR and frankly with the other reasons there already I seriously am not feeling like putting the effort in

If somebody wants to put in the work to fix Ass themselves, you're more than welcome to - ping me in #coderbus (I'll be there as Dunc|Mobile or Dunc2) and I can let you know what needs to be done.

oh god this is gonna be painful

ok so here's the plan:

kill the turf/simulated path
make space turfs have one static, immutable (effectively) gas mixture
use our newfound path freedom to move vars for closed turfs to turf/wall and vars for open turfs to turf/open or something
deal with the infinite merge conflicts this will give me
test the fuck out of it

Closes #16061

ChangelingRain · 2016-03-10T23:35:32Z

Amazing.

GunHog · 2016-03-10T23:51:45Z

What benefit does this provide?

duncathan · 2016-03-11T00:26:17Z

@GunHog

kills snowflake handling of space turfs by LINDA
minimizes turf vars that go unused by a particular type
- for instance, air is a var only used by open turfs, but still held by all simulated turfs. this change (does not yet, but) will make air only held by all open turfs
removes the redundancy of turf/simulated because there are only two other children of turf, both of which can handle themselves (as with my space changes already done)

phil235 · 2016-03-11T00:48:04Z

How are we even supposed to review a PR with 100k line changes?

optimumtact · 2016-03-11T01:02:37Z

git remote add dunc https://github.com/duncathan/-tg-station
git fetch --all
git checkout master
git merge upstream/master
git push

git diff dunc/turf -- code/

you can also git diff dunc/turf -- code/game/turfs/

it would help if his codebase was up to date

ChangelingRain · 2016-03-11T01:09:09Z

It's not actually 100k, it's like 50k and a big chunk is maps.

duncathan · 2016-03-11T01:16:32Z

I fucked something up; box has about 60000 whitespace changes. But yea the vast majority of the pr is maps, because just about every map instance has to be changed.

GunHog · 2016-03-11T04:25:52Z

How are we even supposed to review a PR with 100k line changes?

It is hilarious that you are the one to say this!

…o turfs Conflicts: _maps/RandomRuins/SpaceRuins/asteroid4.dmm _maps/RandomRuins/SpaceRuins/spacebar.dmm _maps/RandomZLevels/Academy.dmm _maps/RandomZLevels/beach.dmm _maps/RandomZLevels/caves.dmm _maps/RandomZLevels/research.dmm _maps/RandomZLevels/snowdin.dmm _maps/RandomZLevels/spacebattle.dmm _maps/RandomZLevels/undergroundoutpost45.dmm _maps/RandomZLevels/wildwest.dmm _maps/map_files/AsteroidStation/AsteroidStation.dmm _maps/map_files/BirdStation/BirdStation.dmm _maps/map_files/DreamStation/dreamstation04.dmm _maps/map_files/DreamStation/z5.dmm _maps/map_files/EfficiencyStation/EfficiencyStation.dmm _maps/map_files/MetaStation/MetaStation.v41I.dmm _maps/map_files/MiniStation/MiniStation.dmm _maps/map_files/TgStation/tgstation.2.1.3.dmm _maps/map_files/generic/z4.dmm _maps/map_files/generic/z5.dmm _maps/map_files/generic/z6.dmm _maps/templates/lavaland_surface_prisoner_crash.dmm _maps/templates/lavaland_surface_seed_vault.dmm _maps/templates/lavaland_surface_ufo_crash.dmm code/game/asteroid.dm code/game/atoms.dm code/game/gamemodes/cult/runes.dm code/game/gamemodes/malfunction/Malf_Modules.dm code/game/machinery/computer/arcade.dm code/game/objects/structures/lattice.dm code/game/turfs/simulated/floor/fancy_floor.dm code/game/turfs/simulated/floor/misc_floor.dm code/game/turfs/simulated/floor/plasteel_floor.dm code/game/turfs/simulated/walls_misc.dm code/game/turfs/turf.dm code/modules/events/spacevine.dm code/modules/mining/mine_turfs.dm code/modules/mob/living/living.dm code/modules/mob/living/silicon/robot/robot.dm code/modules/mob/living/simple_animal/bot/cleanbot.dm code/modules/mob/living/simple_animal/bot/mulebot.dm code/modules/mob/mob_movement.dm

…o turfs Conflicts: code/game/gamemodes/nuclear/nuclearbomb.dm

lzimann · 2016-03-12T23:39:23Z

i think someone is going insane, good luck

theOperand · 2016-03-16T12:47:40Z

absolute madman

kyrahabattoir · 2016-03-17T13:22:22Z

So non open turfs will only track thermal energy going through them right?

duncathan · 2016-03-17T13:51:08Z

Well technically it's temperature they track, but thermal energy is easily calculated by multiplying temperature and heat capacity.

KazeEspada · 2016-03-17T17:51:22Z

Suggested repaths:
Plating path really means: You can put a tile on it. Not sure what to call it though. turf/open/base?
Asteroid path really means: You can hit it with a shovel to get sand. Should probably be called digable. turf/open/base/digable?

imtakingabreakdontatme · 2016-03-18T16:27:28Z

@duncathan

Can you please repath lava to something other than plating while you are doing this? That was a silly idea on my part

Bawhoppen · 2016-03-24T11:51:41Z

how much longer on this shit I want to change maps

duncathan · 2016-03-24T13:35:46Z

I hope to be finished by the end of next week

Bawhoppen · 2016-03-24T13:45:03Z

@dunc when I click the files changed it literally lags, you maniac

duncathan · 2016-03-25T00:07:55Z

it's only gonna get worse
not too much worse, but still pretty bad

PKPenguin321 · 2016-03-25T01:11:15Z

400k line changes
jesus dicks

215 files changed

R I P
I
P

duncathan · 2016-03-25T01:16:56Z

this is why we have mapping freezes, kids

duncathan · 2016-04-04T06:50:57Z

i'm free.

we're all free.

GunHog · 2016-04-04T06:57:56Z

You are not free until you fix all the bugs and exploits our wonderful QA team (the players) find and report!

Razoozle · 2016-04-04T23:30:28Z

This is broken. ;-;

optimumtact · 2016-04-05T00:03:21Z

Please report bugs via the issue tracker

Razoozle · 2016-04-05T01:19:45Z

Actually, this works fine with 510. I was using 509.

optimumtact · 2016-04-05T01:24:11Z

@Ultimate-Chimera are you running windows and linux, and if linux, did you have bygex installed?

Razoozle · 2016-04-05T01:59:52Z

@optimumtact Windows.

Incoming5643 · 2016-04-05T04:42:23Z

Literally every round is ending in a hyper pressurized Armageddon, can we revert this already?

optimumtact · 2016-04-05T04:46:10Z

no

Kevak · 2016-07-22T10:47:23Z

I desire pictures of the mapchange.

optimumtact · 2016-07-22T22:14:10Z

This didn't have any visible changes to maps, it just rewrote underlying atmos turf technology

imtakingabreakdontatme · 2016-07-22T22:20:34Z

it ruined the game don't port it

SamHPurp · 2017-04-02T11:43:18Z

God help me, I'm considering porting this to Para.

duncathan · 2017-04-02T18:23:57Z

@SamHPurp find me on #coderbus (Dunc or Dunc|Mobile) if you need help, which I'm sure you will. This task is a monster

SamHPurp · 2017-04-02T18:27:15Z

@duncathan I'm keen to get Lavaland ported, and this is the major barrier in us doing so.

imtakingabreakdontatme · 2017-04-02T18:58:01Z

@SamHPurp

You'd probably be better off just rebasing and then readding your features than trying to catch up on years of turf/atmos/lighting changes for porting large projects

imtakingabreakdontatme · 2017-04-02T18:58:23Z

This PR was pretty broken and required a ton of follow up

SamHPurp · 2017-04-02T19:57:09Z

@KorPhaeron confidence inspiring

imtakingabreakdontatme · 2017-04-02T20:12:33Z

Not trying to stop you since getting lavaland on every server would be a point of pride for me, just trying to set realistic expectations. 2 years of refactors to the basic building blocks of the game ported piece by piece sounds like a fucking nightmare

SamHPurp · 2017-04-02T20:14:02Z

@KorPhaeron Aye. Sounds painful and tedious. Not impossible, I just need to define a healthy workflow of Paracode, the PRs and current TG code I think.....

optimumtact · 2017-04-03T03:20:07Z

You can do it, if you believe in yourself

LemonInTheDark · 2020-07-27T07:02:35Z

he couldn't do it

duncathan · 2020-08-03T02:24:10Z

can't blame him tbh

Kiyahitayika · 2021-01-20T18:10:26Z

God help me, I'm considering porting this to Para.

God help me, I'm considering porting this to Scorpio, a Paradise downstream server.

Great starting point: we don't have Asteroid Station to remove.
Update: I'ma need to borrow some of your atmos. Thank you o__o;;
Update: Ahhh, minerals.
Update: AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAH: ScorpioStation/ScorpioStation#332

This PR was pretty broken and required a ton of follow up

To this point, I think what is really required to port the open/closed turf model is the understanding of the concept. This week, I learned turfs! Open turfs allow atmos, Closed turfs do not. Simulated turfs on Paracode are destructible, removable, dismantlable, etc.. Unsimulated turfs are not. Right. Two different systems.

Aye. Sounds painful and tedious. Not impossible, I just need to define a healthy workflow of Paracode, the PRs and current TG code I think.....

So, what is one to do? Identify the properties open and closed and set those types up. Shift simulated floors to open and simulated walls to closed.

Identify the differences between simulated and unsimulated. Create a subset using a boolean flag for indestructible_turf for open and closed turfs that were previously unsimulated.

This is going to need a LOT of testing and my Paracode PR will ever get merged, but it was fun. Wait, did I just make space turf . . . uh oh . . .

Kiyahitayika · 2021-01-30T04:37:52Z

You don't need a healthy workflow, just an unhealthy habit of using coding as stress-relief ;--;

UPDATE: Use a subtype, not a boolean flag. Place overrides on those subtypes.

duncathan added 2 commits February 28, 2016 19:08

removes /turf/simulated

1db8235

removes simulated turfs; adds space gas mixture for space

5bf3146

duncathan added Atmos Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts labels Mar 10, 2016

duncathan added 2 commits March 10, 2016 23:07

Merge branch 'master' of https://github.com/tgstation/-tg-station int…

6678dbe

…o turfs Conflicts: code/game/gamemodes/nuclear/nuclearbomb.dm

duncathan mentioned this pull request Mar 12, 2016

~~~ SEMI-FREEZE UNDERWAY; READ DESCRIPTION ~~~ #16061

Closed

Cheridan added the Priority: CRITICAL We really messed up label Mar 15, 2016

lzimann mentioned this pull request Apr 5, 2016

Space is pressurized and inconstant #16643

Closed

Incoming5643 mentioned this pull request Apr 9, 2016

Running a server relies on a beta build of byond with stability issues #16769

Closed

optimumtact mentioned this pull request May 23, 2016

Removing simulated turfs killed our startup #17892

Closed

Kiyahitayika mentioned this pull request Jan 20, 2021

[DNM] [WIP] - Multi-Z Port from /tg/ ScorpioStation/ScorpioStation#331

Closed

5 tasks

LemonInTheDark mentioned this pull request Mar 12, 2023

Optimizes atmos init by 20% #73926

Merged

[REVIEW-READY] removes simulated turfs (and asteroid station) #16026

[REVIEW-READY] removes simulated turfs (and asteroid station) #16026

Conversation

duncathan commented Mar 10, 2016

ChangelingRain commented Mar 10, 2016

GunHog commented Mar 10, 2016

duncathan commented Mar 11, 2016

phil235 commented Mar 11, 2016

optimumtact commented Mar 11, 2016

ChangelingRain commented Mar 11, 2016

duncathan commented Mar 11, 2016

GunHog commented Mar 11, 2016

lzimann commented Mar 12, 2016

theOperand commented Mar 16, 2016

kyrahabattoir commented Mar 17, 2016

duncathan commented Mar 17, 2016

KazeEspada commented Mar 17, 2016

imtakingabreakdontatme commented Mar 18, 2016

Bawhoppen commented Mar 24, 2016

duncathan commented Mar 24, 2016

Bawhoppen commented Mar 24, 2016

duncathan commented Mar 25, 2016

PKPenguin321 commented Mar 25, 2016

duncathan commented Mar 25, 2016

duncathan commented Apr 4, 2016

GunHog commented Apr 4, 2016

Razoozle commented Apr 4, 2016

optimumtact commented Apr 5, 2016

Razoozle commented Apr 5, 2016

optimumtact commented Apr 5, 2016

Razoozle commented Apr 5, 2016

Incoming5643 commented Apr 5, 2016

optimumtact commented Apr 5, 2016

Kevak commented Jul 22, 2016

optimumtact commented Jul 22, 2016

imtakingabreakdontatme commented Jul 22, 2016

SamHPurp commented Apr 2, 2017

duncathan commented Apr 2, 2017

SamHPurp commented Apr 2, 2017

imtakingabreakdontatme commented Apr 2, 2017

imtakingabreakdontatme commented Apr 2, 2017

SamHPurp commented Apr 2, 2017

imtakingabreakdontatme commented Apr 2, 2017

SamHPurp commented Apr 2, 2017

optimumtact commented Apr 3, 2017

LemonInTheDark commented Jul 27, 2020

duncathan commented Aug 3, 2020

Kiyahitayika commented Jan 20, 2021 • edited

Kiyahitayika commented Jan 30, 2021 • edited

Kiyahitayika commented Jan 20, 2021 •

edited

Kiyahitayika commented Jan 30, 2021 •

edited