Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#FEELTHEGOOF Election PR: This is what the local conservative radio said all sanders voters wanted #19105

Merged
merged 4 commits into from
Jul 9, 2016

Conversation

Iamgoofball
Copy link
Contributor

@Iamgoofball Iamgoofball commented Jul 3, 2016

2016-07-03_01-48-28
uploading a video now, it looks better in game trust me
🆑 Goofball Sanders
add: Added a new plant to the game to encourage the Chef to be a more relevant job, alongside a recipe for a food related to it. Throw a cannabis leaf on a table and check the recipes list to find it.
/:cl:

Feedback:
dreamseeker_2016-07-03_01-59-46

usinng my token from #18170 since it still hasnt been successfully used

@InsaneHyena
Copy link
Contributor

Must have a Trump PR as a counterweight. RCD wall building buffs when?

@Iamgoofball
Copy link
Contributor Author

@InsaneHyena sorry the email plans for that got leaked and we had to go fundraise for new ones

@MrPerson
Copy link
Contributor

MrPerson commented Jul 3, 2016

All the weed should go in the goon folder

@Iamgoofball
Copy link
Contributor Author

oh yeah, forgot we separate the sprites, will move them

@evsey9
Copy link
Contributor

evsey9 commented Jul 3, 2016

make a pr that makes you headmin, it would get merged, totally, i swear

@coiax
Copy link
Member

coiax commented Jul 3, 2016

Right, I had to reread this multiple times to determine this was a PR adding cannabis to the game, the memes are thick and difficult to decipher.

@X-TheDark
Copy link
Contributor

X-TheDark commented Jul 3, 2016

Soon enough Goof will make a Lipolicide Storm event that puts it into all mobs that aren't in maintenance to make the Chef relevant.

I think this is a really nice PR, even if it is literally 'dank memes'.

"krokodil" = 0.15,
"histamine" = 0.15,
"lipolicide" = 0.15)
rarity = 420
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your memes will force dreams

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many cargo points would this even be worth?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also set this to a reasonable number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rare mutation but OK

@Fox-McCloud
Copy link
Contributor

Needed to happen 👍

@WJohn WJohn added the Feature Exposes new bugs in interesting ways label Jul 3, 2016
@optimumtact
Copy link
Member

What's the point of having this and ambrosia?

@Iamgoofball
Copy link
Contributor Author

ambrosia is primarily a medical plant when it comes to gameplay, with each mutation level bumping up the healing power and downsizing on the space drugs. If anything, I think the space drugs in ambrosia was actually to try to be a downside to the healing meds.

@Iamgoofball
Copy link
Contributor Author

these new plants have the munchies mechanic and will ensure the chef continues to be useful to those who don't think about what they're doing

@imtakingabreakdontatme
Copy link
Contributor

none

@JJRcop
Copy link
Contributor

JJRcop commented Jul 3, 2016

It seems like the different cannabis should have different effects.

@Iamgoofball
Copy link
Contributor Author

they do

@JJRcop
Copy link
Contributor

JJRcop commented Jul 3, 2016

i read the code wrong

@Firecage
Copy link
Contributor

Firecage commented Jul 4, 2016

Eh, I am a bit conflicted on Death Weed containing Cyanide.

@Iamgoofball
Copy link
Contributor Author

its deadly

@Firecage
Copy link
Contributor

Firecage commented Jul 4, 2016

I do understand that goof, but I woulda said cyanide is a bit over the top, but browsing the code recently, I don't know what the fuck happened. Poison Apples no longer contains cyanide but is still admin only. Poison berries now contains cyanide, but their more lethal mutation Death berries doesn't....so...ehh...

Have fun Goof!!!!

@Iamgoofball
Copy link
Contributor Author

i thought poison berries had some other shit in them? Hm, i'll have to check them out

@Firecage
Copy link
Contributor

Firecage commented Jul 4, 2016

Well, yah, used to contain normal toxin. Welp, now I see what happened, bloody Lumi.

Anywho, good PR anyway goof. If you get onto IRC later, I guess ile link you to said PR which changed the chemical reagents in plants.

@Supermichael777
Copy link
Contributor

I didnt know nazis leaned sanders /s

@Cheridan
Copy link
Contributor

Cheridan commented Jul 4, 2016

DUDE WEED LMAO

@bobdobbington
Copy link
Contributor

Cyanide is a meme now, it's basically a much shittier version of Lexorin, it's not anywhere near the level of combat robustness it had back when every nuke op got issued a suicide pill made of cyanide.

@Iamgoofball
Copy link
Contributor Author

I'll swap out the toxin.

@Firecage
Copy link
Contributor

Firecage commented Jul 6, 2016

@Iamgoofball But as I said in OOC. I do think you should probably add some practical uses to cannibas so it isn't just another random botany plant added for memes.

One or two kitchen recipes would work. Would also be nice if you added the ability to craft rope from cannibas plants and then added some use for them.

@X-TheDark
Copy link
Contributor

X-TheDark commented Jul 6, 2016

Hash/Space cakes/brownies when?

@optimumtact
Copy link
Member

Add a food recipe and I'll merge it

@Iamgoofball
Copy link
Contributor Author

fine

@Iamgoofball
Copy link
Contributor Author

Iamgoofball commented Jul 7, 2016

ALSO I have to move the plant sprites back to the base hydroponics growing icons, the code doesn't support grabbing from other icon files and its dumb

nvm fixed it

seed = /obj/item/seeds/cannabis/ultimate
desc = "You feel dizzy looking at it. What the fuck?"
icon_state = "ocannabis"
volume = 420
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again reasonable number please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's actually kind of reasonable for super high potency seeds

@Iamgoofball
Copy link
Contributor Author

@optimumtact we're ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet