[READY] Explosive Tesla, Take 2 #20083

PKPenguin321 · 2016-08-24T22:45:55Z

Video (a bit outdated): https://www.youtube.com/watch?v=f_CrgMbk4t4
Remake of #17501

Todo:

Make tesla itself bomb immune since it will delete itself in some cases
Make an upgrade for cameras and ~~airlocks~~ light tubes that tesla-proofs them to prevent tesla from breaking its own containment
Do a testmerge of this to get a feel for how laggy it is and adjust explosion values and probabilities accordingly

Maps Tested On:

Boxstation: Containment area can successfully hold a tesla ball with the equipment given at roundstart. Lights occasionally blow out, but it's inconsequential.
Metastation: Also works.
Birdboat/ministation: Doesn't even have a singulo containment area so no issue there
Dreamstation: ✅
EfficiencyStation ✅ Lights occasionally blow out, but it's inconsequential.

Changes made:

tesla_act for machinery in general now often calls minibomb-sized explosions (which lack smoke and admin logging to reduce lag and spam, respectively)
explosion proc now has an argument that lets you determine if you want your explosion to make smoke or not. Defaults to 1
The effect_system itself for explosions is split into two paths, one that makes smoke and one that doesn't (should be inconsequential)
Makes light tubes and their variants spew fire on tesla_act instead of a full explosion (to keep tesla from breaking itself out of containment)
Makes cameras with EMP immunity upgrade also tesla immune
Makes the tesla itself bomb immune
Refactored tesla grilles. They no longer shoot a real tesla beam, just one that looks exactly like a tesla beam and will ONLY target carbon mobs (meaning no explosions). As a consequence, they will only ever target 1 person at a time, meaning you can't kill 40 people with one zap anymore.
Made the gravity generator get properly destroyed by the tesla so that it doesn't just repeatedly explode over and over.
Made the nuke do the same as the gravity generator. As a consequence, nukes can now be "disarmed" by the tesla (in the same way BoH bombing a nuke disarms it).

Other notes:

I've been able to make the tesla successfully without it breaking loose on it's own. ~~on Boxstation, but other maps are yet to be tested.~~ It's been fully tested and proper engine setup should never lead to a tesloose.
Airlocks do not need to be bomb-proofed ~~as far as I can tell~~ thanks to grounding rods being right next to them. ~~(at least on Boxstation)~~

The goal here is to make the tesla about as destructive as the singularity is, instead of EMPing and occasionally deleting some machines.

🆑 PKPenguin321
add: The tesla is now much more dangerous, and can cause electronics to explode violently.
/:cl:

…o explosive-tesla

WJohn · 2016-08-24T22:50:32Z

Holy shit. I've been asking for this for a while. 👍 x 💯

Core0verload · 2016-08-25T01:42:40Z

👎 Tesla is already an unkillable round ender. Make it decay if you really want this.

PKPenguin321 · 2016-08-25T01:46:21Z

If it's gonna be an unkillable round ender, might as well make it go all-out instead of just EMPing things, right? More fun that way

AKlimentyev · 2016-08-25T01:58:02Z

@PKPenguin321 It deletes shit by calling ex_act on it as well.

PKPenguin321 · 2016-08-25T02:00:54Z

Yep! The singularity also deletes shit, but it just does it directly, so I guess you could say this is a step down.

- makes tesla bomb immune so it wont destroy itself - makes lights spew fire when they explode instead of the regular explosion - makes cameras with EMP immunity also have tesla immunity tesla can now keep itself fully contained (at least on box)

PKPenguin321 · 2016-08-25T02:28:47Z

Alright then, all that's left is to testmerge and tweak values. I'm starting with explosions being the most likely thing and them being minibomb-strong, which is pretty much the maximum I'll go with this. If it's laggy (which is likely) I will likely do one or more of the following:

Make explosions not the most likely option
Make multiple probabilities with weak explosions being the most common and strong being the least
Lower the tesla's range a little bit so it can't proc as many explosions at once

ShadowDeath6 · 2016-08-25T04:12:11Z

don't minibombs instant crit if you're point blanked with them?

now we get double instacrit tesla action, with 100% less counter memes

PKPenguin321 · 2016-08-25T04:55:07Z

The singularity insta_gibs,_ so you're still better off.

TechnoAlchemisto · 2016-08-25T05:24:33Z

This is a good thing, a loosed engine is supposed to be ridiculously chaotic and dangerous. Lethality memes.

Cheridan · 2016-08-25T08:08:12Z

Singularity instagibs... if you manage to fall into it, which is surprisingly avoidable.
Tesla just pops onto your screen and instakills you and everyone you love.

The difference between gibbing and killing in this situation is pretty meaningless since if the tesla is loose, the shuttle is coming. You're probably not getting cloned before the round ends.

PKPenguin321 · 2016-08-26T01:47:50Z

The difference between gibbing and killing in this situation is pretty meaningless since if the tesla is loose, the shuttle is coming. You're probably not getting cloned before the round ends.

Yep, and the difference between machines getting emagged and blown up is pretty meaningless if the shuttle is coming, so why not have the more exciting option?

silicons · 2016-08-26T04:05:44Z

I rescind my hate. 10/10, MAKE IT STRONGER!!

Ninja137 · 2016-08-26T04:06:49Z

It's beautiful. Make it lose charge slower, though.

Grandsteel · 2016-08-26T04:09:20Z

The perfect concept, actually makes the tesla coil fun to watch

PKPenguin321 · 2016-08-26T04:09:29Z

Do you rike it
Too strong: 1
It's perfect: 4
MAKE IT STRONGER: 17
Did not vote: 42

Testmerge observations:

No lag!!!!!! It's perfect! 😄
Make mechs asplode Edit: Changed my mind about this one, it's essentially just like hardsuit immunity so I figure I'll just leave it be.
Maybe make nukes and grav gen get deleted instead of exploding over and over
Maybe remove hardsuit immunity from tesla? (Will save for another PR in any case)
Players in deadchat fucking loved it, a few said to lower the range but overall feedback was very high in praise
You could hear the tesla before it got to you and started bombing, so that's good

AKlimentyev · 2016-08-26T04:23:37Z

One of the grounding rods got moved from its position and the tesla hit an engineer, gibbed them, and blew a huge hole in engineering.
It then hit another spot. I think it was the collectors, and cut the wire to emitters.
There's going to be a fuckton more teslalooses without engineering even fucking up.
Explosions are such a terrible idea, since the aoe means its super easy for it to hit a wire and escape.

TechnoAlchemisto · 2016-08-26T04:49:04Z

I wouldn't remove the tesla immunity considering everything around you explodes.

Ninja137 · 2016-08-26T04:51:41Z

No. What happened was this:

-Set up engine
-[REDACTED] happens
-Panic, forget what I'm doing
-Continue setting up engine
-Accidentally put in the Singulo
-Turn on after hacking PA
-Singulo moves rods
-Ask admins to replace engine with tesla
-No grounding rods
-I'm standing adjacent to the eastern collector bank
-The very first shock explodes the entire side of the room and I'm immediately disintegrated, and practically jump out of my chair

Round Highlights of Tesla:

-Maxwell Gaylord's enfeebled right leg of elf slaying -11 has been violently dismembered!
-Bubba Squanto's lesser left arm of the plains -3 has been violently dismembered!
-Bubba Squanto's true right arm of elf slaying +12 has been violently dismembered!
-Nathaniel Saylor's inferior left arm of dexterity -4 has been violently dismembered!
-Tesla ripping through the entirety of Engi, Atmos, Med, Sci, Viro, and Escape in under two minutes after escaping

PKPenguin321 · 2016-08-26T05:17:21Z

I should also say that before this gets merged it needs to be tested on other maps. I know box can contain it, but I don't know about meta or any of the other maps. Map edits are likely needed (which sucks because I have no idea how to do them), it might be good to also put reinforced plating over the wires that lead to emitters, I don't know.

Ninja137 · 2016-08-26T13:53:46Z

No man, it has to be able to escape. It can't natively escape, so it shouldn't be too massive an amount of shit to make it go kill everything.

Iamgoofball · 2016-08-26T18:26:35Z

@Ninja137 The singulo also can't escape by itself it requires malpractice or sabotage

I really don't like this. It completely wrecks the design of the tesla.

ChangelingRain · 2016-08-26T19:42:04Z

code/game/machinery/machinery.dm

@@ -466,10 +466,8 @@ Class Procs:
 /obj/machinery/tesla_act(var/power)
 	..()
 	if(prob(85))
-		emp_act(2)
+		explosion(src.loc,1,2,4,flame_range = 2, adminlog = 0, smoke = 0)


Like I said before, this should be the LEAST common effect, not the most. This makes the tesla absolutely rip the station in half, like what the hell.

This makes the tesla absolutely rip the station in half

Rip the station in half?
You mean like the singularity?

Oh, good, working as intended.

didn't people not want this to be a copy paste of the singlo? I get boosting its devastation but making it explode stuff pretty much every time it zaps would be kind of lame

yeah this is not supposed to just be a copypasta of singularity

The tesla was supposed to be a lag free engine if I remember correctly

This is very nearly lag free during test-merges

Grandsteel · 2016-08-26T20:04:25Z

I cannot tell you my disappointment with old Tesla, when it was just a mass murdering machine IF it even moves around to people. Exploding consoles and other electronics manages to actually give it some radical damage. Also complaints about it's damage being too strong feel invalid, since you have to compare it to singularity, wherein Tesla is much less damage since explosions are only around machinery, which can be avoided. Also Tesla is still kinda mediocre to begin with since it tends to get stuck in certain areas, the only reason it absolutely fucked the station in the ass was because penguin set the Tesla to home in on people that prayed at a certain time.

AKlimentyev · 2016-08-26T20:24:27Z

@PKPenguin321 The explosions apply to the tesla zaps from throwing stuff at shocked grills.
Someone threw a toolbox and blew up the bridge.

ShadowDeath6 · 2016-08-26T20:46:58Z

why were tesla grilles even added, they're almost an instakill even when they're low power

PKPenguin321 · 2016-08-26T22:25:09Z

@Iamgoofball I don't want to come off as rude, but the players in deadchat absolutely loved what I did to the tesla. It might go against your "design vision," but I heard time and time again that the tesla is now "much more fun to watch." You could ask almost anyone and they would agree that the current tesla we have right now is very, very boring, especially compared to the singularity.

This is just outright better and more popular/fun to the players, and there's no denying that.

Iamgoofball · 2016-08-27T19:39:44Z

I guess. Just see if you can make the explosion visuals a little more electrified.

PKPenguin321 · 2016-08-27T20:38:41Z

In this commit:

Refactored tesla grilles. They no longer shoot a real tesla beam, just one that looks exactly like a tesla beam and will ONLY target carbon mobs (meaning no explosions).

Iamgoofball · 2016-08-27T20:46:48Z

👎 no no no

they need to use proper tesla zap code, don't snowflake it

just disable the explosion for the tesla grille

PKPenguin321 · 2016-08-27T20:48:06Z

I tried like 40 different methods and spent two days on that, this was the best I could do. If you have an actual code-based method for removing the explosion for tesla grille, please please let me hear it.

Iamgoofball · 2016-08-27T20:48:24Z

i'll look into it fam dont worry

PKPenguin321 · 2016-08-27T22:22:28Z

In this commit:

Made the gravity generator get properly destroyed by the tesla so that it doesn't just repeatedly explode over and over.
Made the nuke do the same as the gravity generator. As a consequence, nukes can now be "disarmed" by the tesla (in the same way BoH bombing a nuke disarms it).

PKPenguin321 · 2016-08-27T23:05:16Z

@Jordie0608 @Razharas @optimumtact @ChangelingRain @RemieRichards @tkdrg @Dorsisdwarf @KorPhaeron
First person to merge this is confirmed cool

RemieRichards · 2016-08-27T23:07:05Z

I'm already cool though.

PKPenguin321 · 2016-08-27T23:08:00Z

But are you confirmed cool

RemieRichards · 2016-08-27T23:08:30Z

yes.

PKPenguin321 · 2016-08-27T23:08:38Z

shoot well could you still merge this please

optimumtact · 2016-08-28T00:42:20Z

Time to make space great again.

PKPenguin321 added 3 commits May 8, 2016 18:30

makes tesla fuck shit up

40aff44

Merge branch 'master' of https://github.com/tgstation/-tg-station int…

a187717

…o explosive-tesla

three months in the making

86aeb63

WJohn added Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways labels Aug 24, 2016

a few tweaks

438d8d8

- makes tesla bomb immune so it wont destroy itself - makes lights spew fire when they explode instead of the regular explosion - makes cameras with EMP immunity also have tesla immunity tesla can now keep itself fully contained (at least on box)

ChangelingRain reviewed Aug 26, 2016
View reviewed changes

fixes grilles exploding machines

08ecbf6

makes nuke and grav gen properly destroy when zapped

58f43da

PKPenguin321 changed the title ~~Explosive Tesla, Take 2~~ [READY] Explosive Tesla, Take 2 Aug 27, 2016

fixes runtime with grav gen

a8f893d

optimumtact merged commit f800987 into tgstation:master Aug 28, 2016

tgstation-server added a commit that referenced this pull request Aug 28, 2016

Automatic changelog generation for PR #20083 [ci skip]

fb79a9c

PKPenguin321 deleted the explosive-tesla branch August 28, 2016 00:42

PKPenguin321 mentioned this pull request Aug 28, 2016

Tesla grilles targets only 1 mob #20192

Closed

[READY] Explosive Tesla, Take 2 #20083

[READY] Explosive Tesla, Take 2 #20083

Conversation

PKPenguin321 commented Aug 24, 2016 • edited

WJohn commented Aug 24, 2016

Core0verload commented Aug 25, 2016

PKPenguin321 commented Aug 25, 2016

AKlimentyev commented Aug 25, 2016

PKPenguin321 commented Aug 25, 2016

PKPenguin321 commented Aug 25, 2016 • edited

ShadowDeath6 commented Aug 25, 2016

PKPenguin321 commented Aug 25, 2016

TechnoAlchemisto commented Aug 25, 2016

Cheridan commented Aug 25, 2016 • edited

PKPenguin321 commented Aug 26, 2016

silicons commented Aug 26, 2016 • edited

Ninja137 commented Aug 26, 2016

Grandsteel commented Aug 26, 2016

PKPenguin321 commented Aug 26, 2016 • edited

AKlimentyev commented Aug 26, 2016 • edited

TechnoAlchemisto commented Aug 26, 2016

Ninja137 commented Aug 26, 2016 • edited

PKPenguin321 commented Aug 26, 2016

Ninja137 commented Aug 26, 2016

Iamgoofball commented Aug 26, 2016

ChangelingRain Aug 26, 2016

Choose a reason for hiding this comment

PKPenguin321 Aug 26, 2016

Choose a reason for hiding this comment

ShadowDeath6 Aug 26, 2016

Choose a reason for hiding this comment

Iamgoofball Aug 26, 2016

Choose a reason for hiding this comment

yackemflam Aug 27, 2016

Choose a reason for hiding this comment

PKPenguin321 Aug 27, 2016 • edited

Choose a reason for hiding this comment

Grandsteel commented Aug 26, 2016

AKlimentyev commented Aug 26, 2016

ShadowDeath6 commented Aug 26, 2016

PKPenguin321 commented Aug 26, 2016

Iamgoofball commented Aug 27, 2016

PKPenguin321 commented Aug 27, 2016

Iamgoofball commented Aug 27, 2016

PKPenguin321 commented Aug 27, 2016

Iamgoofball commented Aug 27, 2016

PKPenguin321 commented Aug 27, 2016

PKPenguin321 commented Aug 27, 2016

RemieRichards commented Aug 27, 2016

PKPenguin321 commented Aug 27, 2016

RemieRichards commented Aug 27, 2016

PKPenguin321 commented Aug 27, 2016

optimumtact commented Aug 28, 2016

PKPenguin321 commented Aug 24, 2016 •

edited

PKPenguin321 commented Aug 25, 2016 •

edited

Cheridan commented Aug 25, 2016 •

edited

silicons commented Aug 26, 2016 •

edited

PKPenguin321 commented Aug 26, 2016 •

edited

AKlimentyev commented Aug 26, 2016 •

edited

Ninja137 commented Aug 26, 2016 •

edited

PKPenguin321 Aug 27, 2016 •

edited