Adds Freon to the game #20188

Iamgoofball · 2016-08-28T18:24:50Z

🆑 Iamgoofball
add: Adds a new experimental gas to the game. Check it out!
/:cl:

Starts in Toxins and Atmospherics roundstart on Meta and Box.

as334 · 2016-08-28T18:26:31Z

code/modules/atmospherics/gasmixtures/gas_types.dm

@@ -51,6 +51,13 @@ var/list/hardcoded_gases = list("o2","n2","co2","plasma") //the main four gases,
 	gas_overlay = "plasma"
 	moles_visible = MOLES_PLASMA_VISIBLE

+/datum/gas/freon
+	id = "freon"
+	specific_heat = 1


Setting this to 1 is a terrible idea. Make it around 2000 and just have the gas start cold.

correct, I don't think you understand how specific_heat works. This isn't a temperature, but rather how well it stores temperature or lack of temperature.

With your current values here, 1 canister of o2 at room temperature could heat up 20 canisters of freon.

Set this to higher for freon, 2389 to be exact.

as334 · 2016-08-28T18:28:11Z

code/game/turfs/open.dm

+			if(!IT.is_frozen)
+				make_frozen_visual(IT)
+	MakeSlippery(TURF_WET_PERMAFROST)
+	air.temperature = 2.7


This is so wrong, so very wrong. Just have the gas have a high specific heat and start out cold. Otherwise even the tiniest trace of this will keep a room cold forever unless you space the entire room and rebuild it. A station flood of this would be an instant shuttle call.

phil235 · 2016-08-28T18:40:34Z

code/__HELPERS/icons.dm

+
+// Used to make the frozen item visuals for Freon.
+
+/proc/make_frozen_visual(var/obj/F)


/obj/proc/make_frozen_visual()

Also there's probably a better file to put this in.

ma44 · 2016-08-28T18:49:17Z

waiting for AI to flood the station with this and plasma after the scientist uploads a free form law

PKPenguin321 · 2016-08-28T19:03:30Z

This looks really cool, wow 👍

kyrahabattoir · 2016-08-28T19:04:31Z

So i'm the only one who would rather have this effect added to the standard gas system instead of making a meme gas?

It's not like we aren't simulating cold already right?

Jalleo · 2016-08-28T19:05:31Z

lets wait until making it a general thing until all the balance changes of standard stuff needs doing after a few large abuses of this system is done (antag or otherwise).

kyrahabattoir · 2016-08-28T19:07:01Z

Like that's ever going to happen (the general thing part).

as334 · 2016-08-28T19:07:41Z

I would actually also prefer it to be a general thing, but having the effect tied to a specific gas is currently the best way to try it out for balance and then see what needs to be tweaked.

Iamgoofball · 2016-08-28T19:19:04Z

Also I like unique gases instead of jack of all trades

MrPerson · 2016-08-28T21:25:42Z

code/__HELPERS/icons.dm

+		F.name = "frozen [temp_name]"
+		F.is_frozen = TRUE
+		return
+	return


Anonmare · 2016-08-28T22:19:57Z

This might be a nice gas if you could carefully release small amounts of it to cool down areas that have been overheated.

silicons · 2016-08-28T22:46:37Z

This seems kinda overpowered...

Iamgoofball · 2016-08-28T22:50:07Z

Next commit is gonna change how the slide on the ice works.

PKPenguin321 · 2016-08-28T23:05:30Z

is this a port because if not this is actually really really creative and cool goofball like this is actually really neat

Supermichael777 · 2016-08-28T23:19:33Z

custom flamers
this could be fun

Supermichael777 · 2016-08-28T23:19:50Z

wait to be clear i can freez people solid right?

Iamgoofball · 2016-08-28T23:21:10Z

@PKPenguin321 this is original content donut steel

except the sprites i borrowed those

RemieRichards · 2016-08-28T23:30:17Z

code/__HELPERS/icons.dm

+
+// Used to make the frozen item visuals for Freon.
+
+/obj/proc/make_frozen_visual(var/obj/F)


should really drop the _visual since it actually sets the is_frozen var, making it REALLY frozen.
also why on earth does this take an argument and not just use src? (Edit: this last bit seems to be because you misunderstood @phil235's comment)

pre refactor leftovers

AKlimentyev · 2016-08-30T19:27:00Z

@Iamgoofball talk to @MrStonedOne about that. I had issues with gulp not installing and he found some alternate way to install that worked.

Razharas · 2016-08-30T20:08:16Z

If its actually a layer of ice it should protect the dude inside from shit outside, this is both more consistent and makes it more than a stun-with-different-visuals
Find a better sprite for iced status effect, the cube looks like 8bit snow level and feels really cheap, especially concidering the attenmpts to switch to x64

Iamgoofball · 2016-08-30T20:11:54Z

maybe after this PR is merged and I add icecubing to cryostal
no

Lexorion · 2016-08-30T20:59:21Z

Y E S

Incoming5643 · 2016-08-30T21:00:35Z

DO
NOT
MERGE

optimumtact · 2016-08-30T21:01:26Z

The do not merge is stale it was applied 2 days ago.

Incoming5643 · 2016-08-30T21:06:09Z

Oranges I'm starting to think you live in some sort of alternate reality where the flow of time is an order of magnitude faster than it is for the rest of us.

Iamgoofball · 2016-08-30T21:08:19Z

@Incoming5643 it was also applied in reference to the lag, which was fixed with caching and changes to how the gas worked

ChangelingRain · 2016-08-30T21:12:35Z

And, uh, the animation issue still exists?

Iamgoofball · 2016-08-30T21:20:10Z

@ChangelingRain no concievable way to fix it, i'm working on a BYOND report right now actually

imtakingabreakdontatme · 2016-08-30T23:02:40Z

The balance issues also still exist but oh well

imtakingabreakdontatme · 2016-08-31T05:27:16Z

So does the "teleport back and forth because of atmos/slipping interaction and get stuck until you die" bug

YakumoChen · 2016-08-31T05:52:07Z

Can we not leave oranges to merge this when there are a ton of people who don't want it and balance issues still exist

imtakingabreakdontatme · 2016-08-31T05:55:35Z

Also it has no purpose at all in regards to any civilian use as far as I'm aware

imtakingabreakdontatme · 2016-08-31T05:57:36Z

And made space even more binary "if you don't have a suit you're fucking dead within seconds" because now space stuns you

YakumoChen · 2016-08-31T06:00:49Z

corpses become ice cubes in space and it looks disgusting visually.

Saegrimr · 2016-08-31T06:34:18Z

Also it has no purpose at all in regards to any civilian use as far as I'm aware

If it could be used to make a safe Supermatter, i'd be all for it.

Iamgoofball · 2016-08-31T06:34:54Z

@Saegrimr it's cold as fuck so yeah

PKPenguin321 · 2016-08-31T07:04:58Z

Why would you ever use gas to cool supermatter if you are literally in the infinite coldness of space

Alek2ander · 2016-08-31T07:42:31Z

Ice cubes don't really make sense. They're fun, I admit, but they shouldn't happen every time something gets cold.
Possibly only icecube people when actually exposed to freezegas, or add some sort of water stacks (Magicka freezing comes to mind)

Iamgoofball · 2016-08-31T07:50:06Z

@Alek2ander #20233

Saegrimr · 2016-08-31T12:52:30Z

@PKPenguin321
Because it just doesn't work that way.

nullbear · 2016-08-31T14:12:10Z

iirc Supermatter only processes when on a non-space simulated turf.

imtakingabreakdontatme · 2016-08-31T14:54:05Z

You can just RCD the floor next to it though

Saegrimr · 2016-08-31T19:02:57Z

0/10 would not recommend for supermatter http://i.imgur.com/ICU8gOx.png

NocturnalQuill · 2016-08-31T19:08:46Z

Items that are extremely hot like supermatter shards should be immune to freon freezing.

AKlimentyev · 2016-08-31T19:20:12Z

the frozen supermatter shard has reached the emergency point.

Absolutely amazing.

phil235 · 2016-09-30T18:18:32Z

code/modules/mob/mob.dm

@@ -719,6 +719,10 @@ var/next_mob_id = 0
 			layer = initial(layer)
 	update_transform()
 	update_action_buttons_icon()
+	if(istype(src, /mob/living))


AndrewJacksonThe2nd added 3 commits August 28, 2016 10:59

Adds Freon to the game

0b6f1ab

MAP CHANGE MEMES

8353fb7

hahahahafuck

c40964a

as334 reviewed Aug 28, 2016
View reviewed changes

WJohn added Atmos Feature Exposes new bugs in interesting ways FUCK Only two things are infinite, the universe and human stupidity, and I'm not sure about the former labels Aug 28, 2016

as334 reviewed Aug 28, 2016
View reviewed changes

YOU SAW NNOTHING

418f6ee

phil235 reviewed Aug 28, 2016
View reviewed changes

fuqq

246af34

sd

e5ee526

bs12-bot added the Map Edit label Aug 28, 2016

MrPerson reviewed Aug 28, 2016
View reviewed changes

code/__HELPERS/icons.dm

F.name = "frozen [temp_name]"

F.is_frozen = TRUE

return

return

Copy link

Contributor

MrPerson Aug 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return

RemieRichards reviewed Aug 28, 2016
View reviewed changes

optimumtact merged commit 634662d into tgstation:master Aug 30, 2016

tgstation-server added a commit that referenced this pull request Aug 30, 2016

Automatic changelog generation for PR #20188 [ci skip]

5deb228

phil235 reviewed Sep 30, 2016

View reviewed changes


		// Used to make the frozen item visuals for Freon.

		/proc/make_frozen_visual(var/obj/F)


		// Used to make the frozen item visuals for Freon.

		/obj/proc/make_frozen_visual(var/obj/F)

Adds Freon to the game #20188

Adds Freon to the game #20188

Conversation

Iamgoofball commented Aug 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ma44 commented Aug 28, 2016

PKPenguin321 commented Aug 28, 2016

kyrahabattoir commented Aug 28, 2016

Jalleo commented Aug 28, 2016

kyrahabattoir commented Aug 28, 2016

as334 commented Aug 28, 2016

Iamgoofball commented Aug 28, 2016

Choose a reason for hiding this comment

Anonmare commented Aug 28, 2016

silicons commented Aug 28, 2016

Iamgoofball commented Aug 28, 2016

PKPenguin321 commented Aug 28, 2016

Supermichael777 commented Aug 28, 2016

Supermichael777 commented Aug 28, 2016

Iamgoofball commented Aug 28, 2016

RemieRichards Aug 28, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AKlimentyev commented Aug 30, 2016

Razharas commented Aug 30, 2016

Iamgoofball commented Aug 30, 2016

Lexorion commented Aug 30, 2016

Incoming5643 commented Aug 30, 2016

optimumtact commented Aug 30, 2016

Incoming5643 commented Aug 30, 2016

Iamgoofball commented Aug 30, 2016

ChangelingRain commented Aug 30, 2016

Iamgoofball commented Aug 30, 2016

imtakingabreakdontatme commented Aug 30, 2016

imtakingabreakdontatme commented Aug 31, 2016

YakumoChen commented Aug 31, 2016

imtakingabreakdontatme commented Aug 31, 2016

imtakingabreakdontatme commented Aug 31, 2016

YakumoChen commented Aug 31, 2016

Saegrimr commented Aug 31, 2016

Iamgoofball commented Aug 31, 2016

PKPenguin321 commented Aug 31, 2016

Alek2ander commented Aug 31, 2016

Iamgoofball commented Aug 31, 2016

Saegrimr commented Aug 31, 2016

nullbear commented Aug 31, 2016

imtakingabreakdontatme commented Aug 31, 2016

Saegrimr commented Aug 31, 2016

NocturnalQuill commented Aug 31, 2016

AKlimentyev commented Aug 31, 2016

Choose a reason for hiding this comment

RemieRichards Aug 28, 2016 •

edited

Loading