Allows for sabre renaming. #20367
Allows for sabre renaming. #20367
Conversation
|
I'm that schmuck! |
|
#Best feature 2016 |
|
This is already functionality from the item relabeller why are you snowflaking it? |
|
Actually this looks copypasted from gun code |
|
that's because it is The label gun does not rename the item it just adds () at the end of it. This gives the same functionality as KA's and Revolvers |
|
If the same code already exists in /weapon/gun, can you just promote it to /weapon/ ? |
|
If the obj/item/weapon/ path wasn't used for half the things in this game I'd say that'd be the better option, I mean if a maintainer wants me to do that I will. |
|
Papa bones is the best 👍 |
|
I don't see the harm in promoting it. It would only work for things that have unique_rename set, and let renaming work for a larger range of shit. If you're worried about extra memory pressure from the extra variable on a bunch of shit, combine some flags into a single bitfield. |
|
I leave you this sword given to me by my precious queen and the word engraved upon it: Luck. But first, let me affix my own benediction: Pluck! |
|
you can probably remove these vars from guns since guns are childs of weapons, arent they? just move the whole system up |
|
They are a child of weapons but not a child of /melee/ (which is what I put this on) |
|
Fix the snowflake code, I suggest some helper procs for renaming |
|
Yeah, I tried to standardize it to all weapons but it breaks renaming for anything that's a gun, no idea what the exact cause is, RIP. |
…om/TechnoAlchemisto/-tg-station into cant_believe_shadowlight_banned_me # Conflicts: # code/game/objects/items/weapons/melee/misc.dm
| M << "You name the weapon [input]. Say hello to your new friend." | ||
| return | ||
| >>>>>>> 04bb24d27a666b5821c9c053014095c032095f9d | ||
|
|
There was a problem hiding this comment.
Leaving merge conflict markers in
|
fuck my ass 1 sec |
| @@ -21,6 +23,7 @@ | |||
| name = input | |||
| M << "You name the weapon [input]. Say hello to your new friend." | |||
| return | |||
| >>>>>>> 04bb24d27a666b5821c9c053014095c032095f9d | |||
|
where is god in these troubling times? |
|
This is ready for review by the way, @optimumtact |
optimumtact
added
Ready for Review
and removed
Do Not Merge
|
It amuses me that pen is a /weapon/. So you could concievably use another pen to rename your pen. |
|
Thanks oranges, you the real MVP. |
🆑 Papa Bones
tweak: You can now rename the captain's sabre by using a pen on it.
/:cl:
Requested by some schmuck on the forums.
Allows for any weapon to use the unique_rename var.