Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalances non-hybrid tasers and disablers #21358

Closed
wants to merge 8 commits into from
Closed

Rebalances non-hybrid tasers and disablers #21358

wants to merge 8 commits into from

Conversation

Tacolizard
Copy link
Contributor

@Tacolizard Tacolizard commented Nov 3, 2016

馃啈 Tacolizard
tweak: Non-hybrid tasers have enough charge for 4 shots; non-hybrid disablers have 7 shots
/:cl:

i hope this will fill a good self-defense niche so that i may make these weapons obtainable in-game.

also just saying, a four shot taser is still very powerful for anyone non-sec. I'm more interested in the lower-power disabler.

egun, the thing you are familiar with != disabler
disablers don't spawn on any map other than dream

@optimumtact optimumtact added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label Nov 3, 2016
@@ -4,6 +4,7 @@
icon_state = "taser"
item_state = null //so the human update icon uses the icon_state instead.
ammo_type = list(/obj/item/ammo_casing/energy/electrode)
cell_type = /obj/item/weapon/stock_parts/cell{charge = 800; maxcharge = 800}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never use {stuff} in code, create a new subtype of cell instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or adjust the charge per shot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i used because it was copypasta'd from the mini egun

i'll do what @Supermichael777 said.

@phil235
Copy link
Contributor

phil235 commented Nov 3, 2016

What were the previous charge amounts? So that we can better judge the balance change.

@ToadStar
Copy link

ToadStar commented Nov 3, 2016

8 shots for the tasers iirc, and 20 for the disabler. And you could get the normal disabler via a crate in cargo, but not the normal taser without badminnery.

@Cyberboss
Copy link
Member

Wow that brings the non-hybrid disabler down to 40% of it's current effectiveness if I'm reading that right. That's a little steep considering the HoP and HoS start with it.

@pubby
Copy link
Contributor

pubby commented Nov 3, 2016

The HoP and HoS start with eguns, not disablers.

@Supermichael777
Copy link
Contributor

egun stronk

@Tacolizard
Copy link
Contributor Author

@Cyberboss do you have any idea what you type

@silicons
Copy link
Contributor

silicons commented Nov 4, 2016

nerf normal disabler by a huge amount
@Tacolizard do you have any idea how to balance? make a new subtype if you want to give near-useless self-defense weapons.
Also I believe 44 stamina is a buff.

@Tacolizard
Copy link
Contributor Author

@kevinz000 i want to be sure you know that this isn't the normal disabler most people use, most people say disabler and mean egun. the actual disabler is obtainable only via cargo and is rarely used

@silicons
Copy link
Contributor

silicons commented Nov 4, 2016

Now it's going to be even more rarely used as you're nerfing them to have 7 shots. They were already a last resort weapon.

@Steelpoint
Copy link
Contributor

A seven shot disabler is a weird design choice.

@CPTANT
Copy link
Contributor

CPTANT commented Nov 4, 2016

Wait this changed in those commits. It's now a 42 stamina disabler with 7 shots?

@Dorsisdwarf
Copy link
Contributor

people in this PR who have no idea what a disabler gun is

@Tacolizard
Copy link
Contributor Author

guys i will bet you've literally seen someone use a disabler mabye once. i plan on making the disablers more widely available after these changes. i am also testing a kind of pulse disabler which has low ammo but does slightly more stamina damage.

@Tacolizard
Copy link
Contributor Author

@kevinz000 disablers don't even spawn on any map other than dream. nobody will even notice this change until i make another pr to make them more available.

@silicons
Copy link
Contributor

silicons commented Nov 4, 2016

Just because something isn't noticed doesnt mean it's good

flag = "energy"
hitsound = 'sound/weapons/tap.ogg'
eyeblur = 0
impact_effect_type = /obj/effect/overlay/temp/impact_effect/blue_laser

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered just making this a child of disabler and just editing the damage since everything else is the same?

@@ -4,6 +4,7 @@
icon_state = "taser"
item_state = null //so the human update icon uses the icon_state instead.
ammo_type = list(/obj/item/ammo_casing/energy/electrode)
//cell_type = /obj/item/weapon/stock_parts/cell{charge = 800; maxcharge = 800}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this /do/ anything?

desc = "A self-defense weapon that exhausts organic targets, weakening them until they collapse."
icon_state = "disabler"
item_state = "combat=3"
ammo_type = list(/obj/item/ammo_casing/energy/disabler)
//cell_type = /obj/item/weapon/stock_parts/cell{charge = 350; maxcharge = 350}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Taser Comment

@@ -34,11 +35,12 @@
use_cyborg_cell = 1

/obj/item/weapon/gun/energy/disabler
name = "disabler"
name = "pulse disabler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind renaming it to something that isn't associated with deathsquad/centcomm related weaponry? It's just a disabler right?

Copy link
Contributor

@ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I blind or am I not seeing anything balance-related here?

@optimumtact
Copy link
Member

Could you please
A) put more effort into your pr's on their first presentation
B) stop touching things you know will attract peoples attention in the wrong way

You're soaking up valuable maintainer time that could be better spent elsewhere.

@optimumtact optimumtact closed this Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet