Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE #21724

Closed
wants to merge 43 commits into from

Conversation

silicons
Copy link
Contributor

@silicons silicons commented Nov 24, 2016

Currently not available in-game due to this being a lavaland compound thing.
Membrane walls sprites "stolen" from BAYSTATION.
Other sprites + idea from Dagdammit.

RAPID TERRAFORMING DEVICE.
A specialized bulky item that uses RCD technology.
It is limited to the mining zlevel.
It has several functions.
All of them use matter in the form of metal, glass, plasteel, RCD cartridges, or IRON ORE.
The pressurize function uses gas that is internally regenerated.
Using it has a chance to shock you unless you are wearing insulated
Use a mining satchel on it to load iron ore if tehre is any in the satchel

  1. Make catwalks on lava/chasms to allow people to cross. These catwalks can not be destroyed by normal welders.
    2.Turn asteroid floor into plating, and rock walls into normal walls
  2. Fabricate airlocks.
    4.Fabricate membranes which are airtight but are destroyed in one hit from just about anything.
    5.Remove catwalks made by this
  3. Blow out compressed air to pressurize areas.

@silicons silicons changed the title LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE [WIP]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE Nov 24, 2016
@Ausops
Copy link

Ausops commented Nov 24, 2016

refillable by mining satchels please

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of the RTD, but it's quite ever so snowflakey and just bad.

@@ -0,0 +1,570 @@
//This file was auto-corrected by findeclaration.exe on 25.5.2012 20:42:32
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can smell the copypasta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOU DIDNT SEE ANYTHING

var/list/conf_access = null
var/use_one_access = 0 //If the airlock should require ALL or only ONE of the listed accesses.

var/no_ammo_message = "Insufficient Matter."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to store this as a var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thirteen errors if I don't and otherwise I need to restate this that many times.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D E F I N E

var/mob/living/carbon/human/H = usr
if(H.getBrainLoss() >= 60)
return
var/t1 = text("")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use text() you should really just use TGUI for this insead of browse.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't into tgui
Don't know how
This is RCD code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCD code is bad

@AnturK AnturK added the Feature Exposes new bugs in interesting ways label Nov 25, 2016
@silicons silicons changed the title [WIP]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE [READY]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE Nov 25, 2016

/obj/item/weapon/rtd/suicide_act(mob/user)
user.visible_message("<span class='suicide'>[user] sets the RTD to 'Airlock' and points it down [user.p_their()] throat! It looks like [user.p_theyre()] trying to commit suicide..</span>")
var/obj/machinery/door/airlock/A = new /obj/machinery/door/airlock/glass_command(get_turf(src))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want one with command access?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean they're permanently removed from the round... each person can only do this once...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a silly thing though, like why would it randomly be able to create a standard command-access airlock only in this specific situation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see how this goes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dagdammit btw it has the standard RCD settings so really it can do it anyways, its just in this situation the airlock has 500 health.
also, it's a suicide_act thing like nuke disks, I don't see an issue but I'l change it if people think it's a problem?

if (!conf_access.len)
conf_access = null

/obj/item/weapon/rtd/verb/toggle_gas_enrichment()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO VERBS, ACTIONS BUTTONS ONLY

YOU SHOULD KNOW THIS BUY NOW.

/obj/item/weapon/rtd/verb/toggle_gas_enrichment()
set name = "Change Gas Enrichment"
set category = "Object"
set src in usr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STRAIGHT UP CARGO CULT COPY PASTE

Copy link
Member

@optimumtact optimumtact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbs go home

@Dagdammit
Copy link

Will it break anything to add it to the game before lavaland compound's ready?

I mean I guess it'll be an item only engineers (with their insulated gloves) are supposed to use, in a place they don't currently have access to.

@silicons
Copy link
Contributor Author

Nope, completely usable with current lavaland and compound, it's just it's adminspawn untill compound is in and we know where to put this stuff.

@silicons
Copy link
Contributor Author

@optimumtact done

# Conflicts:
#	code/modules/mob/living/living.dm
@silicons silicons changed the title [READY]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE [s][READY]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE Dec 10, 2016
@silicons silicons closed this Dec 10, 2016
@silicons silicons reopened this Dec 10, 2016
@silicons silicons changed the title [s][READY]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE [READY]LAVALAND COMPOUND ITEM - RAPID TERRAFORMING DEVICE Dec 10, 2016
@silicons
Copy link
Contributor Author

Travis broke even without any compile errors. The fuck?

@silicons
Copy link
Contributor Author

silicons commented Dec 11, 2016

Chasm catwalk capability removed by ""popular"" ""demand'" aka repukan getting triggered i'm nerfing his department by making it hugboxy. lava cost increased to 30.
NOW MERGE THIS SHIT ALREADY

@jughu
Copy link
Contributor

jughu commented Dec 13, 2016

Lavaland gets more features cool items then the station gets
Before we know lavaland dlc comes

@Dagdammit
Copy link

Dagdammit commented Dec 13, 2016 via email

@optimumtact
Copy link
Member

This will never work and Kor is too nice to say no, so this a no from me.

@imtakingabreakdontatme
Copy link
Contributor

I've spoken to dagdammit some more, I've agreed to let him get the items committed as admin only so we can judge the lava compound as a whole when it's done. If it's bad, the items will be removed later, and I'll close any PRs that attempt to add them to RD or mining outside of him finishing his compound idea for testing.

@ExcessiveUseOfCobblestone
Copy link
Contributor

In a game with essentially limitless resources it's pretty hard to find a middle ground between "ignore all lava forever" and "can reasonably build on and around it" and I've been unsure what to do about that for a while now

You create the underground portion and add even MORE resources :^)

@optimumtact
Copy link
Member

stale and dead, make a new pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge You must have really upset someone Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet