New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Mop can now make its own water #21903
Conversation
The Advanced Mop can now produce its own water at a rate of 1 unit per process(). The advanced mop now has a switch to toggle wetting itself.
/obj/item/weapon/mop/advanced/Destroy() | ||
if(refill_enabled) | ||
STOP_PROCESSING(SSobj, src) | ||
..() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure you need return ..()
for Destroy()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other things I should know before I commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none that i've noticed
START_PROCESSING(SSobj, src) | ||
else | ||
STOP_PROCESSING(SSobj,src) | ||
user << "<span class='notice'>You turn [refill_enabled ? "on" : "off"] the condenser.</span>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it look better being: "You turn the condenser [on : off]." ? Maybe it's just me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it a little, but not exactly that, it seems weird.
Definitely power creep |
Has science gone to far? |
Thank god there's actually a reason to make this for the janitor now. |
Do some real powercreep and make it generate lube when emagged |
Do NOT tempt me. If a maintainer says I can do it, then I WILL DO IT. |
Something else infinite = water taps. Generating space cleaner/ammonia would have been better so it instantly converts to space cleaner when dipped inside a water bowl |
Hilarious, can't wait to VV it. |
馃啈 Gun Hog
add: Nanotrasen Janitorial Sciences Division is proud to announce a new concept for the Advanced Mop prototype; It now includes a built-in condenser for self re-hydration! See your local Scientist today! In the event that janitorial staff wish to use more expensive solutions, the condenser may be shut off with a handy handle switch!
/:cl:
The Advanced Mop can now produce its own water at a rate of 1 unit per
process()
tick, up to 10 units of water.The advanced mop includes a switch on
attack_self()
to toggle wetting itself.