Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ore satchel auto empties into ore box when dragged #22228

Merged
merged 1 commit into from Dec 18, 2016

Conversation

coiax
Copy link
Member

@coiax coiax commented Dec 15, 2016

馃啈 coiax
add: Whenever you automatically pick up ore with an ore satchel, if you
are dragging a wooden ore box, the satchel automatically empties into
the box.
/:cl:

Because convinience. Streamlining. Less pointless clicking.

馃啈 coiax
add: Whenever you automatically pick up ore with an ore satchel, if you
are dragging a wooden ore box, the satchel automatically empties into
the box.
/馃啈

Because convinience. Streamlining. Less pointless clicking.
@jughu
Copy link
Contributor

jughu commented Dec 15, 2016

Pseudo powercreep pr

@KingPhilipIII
Copy link

But 2D spessmen was built on a foundation of pointless and excessive clicking.

I don't have any issue with this. I just felt like saying that.

@XDTM
Copy link
Contributor

XDTM commented Dec 15, 2016

Choo choo here comes the mining train 馃憤

@Arianya
Copy link
Contributor

Arianya commented Dec 15, 2016

Any chance of making the second part of that silent? Since I presume if you use attackby it'll spawn the usual "You empty the content of the satchel into the ore box" message

@coiax
Copy link
Member Author

coiax commented Dec 15, 2016

I thought about it, but I didn't want something to happen without them being told about it.

@forkingpath
Copy link
Contributor

Perhaps we should just put this on the ore box and let you leave the mining satchel behind.

@MimicFaux
Copy link

Having it auto-empty is a convenience. having the ability to leave the satchel behind is needless powercreep. You can do a lot with an extra inventory slot.

@KingPhilipIII
Copy link

Maybe have the auto empty only occur when the satchel is full. Cut down on empty spam.

@WJohn WJohn added the Feature Exposes new bugs in interesting ways label Dec 15, 2016
@FantasticFwoosh
Copy link
Contributor

LAYY-ZEE

Now miners don't have to expend effort emptying what bottom feeder minerals they get while going monster hunting to basically PVE even harder without any form of complaint. Not only powercreep but scandalous.

@ExcessiveUseOfCobblestone
Copy link
Contributor

I've had several times where I was messing around with inventory in lavaland and out of nowhere the tentacles of doom appear. With that said, I don't think we should remove "pointless clicking" when it, although minutely, averts you away from your surroundings [aka not entirely pointless].

@imtakingabreakdontatme
Copy link
Contributor

Maybe I'm just insane but clicking on all the different fiddly inventory things gives me a sense of interaction. Smashing objects together gives me immersion.

@MrStonedOne I know you share similar bad taste back me up

@optimumtact optimumtact merged commit 2f521b1 into tgstation:master Dec 18, 2016
@PKPenguin321
Copy link
Contributor

oranges what about design lead kor's opinion

@optimumtact
Copy link
Member

It was wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet