Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes plasmamen not fire immune if they are set on fire by the atmosphere, but makes them not react with the atmosphere while in spaceproof clothing. #23015

Merged
merged 5 commits into from Jan 18, 2017

Conversation

XDTM
Copy link
Contributor

@XDTM XDTM commented Jan 14, 2017

馃啈 XDTM
fix: Plasmamen that are set on fire by reacting with oxygen will burn even if they have protective clothing. It will still protect from external fire sources.
tweak: Atmos-sealing clothing, like hardsuits, will protect plasmamen from reacting with the atmosphere.
tweak: Plasmamen can survive up to 1 mole of oxygen before burning, instead of burning with any hint of oxygen.
/:cl:

Fixes #19774 and #15985.

Fire handling code has been transferred from humans to species.

@lzimann lzimann added the Fix Rewrites a bug so it appears in different circumstances label Jan 14, 2017
@Mindustry
Copy link
Contributor

Fucking finally

@WJohn
Copy link
Contributor

WJohn commented Jan 14, 2017

now to add an oxygen threshold wherein plasmamen can walk around without their suits if it's below it.

@XDTM
Copy link
Contributor Author

XDTM commented Jan 14, 2017

0.01 is pretty much unachievable yeah

@XDTM
Copy link
Contributor Author

XDTM commented Jan 15, 2017

I used 1 mole as that's the amount that currently extinguishes fire, but i don't really know how much that is ingame or if it's high enough that you can scrub oxygen out of the air to make a livable zone.

@SweaterKittens
Copy link
Contributor

Some love for my plasma skellingtons, always makes me happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Refactor Makes the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plasmamen in hardsuits/firesuits stay on fire forever.
7 participants