Fixes orbiting click catcher. #23129
Conversation
| @@ -23,6 +23,8 @@ | |||
| master = null | |||
| return ..() | |||
|
|
|||
| /obj/screen/orbit(atom/A, radius = 10, clockwise = FALSE, rotation_speed = 20, rotation_segments = 36, pre_rotation = TRUE, lockinorbit = FALSE) | |||
There was a problem hiding this comment.
I think you don't need to specify the arguments if you're just going to ignore them.
| @@ -23,6 +23,8 @@ | |||
| master = null | |||
| return ..() | |||
|
|
|||
| /obj/screen/orbit(atom/A, radius, clockwise, rotation_speed, rotation_segments, pre_rotation, lockinorbit) | |||
There was a problem hiding this comment.
uh, no, they meant /obj/screen/orbit(), you don't need to pass in the args at all if you're just ignoring them.
There was a problem hiding this comment.
I'd rather have signatures same in case some crazy person decides to call them through named args.
There was a problem hiding this comment.
if you're having the signatures, put the default args back, if you're not putting the defaults back, remove the signatures.
your call, pick one (also hint: if it's A, don't commit it, just revert the previous one)
There was a problem hiding this comment.
Removing is easier from web interface 📯
|
actually commit-message-antur it'd be your fault for justifying it via your laziness and the web editor :P |
|
Shh |
I'm open to any ideas how to recognize UI elements better.