Allows bluespace body bags to be folded up with atoms inside (Winter Thaw 2017) #23249

ghost · 2017-01-22T20:16:13Z

This feature was created as part of the Winter Thaw of 2017 regardless of consensus or if it gets merged.

🆑 Xhuis
add: You can now fold up bluespace body bags with creatures or objects inside. You can't fold them up if too many things are inside, but anything you fold up in can be carried around in the object and redeployed at any time.
/:cl:

As requested by Bombadil.

You can't fold up these bags if they're at least half-full (7 atoms).
Creatures will slowly suffocate unless they have internals.
Destruction of the folded bag will cause all stored atoms to dump onto the turf of their holder.
Creatures can resist out of the bag if they're not restrained. This takes twenty seconds and destroys the bag, dumping out all of its contents onto the floor.

jughu · 2017-01-22T20:20:00Z

WHERE THE FUCK IS THAT GREYTIDER?
uh that way officer!!
officer runs away
whispers to bag shhh greytider mcshiterson your safe in there

ghost · 2017-01-22T20:20:46Z

I was more thinking "Oh hey, the nuke disk is in this bag! There's six other bags in that bag... and six other bags in that one... and..."

Incoming5643 · 2017-01-22T20:21:59Z

a way to struggle out would probably be a good idea because as it stands now if you stun a guy and put him in a bag it's effectively a one hit kill

jughu · 2017-01-22T20:22:27Z

cant ya make the nuke disk just to spawn away because having to go trough 100 bags would be stupid cant ya make it like 10 bags are the max untill the nuke disk dispears

ghost · 2017-01-22T20:24:23Z

@Incoming5643 That's probably true so I'll do that.
@jughu If people have enough resources and time to make recursive bodybags, who am I to stop them?

jughu · 2017-01-22T20:30:00Z

oh right i forgot you can destroy them and basically instantly drop all atoms

ghost · 2017-01-22T20:42:34Z

Creatures can now resist out of the bag after a twenty-second timer.

Kromgar · 2017-01-22T21:17:25Z

Next PR: Nuke Operatives can purchase bluespace body bags.

Forget locker ops we bodybag ops boys.

I've wanted this shit for years i am so glad i won the thaw. Can't wait for a round where the entire crew crawls into body bags and go an adventure.

So uh how exactly do you fold it? Drag to hand?

ghost · 2017-01-22T23:27:35Z

Yeah, fold it up the same as a normal body bag.

Zeldazackman · 2017-01-23T03:31:07Z

Fold up the bag and toss it into the crusher for an easy way to remove everything.

Also does their struggle reset depending upon if they were moved or not?

jughu · 2017-01-23T06:10:46Z

Just image a rev round a whole revulution in your backpack

Fox-McCloud · 2017-01-23T08:26:16Z

code/game/objects/items/bodybag.dm

+	qdel(src)
+
+/obj/item/bodybag/bluespace/container_resist(mob/living/user)
+	if(user.restrained())


if(user.incapacitated()

If they're knocked out, I don't believe that they can resist anyway.

If they're stunned though, it's a different story--there's also a few other cases where you may be able to resist---incapacitated cover all those cases.

Kromgar · 2017-01-23T12:41:03Z

New tactics

Be grayshit
Get permabrigged
While officers are dragging him into the brig Bright flash suddenly 21 people are in the brig

ghost · 2017-01-23T13:10:13Z

@Zeldazackman Resisting is not broken if the holder moves, no.

Kromgar · 2017-01-23T19:05:34Z

Testmerge when?

ghost · 2017-01-23T19:34:28Z

This doesn't really need a testmerge (unless that's official policy now?). It's small enough that it can just be put in as-is.

AdamElTablawy · 2017-01-24T14:39:43Z

Doesn't this mean you can literally store one to multiple people inside your backpack inside a folded up bodybag?

It's like cogscarabs in backpacks all over again

Kromgar · 2017-01-24T14:54:39Z

If you put a bluespace body bag folded up inside a bluespace bodybag... should probably send you into the astral plane- I mean bleuspace

XDTM · 2017-01-24T15:38:25Z

Should probably send people inside in a separate plane a la ninja room, since i suspect that right now they can call for help. Although that would cause issues with multiple bags.

ghost · 2017-01-24T16:49:24Z

I feel like it kind of makes sense to let them call for help. It's "bigger on the inside" but it's still just fabric.

Kromgar · 2017-01-24T18:24:52Z

This is why we have 10 morphine pills to make them go sleepy. Or straight jacket, muzzle and blindfold hehehe

imtakingabreakdontatme · 2017-01-24T21:35:18Z

code/game/objects/items/bodybag.dm

+		if(isliving(A))
+			A << "<span class='notice'>You suddenly feel air around you! You're free!</span>"
+			var/mob/living/L = A
+			L.Weaken(3)


Why the weaken?

It can go either way. I mainly wanted to prevent people just bursting out of the bags and zipping around instantly, but at the same time that's possible for other lockers. What do you think?

This is a pretty huge stun, maybe use 2 at most

ghost · 2017-01-25T00:15:20Z

I removed the stun from emerging from bags, but also prevented folded body bags from being stored inside of folded body bags.

imtakingabreakdontatme · 2017-01-25T04:21:43Z

Yeah this sounds fine now

imtakingabreakdontatme · 2017-01-25T04:22:30Z

code/game/objects/items/bodybag.dm

+		if(isliving(A))
+			A << "<span class='notice'>You suddenly feel the space around you torn apart! You're free!</span>"
+			var/mob/living/L = A
+			L.Weaken(3)


It came back somehow

NotLikeThis

ghost · 2017-01-25T13:43:39Z

Let me do some testing and squash commits before you merge this

ghost · 2017-01-25T13:52:53Z

All right, this is ready!

imtakingabreakdontatme · 2017-01-27T06:48:08Z

code/game/objects/structures/crates_lockers/closets/bodybag.dm

+			return 0
+		visible_message("<span class='notice'>[usr] folds up [src].</span>")
+		var/obj/item/bodybag/B = new foldedbag_path(get_turf(src))


Shouldn't this be one object that is stored and referenced by the bag rather than creating a new one every time you pick it up?

This is how regular body bags handle it. I don't really see why they would need to store a folded-up version inside of itself.

Regular bodybags are not up to current standard either then

Do you want me to refactor them, then? And why does the object need to be stored inside when creating a new one prevents possible runtimes and issues that occur as a result?

It is wasteful to create and delete the same object over and over

I'll work on this once I push a commit to the AI mech control PR.

Well, I ended up creating an infinite body bag generator. Genetics would be proud.

On a different note, would it be too much to ask for this to be merged and I can PR the refactor right afterwards separately? I don't want to include both a refactor and a new feature in the same PR, and I've been chewed out for that kind of non-atomization before.

@MrStonedOne we recently had a talk about the "cost" of creating objects. How expensive is creating a new object, vs the cost and complexity (and bugs) of storage of the same object

@KorPhaeron Generally we like to create item versions of things on the fly rather than hold it. see: Drones, Pipes, Walls, Floors, Chairs. Only if the item is likely to have something that can change about it that we want to persist do we store the item version.

so you're fine Xhuis

Fox-McCloud · 2017-01-28T09:41:25Z

code/game/objects/items/bodybag.dm

+		loc << "<span class='warning'>The pressure subsides. It seems that they've stopped resisting...</span>"
+		return
+	loc.visible_message("<span class='warning'>[user] suddenly appears in front of [loc]!</span>", "<span class='userdanger'>[user] breaks free of [src]!</span>")
+	qdel(src)


Shouldn't this just deploy it on a turf instead of destroying it?

I ruled against it. Tearing your way out of a bag makes it unusable.

I don't know, i feel like we won't see much of this if one person resisting deletes the whole gimmick. It costs diamonds after all.

True, but unzipping the bag will stop it, as will restraining them. It's also folded up, so it's not really possible to escape without causing damage.

Kromgar · 2017-01-29T03:25:58Z

😩

optimumtact · 2017-01-29T20:55:20Z

Work needed here

Kromgar · 2017-01-29T23:50:30Z

😭 @optimumtact

ghost · 2017-01-30T00:51:06Z

@optimumtact What work? Unless you're referencing what Kor said, but I don't want to include a refactor and a feature in the same PR.

PKPenguin321 · 2017-02-01T04:24:14Z

🎉 🎈

ghost · 2017-02-01T13:38:24Z

@Kromgar It happened

AnturK added the Feature Exposes new bugs in interesting ways label Jan 22, 2017

Fox-McCloud reviewed Jan 23, 2017

View reviewed changes

imtakingabreakdontatme reviewed Jan 24, 2017

View reviewed changes

imtakingabreakdontatme reviewed Jan 25, 2017

View reviewed changes

Bluespace body bags of holding

fcdb52c

imtakingabreakdontatme suggested changes Jan 27, 2017

View reviewed changes

Fox-McCloud reviewed Jan 28, 2017

View reviewed changes

optimumtact merged commit 3392591 into tgstation:master Feb 1, 2017

tgstation-server added a commit that referenced this pull request Feb 1, 2017

Automatic changelog generation for PR #23249 [ci skip]

1680572

ghost deleted the bluespace_bodybag_folding branch February 1, 2017 13:38

Allows bluespace body bags to be folded up with atoms inside (Winter Thaw 2017) #23249

Allows bluespace body bags to be folded up with atoms inside (Winter Thaw 2017) #23249

Conversation

ghost commented Jan 22, 2017 • edited by ghost

jughu commented Jan 22, 2017

ghost commented Jan 22, 2017

Incoming5643 commented Jan 22, 2017

jughu commented Jan 22, 2017

ghost commented Jan 22, 2017

jughu commented Jan 22, 2017

ghost commented Jan 22, 2017

Kromgar commented Jan 22, 2017 • edited

ghost commented Jan 22, 2017

Zeldazackman commented Jan 23, 2017

jughu commented Jan 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kromgar commented Jan 23, 2017

ghost commented Jan 23, 2017

Kromgar commented Jan 23, 2017

ghost commented Jan 23, 2017

AdamElTablawy commented Jan 24, 2017

Kromgar commented Jan 24, 2017

XDTM commented Jan 24, 2017

ghost commented Jan 24, 2017

Kromgar commented Jan 24, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 25, 2017

imtakingabreakdontatme commented Jan 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 25, 2017

ghost commented Jan 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imtakingabreakdontatme Jan 27, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrStonedOne Jan 30, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fox-McCloud Jan 28, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kromgar commented Jan 29, 2017

optimumtact commented Jan 29, 2017

Kromgar commented Jan 29, 2017

ghost commented Jan 30, 2017 • edited by ghost

PKPenguin321 commented Feb 1, 2017

ghost commented Feb 1, 2017

ghost commented Jan 22, 2017 •

edited by ghost

Kromgar commented Jan 22, 2017 •

edited

Kromgar commented Jan 24, 2017 •

edited

imtakingabreakdontatme Jan 27, 2017 •

edited

MrStonedOne Jan 30, 2017 •

edited

Fox-McCloud Jan 28, 2017 •

edited

ghost commented Jan 30, 2017 •

edited by ghost