Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signaler QoL #23340

Merged
merged 2 commits into from Jan 29, 2017
Merged

Signaler QoL #23340

merged 2 commits into from Jan 29, 2017

Conversation

ExcessiveUseOfCobblestone
Copy link
Contributor

https://tgstation13.org/phpBB/viewtopic.php?f=9&t=30&p=247728#p247542

THIS KILLS TACTICAL SIGNALERS

🆑 Cobby
add: You can now copy one signaler's settings to another by hitting it on the other signaler. [Credit to Weepo for the idea]
/🆑

2557 > using github application
2557 > testing your code

if someone could make that changelog simpler please hmu

In case someone was confused on the function.

  • You have Signaler1 and Signaler2
  • Signaler 1 is in active hand
  • clicking signaler2 with hand+signaler1 edits Signaler2's code and frequency

@lzimann lzimann added the Feature Exposes new bugs in interesting ways label Jan 26, 2017
@Core0verload
Copy link
Contributor

Core0verload commented Jan 26, 2017

>2557 >not knowing how to use markdown

@Kromgar
Copy link
Contributor

Kromgar commented Jan 26, 2017

POWERCREEP

@Supermichael777
Copy link
Contributor

Its add:
not :add:

@SweaterKittens
Copy link
Contributor

🆑 Cobby
add: You can now copy one signaler's settings to another by hitting it on the other signaler. [Credit to Weepo for the idea]
/:cl:

How's that EC?

@ExcessiveUseOfCobblestone
Copy link
Contributor Author

thank you

@imtakingabreakdontatme
Copy link
Contributor

Should add the functionality to a signalers description so people have a way of knowing this exists

@Cyberboss
Copy link
Member

#23289 gets labelled as a tweak
This gets labelled as a feature

C O N S I S T E N C Y

edits desc and requires that both signalers be secured.
if(secured && signaler2.secured)
code = signaler2.code
frequency = signaler2.frequency
user << "You transfer the frequency and code of \the [signaler2.name] to \the [name]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user << "You transfer the frequency and code of [signaler2] to [src]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stinky src user

@optimumtact optimumtact merged commit 7821fb8 into tgstation:master Jan 29, 2017
Leshana added a commit to VOREStation/VOREStation that referenced this pull request Feb 5, 2017
* Just tap them together and settings are copied.
* Code copied from tgstation/tgstation#23340
Leshana added a commit to Leshana/Polaris that referenced this pull request Feb 5, 2017
…ther

* Just tap them together and settings are copied.
* Code copied from tgstation/tgstation#23340
Leshana added a commit to Leshana/Polaris that referenced this pull request Feb 5, 2017
…another

* Just tap them together and settings are copied.
* Code copied from tgstation/tgstation#23340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants