Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes death report SQL query #23656

Merged
merged 1 commit into from Feb 5, 2017
Merged

Fixes death report SQL query #23656

merged 1 commit into from Feb 5, 2017

Conversation

Jordie0608
Copy link
Member

@Jordie0608 Jordie0608 commented Feb 3, 2017

world.address is the local IP whereas world.internet_address is the external IP.
Query was causing SQL errors due to a missing '. I'm pretty sure this is causing all such queries to fail entirely but I can't see the DB so unsure.
@lzimann

lzi is a huge nerd
@Jordie0608 Jordie0608 added the Fix Rewrites a bug so it appears in different circumstances label Feb 3, 2017
@lzimann
Copy link
Contributor

lzimann commented Feb 3, 2017

i blame cyberboss

@Jordie0608
Copy link
Member Author

Jordie0608 commented Feb 3, 2017

That's ok I blame you.

@Cyberboss
Copy link
Member

Literally how is it my fault?

@lzimann
Copy link
Contributor

lzimann commented Feb 3, 2017

because i copied your PR

@Jordie0608
Copy link
Member Author

Lzi is being coy on merging this so i'm doing it myself to stop the whole db breaking stuff.

@Jordie0608 Jordie0608 merged commit 5172942 into tgstation:master Feb 5, 2017
@Jordie0608 Jordie0608 deleted the whoarewebutmenamidstsuchsheernerditudethatislzimann branch February 25, 2017 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants