Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the artistic toolbox and His Grace #23699

Merged
merged 5 commits into from Feb 8, 2017
Merged

Adds the artistic toolbox and His Grace #23699

merged 5 commits into from Feb 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2017

🆑 Xhuis
add: Artistic toolboxes now spawn in maintenance and possess various supplies for wire art and crayon art.
add: Traitors can now obtain His Grace. Chaplains can buy it for 20 TC, or it can be found in a surplus crate.
/:cl:

Come on, don't act like you weren't expecting this. I added job-specific traitor items, and there's no way I wouldn't at least try to get this added.

This item was entirely inspired by the Goonstation traitor item of the same name and general effect. All credit goes to them.

  • Adds His Grace, an item available to traitor chaplains for 20 telecrystals and from surplus crates with a 5% chance.
  • His Grace is a toolbox in a bright green color. When not awakened, it is called the "artistic toolbox" and, aside from being larger than normal toolboxes, has no other effects.
  • His Grace functions like a normal toolbox until a certain ritual is used to "awaken" it. To do this, fill the box with any assortment of organs and activate it in your hand. This shows a message and plays a sound to everyone currently online.
  • Once activated, His Grace will begin to thirst for blood. As it grows hungrier, its wielder gains different benefits, but the danger increases. Using His Grace effectively is a balancing act of keeping it hungry enough to give you powerful resistances while sating it enough to prevent it from turning on you.
  • Attacking a dead or unconscious person with His Grace will feed them to His Grace, resetting bloodthirst to zero, killing the victim if they weren't dead already, and storing their corpse inside of His Grace.
  • Bloodthirst starts at 0 and increments every second. For every victim His Grace has consumed, it will increase by an extra second every tick.
  • At 120 bloodthirst, His Grace will turn on and consume its wielder. If it has been dropped, it will instead attack and attempt to consume anyone nearby, and instantly devour anyone who picks it up.
  • If His Grace reaches 150 bloodthirst, it will fall back asleep and regurgitate the corpses of everyone that it has consumed.
  • His Grace grants different benefits depending on bloodthirst count.
    • 0-30 bloodthirst: No change
    • 30-60 bloodthirst: Force changes to 20
    • 60-90 bloodthirst: Force changes to 25, wielder heals 1/1/0.5/5/0.5 damage per tick
    • 90-110 bloodthirst: Force changes to 30, wielder heals 2/2/1/10/1 per tick, and stuns are reduced by 1 per tick
    • 110-120 bloodthirst: Force changes to 40, wielder heals 20/20/10/all/5 damage per tick and is immune to stuns
  • His Grace gives fluff messages at certain bloodthirst levels, and can be examined to show how many people have died to it and give a cryptic indicator of current bloodthirst.
  • If someone somehow revives from inside of His Grace, they can climb out by moving.

Also adds is_string_in_list and remove_strings_from_list procs for convenience and to make warning messages easier. I'm not sure how to make warning messages better, so if you have cleaner code I can use for them please tell me right away.

Sprites (unawakened and awakened)

his_memes

👍s go here please
V

@lzimann lzimann added the Feature Exposes new bugs in interesting ways label Feb 4, 2017
@Steelpoint
Copy link
Contributor

Chaplain last sighted dragging a locker full of corpses around the central primary hallway, all personal are advised to avoid contact until further notice.

So this is based off of a Goonstation item if I recall correctly. I think I would support this addition.

@Fox-McCloud
Copy link
Contributor

If I may be so bold as to suggest: ParadiseSS13/Paradise#4395 ParadiseSS13/Paradise#4667

IMO, it's a bit cleaner implementation

@ghost
Copy link
Author

ghost commented Feb 4, 2017

@Steelpoint Yeah, it's an old goon item that got removed because of the way they implemented it. People who examined it were given antag status, so people would gun down the wielder, examine it on purpose, and go on a rampage.

And yes, you can technically wield this in a pacifist manner if you have a ton of monkey corpses or something.

@Fox-McCloud I'm not a fan of the old method of deleting bodies and examine slaves.

@Militaires
Copy link

hey atleast credit goon they do hard work on this cool shit

@ghost
Copy link
Author

ghost commented Feb 4, 2017

Done. I made the sprites and code myself, though, so I only attributed them on the idea.

@Militaires
Copy link

Militaires commented Feb 4, 2017

cool, can I see sprites

edit: also use wj palette

@ghost
Copy link
Author

ghost commented Feb 4, 2017

Yeah, let me jump in-game

@harmonyn
Copy link

harmonyn commented Feb 4, 2017

job-specific traitor items are bad

@ghost
Copy link
Author

ghost commented Feb 4, 2017

Sprites added to OP.

@FantasticFwoosh
Copy link
Contributor

FantasticFwoosh commented Feb 4, 2017

Eats bodies then removes them from the game. Gee that sounds like that's going to make people VERY salty about being removed. About as bwoinkable on lowpop as incinerating the bodies when you're done.

If you're going that route, why not have the toolbox gib them then borrow the demon antag code to 'eat their soul' so it just becomes a soul repository (which you could use later to do chaplain things with, spare soul stones etc.) that self clears after the timer expires or claims your own soul when hungry as you describe.

Make 'his grace' or replacement object 15 tc then sell inactive soul stones for 1tc each, wowza army of ghosts.

Counter chaplain has to work to free souls before they are devoured.

@ghost
Copy link
Author

ghost commented Feb 4, 2017

I thought laughter demons had the same code, where they stored the body in the demon mob. I went this route because if (read: when) His Grace turns on his wielder or is left alone for too long, they'll spit the bodies out - and in the majority of cases I would imagine that the chaplain is either dead, eaten, or long gone from the box.

I don't want to gib people and force them out of their human bodies. If the chaplain wants to use soul shards then he can leave His Grace to his own devices for a while.

@TehZombehz
Copy link
Contributor

TehZombehz commented Feb 4, 2017

Having no knowledge of the item from Goonstation, I looked at this hoping it was a little snake wearing a crown and cloak.

Part of my brain was actually hoping this was just a tiny snek. I may need coffee.
Petty dialogue aside, job-specific antag items are neat looking from a distance, though this sure does seem kinda nonsensical. In this paranoia in deep space where nobody can hear you scream, a green tool box is searching for blood.

@FantasticFwoosh
Copy link
Contributor

@Xhuis your description that it'll spit the bodies out is contradictory to your description of it eating the bodies then going back to sleep.

To my understanding the slaughter demon stores the bodies within the 'blood' and q deletes bodies who have been under there too long associated to the demon who pulled them in then refreshes demon's health. (irreclaimable bodies littering where they can't be seen/interacted with else)

@ghost
Copy link
Author

ghost commented Feb 4, 2017

Oh! Sorry about misleading you, then. Bodies are never deleted and will always be spit out when His Grace falls to sleep.

@TehZombehz Yeah, it's kind of silly. But it's always been memorable to long-time goon players, and I figured it would be fun to add here.

@ghost
Copy link

ghost commented Feb 4, 2017

it already obviously shakes when awakened, do you mind me adding eyes and teeth to it?

@ghost
Copy link
Author

ghost commented Feb 4, 2017

Nah, I feel like part of the charm comes from the fact that it's just a toolbox. Nothing special about it. It's green, but that's it. Also, it's covered in blood and shaking. But just a toolbox.

@ghost
Copy link

ghost commented Feb 4, 2017

fair enough, i like that vision too I suppose. I was only thinking of the eyes when it was extremely hungry, but holders don't need even more warnings I guess.

@InsaneHyena
Copy link
Contributor

InsaneHyena commented Feb 4, 2017

Never expected to say this, but I'm really glad Xhuis coded something.

@ghost
Copy link

ghost commented Feb 4, 2017

are you joking, he's only been coding good things since like the revenant > umbra pr

@optimumtact
Copy link
Member

optimumtact commented Feb 4, 2017

if this pr gets 4 or more thumbs downs I will close this fantastic pr

@ghost
Copy link

ghost commented Feb 4, 2017

fuck you oranges Chap needs a further dose of N2SNOWFLAKE14

@darkpaladin109
Copy link

I'm only okay with this if you can retrieve the bodies out of the toolbox somehow, murderboners permanently removing people from the round isn't fun.

@ghost
Copy link

ghost commented Feb 4, 2017

you can

If His Grace reaches 150 bloodthirst, it will fall back asleep and regurgitate the corpses of everyone that it has consumed.
so literally just wait until his grace gets hungry enough to go asleep and you get all the bodies back.

@ghost
Copy link
Author

ghost commented Feb 4, 2017

@optimumtact REEEEEEEEEEEEEEEEEEEEEEE

@PKPenguin321
Copy link
Contributor

how did you make it shake like that

@ghost
Copy link
Author

ghost commented Feb 5, 2017

I made it an animated icon that shifts by 1 pixel in each direction. It's basically a slideshow that moves one pixel left, then up, then right, then down.

@Fox-McCloud
Copy link
Contributor

@Xhuis

The examine-slave thing was stripped out; it only makes the first person who attempts to open it the servant; no one else aside from the original opener is going to be a servant. Likewise, it doesn't delete bodies; it stores them in the toolbox itself and ejects them when the toolbox is destroyed.

@imtakingabreakdontatme
Copy link
Contributor

@Iamgoofball

Stop encouraging people to raid our pull requests "voting" you meme

@ghost
Copy link
Author

ghost commented Feb 5, 2017

New commit.

  • Adds an actual artistic toolbox that spawns in maintenance loot drops. It has a pack of crayons, a crowbar, and a coil of every wire color! It can hold more than normal toolboxes but weighs more.
  • His Grace is now a subtype of the artistic toolbox.

This is to prevent people screeching "CHAPLAIN TRAITOR REEEEEEEEEEEE" when they seem him carrying around a green toolbox, but also to give people a semi-reliable way to do wire art without having to rely on luck to get the colors they want.

Otherwise, this is merge-ready.

@ghost ghost changed the title Adds His Grace Adds the artistic toolbox and His Grace Feb 5, 2017
@ghost
Copy link

ghost commented Feb 5, 2017

Gonna set Chaplain on High again if this gets (test)merged!

@ghost
Copy link

ghost commented Feb 5, 2017

Wait, idea. If the Chaplain somehow gets the right access, they should be able to shove His Grace into a Beepsky/ED-209 to create a indiscriminate murderboning, shuttle-calling, robot of death of destruction.

Also, when the bloodlust gets real high (110+), there should be a loud evil laugh that most, if not all, of the station can hear.

@imtakingabreakdontatme
Copy link
Contributor

Gonna set Chaplain on High again if this gets (test)merged!

@Incoming5643 was right

@ghost
Copy link

ghost commented Feb 5, 2017

@KorPhaeron ?

@imtakingabreakdontatme
Copy link
Contributor

He was worried people would roll jobs purely to try out their antag items

@ghost
Copy link
Author

ghost commented Feb 5, 2017

Incoming was saying that people would roll certain jobs- what he said

@GunHog
Copy link
Contributor

GunHog commented Feb 5, 2017

Curiosity about the new items is to be expected, Kor. Ban the players that kill themselves after taking the job, but failing their antag roll. It will settle back down once people are familiar with the new thing.

@Iamgoofball
Copy link
Contributor

@KorPhaeron

  1. we don't acknowledge reddit meme votes because of how easy it is to spoof
  2. I didn't actually go to goon to tell them about this, IDK how hippie chron dudes found it, but I did link it to a guy I know who happens to play goon because I figured he'd think it's cool

@Iamgoofball
Copy link
Contributor

also @Xhuis @Incoming5643 @KorPhaeron whats the problem with people rolling underused jobs to try out features

@ghost
Copy link
Author

ghost commented Feb 6, 2017

I never said there is one. In fact, that's one of the reasons I'm making so many items! If people want to select a job just to roll the antag, and then they don't, they can still play as that job - and if they just off themselves, then it's a player problem and can be dealt with admin intervention.

@ChangelingRain ChangelingRain added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Feb 6, 2017
@Steelpoint
Copy link
Contributor

It makes logical sense that if a certain job gets a new, unique, item with some fan fare before hand that you should expect that job to pick up in popularity for a while.

@Incoming5643
Copy link
Contributor

Incoming5643 commented Feb 6, 2017

@Iamgoofball Chaplain is not an underused job anymore, check the stats page. Ever since the specialized null rods came in chaplain has gotten a healthy supply of power game picks for a one slot role.

@ghost
Copy link
Author

ghost commented Feb 6, 2017

Conflicts are fixed.

@Core0verload
Copy link
Contributor

Goonstation shit, instant 👎

@ghost
Copy link

ghost commented Feb 6, 2017

@Core0verload thanks for the suggestion, left feedback on your comment

@ghost
Copy link
Author

ghost commented Feb 6, 2017

Core has never been known for a tolerant and sane-minded person

@ghost
Copy link

ghost commented Feb 6, 2017

@ChangelingRain this does not have merge conflicts anymore

@Chronitonity
Copy link

@Iamgoofball i play here every once and a while, no one there including me is from hippie as far as i know

@optimumtact optimumtact merged commit 2199675 into tgstation:master Feb 8, 2017
@ghost
Copy link

ghost commented Feb 8, 2017

WOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet