Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Boxstation] Robotics Remap #24546

Merged
merged 8 commits into from Mar 2, 2017
Merged

[Boxstation] Robotics Remap #24546

merged 8 commits into from Mar 2, 2017

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Feb 28, 2017 •
edited

This PR is a split off my minor map change PR (#24502) and a continuation of my two year old Robotics Remap PR.

In game image.
newrobo

Thank you for reading.

🆑
add: Robotics and Mech Bay have seen a mapping overhaul on Boxstation.
add: A cautery surgical tool has been added to the Robotics surgical area on Boxstation.
/:cl:

@Steelpoint Steelpoint changed the title [Boxstation] [Boxstation] Robotics Remap Feb 28, 2017
@NullNeska
Copy link

I haven't been on box station in a hot minute but those R_walls look inconsistent. I could be wrong though.

@Steelpoint
Copy link
Contributor Author

Which rwalls?

@GunHog
Copy link
Contributor

GunHog commented Feb 28, 2017 •
edited

My previous comment, which is still relevant to this discussion has been posted below for your review. This feedback also includes ImFlavo's concern.

You are missing a fuel tank, two holopads (One for the mech bay, another for robotics lab), and the AI display within the room. The southern portion of the mech bay used to be R-walls, but that section is now part of the robotics lab, I guess. Did you decide to get rid of the windoor for the surgery room? I would have liked to keep it. Anyone who does not like having to open it can just click it to keep it open forever.

Another note, some of your items (Flashes, metals, etc) do not seem well sorted. Maybe add a table next to the console and move some things there so you do not have several mixed piles. The circuit imprinter needs to be kept clear! Players need to click there to get the boards, and those items are in the way.

Old Robotics below:
old robotics

@Steelpoint
Copy link
Contributor Author

Steelpoint commented Feb 28, 2017 •
edited

I've effected some minor changes, with a new image below.

I've slightly rearranged the circuit imprinter, added two holopads and a surgical windoor.

newrobo

@OtherDalfite
Copy link

Looks good. Im glad surgery is sort of hidden away since roboticists often have little they can do for killing someone discretely.

@ExcessiveUseOfCobblestone
Copy link
Contributor

Why does mech bay need rwalls when mechs have security measures of their own?

@GunHog
Copy link
Contributor

GunHog commented Feb 28, 2017

Good stuff, Steelpoint!

@RemieRichards
Copy link
Contributor

as I said on the other one.
make the surgery bit white please.

@GunHog
Copy link
Contributor

GunHog commented Feb 28, 2017

Why white? If you did that, it would meld into the other white tiles and would no longer look as much as a dedicated sub-room. I rather like the darker shade in the room, it looks slightly sinister that way.

@Steelpoint
Copy link
Contributor Author

Darker shade is nicer in my opinion, looks more like a backroom area.

@imtakingabreakdontatme
Copy link
Contributor

This looks like it will be a lot of extra running back and forth

@Aliannera
Copy link

Old Box robotics always felt cramped and tight, hopefully this helps open it up a bit, as other stations often feel more open. Not a big fan of surgery being it's own little chamber but it's not a huge deal. Just means moving brains/limbs/augments might be a little annoying at times.

Love dat mech bay though.

@InsaneHyena
Copy link
Contributor

Gonna repeat it. As a roboticist player, I don't like those changes.

  1. It's too big for no reason
  2. Surgery is isolated and too far, I won't be able to see front desk from the surgery table
  3. Conveyor belts are silly and don't serve any actual purpose

@Steelpoint
Copy link
Contributor Author

While I think its subjective, but I made the work area more 'open' because I personally more so prefer a open workspace to the more cramped workspace that we have currently.

I acknowledge that surgery is isolated, but this is part intentional, part necessary. You gain more privacy in your surgery, but you lose visibility.

The conveyor belts are the hill I'll die on to protect, it may be void of purpose but I think they are cool, and I like seeing the items being moved over to a work area.

@Dorsisdwarf
Copy link
Contributor

I actually like the conveyor belts more than the rest of the PR, they are indeed cool.

@Dorsisdwarf
Copy link
Contributor

Is there access restrictions on the weird windoor? why does it exist?

@Steelpoint
Merge branch 'master' of https://github.com/tgstation/-tg-station int…
a090a88 
…o RoboRemap

# Conflicts:
#	_maps/map_files/TgStation/tgstation.2.1.3.dmm
@Steelpoint
MergeConflict
9c859fe
@Steelpoint
Copy link
Contributor Author

Windoor has robotics access restrictions. Its there because I like it being there.

@imtakingabreakdontatme
Copy link
Contributor

The windoor will just make moving patients back and forth annoying

@Steelpoint
Copy link
Contributor Author

You can always click the windoor to keep it open forever

@GunHog
Copy link
Contributor

GunHog commented Mar 1, 2017

It will also be a cool place to kill people and make it slightly harder for them to run! 🗡️

@Steelpoint Steelpoint closed this Mar 1, 2017
@Steelpoint Steelpoint reopened this Mar 1, 2017
Jordie0608
Jordie0608 reviewed Mar 1, 2017
View reviewed changes
tgstation.dme Outdated
@@ -2042,4 +2042,5 @@
#include "interface\interface.dm"
#include "interface\stylesheet.dm"
#include "interface\skin.dmf"
#include "C:\Users\Steelpoint\Desktop\roboholdtemp.dmm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tgstation.mdme:2048:error: unable to open "C:/Users/Steelpoint/Desktop/roboholdtemp.dmm".

Hmmmmm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't even want to know how that got there.

@NullNeska
Copy link

qap42zw

For the most part entering robotics from outside requires breaking in via R_walls. except for these 2 walls where the arrows are pointing (ignore the arrow pointing at an R_wall)

@Robustin
Copy link
Contributor

Robustin commented Mar 1, 2017

Neat, I will add a heart and confetti emoji if you can give me a quick rundown on mapmerging, i.e. which version of python to download, how not to make shit terrible, etc.

@Jordie0608
Copy link
Member

@Robustin See https://tgstation13.org/wiki/Map_Merger

@optimumtact optimumtact merged commit a342528 into tgstation:master Mar 2, 2017
tgstation-server added a commit that referenced this pull request Mar 2, 2017
@tgstation-server
Automatic changelog generation for PR #24546 [ci skip]
aa373e8
@Steelpoint Steelpoint deleted the RoboRemap branch March 2, 2017 07:18
@Penguaro
Copy link
Contributor

Penguaro commented Mar 10, 2017 •
edited

@Steelpoint There is a problem with this map change. The Aft Robotics Fabricator is too far from the Robotics R&D Console to connect. An Issue was created for this. Issue #24912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jordie0608 Jordie0608 Jordie0608 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet