Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM speaks on engineering channel (now with 100% less conflicts) #25820

Closed
wants to merge 1 commit into from

Conversation

Qbopper
Copy link
Contributor

@Qbopper Qbopper commented Apr 2, 2017

馃啈 Qbopper
tweak: The supermatter crystal now sends its warning messages to the engineering channel. (if it's in critical condition the message will be sent to both common and engineering channels)
/:cl:

https://tgstation13.org/phpBB/viewtopic.php?f=10&t=10445#p275368

also changed New() to Initialize() as per cobby's request

@XDTM
Copy link
Contributor

XDTM commented Apr 2, 2017

balance change

@imtakingabreakdontatme
Copy link
Contributor

balance change that doesnt even compile

Into the trash it goes

@Qbopper
Copy link
Contributor Author

Qbopper commented Apr 2, 2017

Goddamnit why did I break it

Also forgot about the freeze rip

@Tokiko1
Copy link
Contributor

Tokiko1 commented Apr 3, 2017

Good balance change though.

@DaxDupont
Copy link
Contributor

Sounds like it will lead to shorter rounds.
The whole advanced warning thing were used as one of the primary reasons to replace the SM/Tesla.
The fact that it will only ping engineering radios circumvents that point since often there's only one or two persons on low-medium pop hours with an engineer radio and when the SM is gonna go off they are generally dead.
AI is generally non-existent and the cap's headset only has command and security enabled by default.
Seems kinda silly to use something as a reason to remove something relatively wanted and one of the most iconic things and then cause short rounds again.
Also, atmospherically the cries and the begging on the radio when the SM is starting to degrade is pretty hilarious/muh emurshion-y.
I mean if an antag wants to sabotage it they should do it properly and just pump in co2/flip bypass pump and pump heat back in straight/etc.

If you're still intent on removing it from the general radio, please add the command channel too. If something critical is going to go, command should get notifications too.

@Cyberboss
Copy link
Member

It's fine as it is in the PR. Cap, will know about it and can delegate orders as necessary. Everyone will scramble to engineering when the danger messages come

@DaxDupont
Copy link
Contributor

@Cyberboss Last time I had a captain's headset it had engineering off by default, I am not sure if that was a goof but that means captain wouldn't know.

@Cyberboss
Copy link
Member

Sounds like a bug

@Wyzack
Copy link

Wyzack commented Apr 3, 2017

I think the captain's headset has always had all the channels disabled other than common command and security, i assumed it was by design

@Qbopper
Copy link
Contributor Author

Qbopper commented Apr 4, 2017

the intention for this was to lengthen rounds, not shorten them

many people will panic at the sight of the SM reaching 10%, myself included even though I know better

lowpop is a concern but I don't know how you'd address that

@DaxDupont
Copy link
Contributor

@Qbopper But I think it will have the opposite effect, the messages more serve as pressure onto engineering or other people to fix it. It might fall on deaf ears otherwise.
I really think this is gonna lead to shorted rounds.
The shuttle generally only gets called when it reaches 40+ and recalls if they are fixed.

@Qbopper
Copy link
Contributor Author

Qbopper commented Apr 5, 2017

The messages are still sent out, though

I don't know how it goes on bagil but sybil has a bad habit of panic calling if the SM makes any noise at all

Lowering the percent at which the SM announces to common is possible, though - the main idea was to get people to stop shitting themselves when engineering has discrepancies well within acceptable bounds

@DaxDupont
Copy link
Contributor

Make the lower warnings engineering only and 40+ as general.
Between 40-70 is the threshold for a non-engineer to still have it fixed.

@Qbopper
Copy link
Contributor Author

Qbopper commented Apr 5, 2017

once the freeze is over I'll take a look at changing things around, then

40 sounds reasonable imo

@Qbopper Qbopper deleted the smchannel branch January 11, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants