Elevators #26937
Elevators #26937
Conversation
|
does it still knock people over? it shouldn't. |
|
Does it kill if someone is in the space on the other end? |
|
@ma44 yes but that makes sense and should stay. |
|
The knocking over occurs when it calls onshuttlemove on everything in the shuttle. Should I add an argument to onshuttlemove (ELEVATOR) and then check that in carbons onshuttlemove or can you think of a better way? |
|
@KorPhaeron an argument is fine. |
code/modules/shuttle/on_move.dm
Outdated
| @@ -3,7 +3,7 @@ | |||
| return | |||
|
|
|||
| // Called when shuttle attempts to move an atom. | |||
| /atom/movable/proc/onShuttleMove(turf/T1, rotation) | |||
| /atom/movable/proc/onShuttleMove(turf/T1, rotation, force = FALSE) | |||
code/modules/shuttle/shuttle.dm
Outdated
| @@ -517,7 +517,7 @@ | |||
|
|
|||
| //move mobile to new location | |||
| for(var/atom/movable/AM in T0) | |||
| if(AM.onShuttleMove(T1, rotation)) | |||
| if(AM.onShuttleMove(T1, rotation, force)) | |||
There was a problem hiding this comment.
potential change in functionality, make this argument source its value from the docking port object, and set it to false on your elevators.
eg:
/obj/docking_port/elevator
knockdown = FALSE
code/modules/shuttle/shuttle.dm
Outdated
| a hyperspace ripple!</span>", | ||
| "<span class='userdanger'>You feel an immense \ | ||
| crushing pressure as the space around you ripples.</span>") | ||
| M.visible_message("<span class='warning'>[src] slames into [M]!</span>" |
|
On the actual Planetstation, how hard would this be to do with the Aux Base? |
|
Can we get a rattling chain lift sound for the transition |
|
Ask Cuboos for that. |
|
https://www.youtube.com/watch?v=RCSbmSmyAcY for transition. |
ghost
mentioned this pull request
|
Did you mean to change regular shuttles to not hit people with hyperspace ripples anymore? |
|
Was trying to think of a generic message that would work for both |
It's a shuttle subtype that skips transit/ignition/ripples etc. Just simple up/down.
Not a very exciting PR