Plastic sheet production - Chemistry recipe #26940

FantasticFwoosh · 2017-05-05T14:57:41Z

🆑 Moonlighting Mac
Experiment: Due to budget cuts and oil synthesis replacing expensive processes of digging up haunted primeval ashwalker burial grounds, Nanotransen has taught chemists how to make plastic from chemicals in the hopes that new plastic products can reduce expenditure on metal and glass.
add: you can now make plastic sheets from chemistry out of heated up crude oil, ash & sodium chloride
/:cl:

This Pr is atomised from what was originally planned but functionally it allows a methodical way of getting plastic within the game in a usually small quantity (100 units of formula = 10 sheets), making it over and over again would be tedious to discourage mass production and still keep some value to importing a lot of it if you need it.

Look forward to more plastic products in the future to compliment this.

Nothing particularly fancy about it, toxic to consume (obviously not a great idea) compliments its crafting recipe which is far more interesting.

Now compiles and runs correctly, has been tested and works as expected (a little charcoal residue if there is leftover heated oil & ash but that's a nice touch) issues mostly down to my own silly little errors. 100 units in the reagent ratio = 10 sheets of plastic.

coiax · 2017-05-05T15:00:01Z

code/modules/reagents/chemistry/reagents/other_reagents.dm

+	M.adjustToxLoss(1, 0)
+	. = 1
+	..()
+


So is this reagent ever actually made?

It was a bit of a oversight post testing and realizing it was there. I left it in there in the case the recipe changes later (if people want to make glitter) or somehow people manage to cheat to get the reagent. It should be generic toxic (its not like i want people chugging it) anyway but its dead code not worth bothering about.

Didn't quite realise the action to make the plastic sheet actually consumed it instantly. Oops.

Short answer is in its liquid form it is not, futureproofing i guess.

Don't put in reagents that are producible "just in case", just take it out. You literally described it as dead code.

Well that's just my working excuse but since you mention it, sure ill just remove it before a maintainer blocks me with a crate of oranges requesting changes.

lordpidey · 2017-05-05T16:27:45Z

I like it. I especially like how it's possible to make some without using a chem dispenser.

Burn paper for ash
Salt shaker from bar
Scoop up oil from maint

Iamgoofball · 2017-05-05T16:42:35Z

code/modules/reagents/chemistry/recipes/others.dm

+
+/datum/chemical_reaction/plastic_polymers/on_reaction(datum/reagents/holder, created_volume)
+	var/location = get_turf(holder.my_atom)
+	for(var/i = 1, i <= created_volume, i++)


not how we do loops fam

P.S - that's borrowed from the cheese making recipe, so your irks are probably demanded there. It works anyway. (edit - soap is identical, it didn't compile at first so i adapted it in line with the other recipes on the crafting page)

What exactly did i do wrong papa goof.

read the contributing guidelines

don't be rude goof he is learning!

if you are going to copypaste, use the Plasma solidification / Gold solidification as a base

oh my god you idiot I want you to fix the for loop formatting to

go by the guidelines I told you to read

which you obviously didn't read by the way

go read them

I wish they had big font text like your posts. (You mean this part right?) just linking it would have been more helpful for somebody learning like myself.

All i wanted to do was make some plastic and i get caught up in demands for changes as to what i can gather that should have been applied to the entire spaghetti file.

'Muh Legacy' oldcode. Any more news about Remie @ExcessiveUseOfCobblestone? Contact me on the forums or the IRC if you can.

@FantasticFwoosh
for(var/i = 1, i <= created_volume, i++)
->
for(var/i in 1 to created_volume)

I noticed it too late @Militaires , ill fix it up.

@RemieRichards is this a explanation of the change or are you requesting that i should change it again because yours is more optimal?

Listening to feedback removing dead code for a chem that won't be seen, and a minor description change.

ExcessiveUseOfCobblestone · 2017-05-05T17:08:21Z

code/modules/reagents/chemistry/reagents/other_reagents.dm

+/datum/reagent/plastic_polymers
+	name = "plastic polymers"
+	id = "plastic_polymers"
+	description = "the petroleum based components of plastic, contact a coder if you can actually see this" 


I want to say you can see this in the chem master so probably not best to have this breaking the meta wall.

Although you shouldn't define an unobtainable reagent anyway

oh lol yes if this isn't suppose to be made then don't have it :^)

But you can't because the reagent is instantly consumed when it makes the plastic and is therefore inaccessible. If you can see it and have it stablised in a beaker to study it in such a position, its a bug.

if I get my github functioning on my desktop i'll set this up for you bb.

If you want to do it scrap it all and have it setup JUST LIKE the gold/plasma solidification.

https://github.com/FantasticFwoosh/tgstation/blob/83b15478140cd3e662bcf029310aa14dd31d2fd6/code/modules/reagents/chemistry/recipes/others.dm#L50

you can see chem descriptions, yeah

As to conform with community guidelines. Personally as a coder freshman i have no idea how this works, but half of me is glad its more compact way to type out.

octareenroon91 · 2017-05-06T17:08:28Z

Ash and sodium chloride make charcoal already

FantasticFwoosh · 2017-05-06T17:18:13Z

Yes, but thats why you mix the oil first, divide or create some oil to heat into ash, then add all the components to a cool beaker & heat up for plastic. It doesn't harshly overlap if you do it in a acceptable sequence.

If you make uneven amounts, it can leave residue charcoal from a hot beaker in the attempt to make plastic: Intended.

octareenroon91 · 2017-05-06T18:34:24Z

Then you're fighting a race condition. It's sensitive to whatever the DM and DD feel like doing.

lordpidey · 2017-05-06T19:57:41Z

Hmm, it might be best to bump up the required temp for charcoal then. Right now it's at 380, which is very close to 376.

FantasticFwoosh · 2017-05-06T20:37:59Z

No its not, stop fretting.

If you put in the exact reagent formula it makes, the oil forces the plastic recipe first. (5 oil, 2 salt, 3 ash) rather than the ash & salt together in heat & add oil (because thats illogical to heat up salt), in testing practice it's been consistent with my mixing method all the while.

Im not going to change it because people want to mix to make charcoal hence are being silly about their chemistry method order.

imtakingabreakdontatme · 2017-05-07T13:54:45Z

What can plastic even be used for?

Converting our infinite energy into matter never ends well

FantasticFwoosh · 2017-05-07T16:05:15Z

Right now plastic flaps & plastic golems (merged prior this post) but i plan to expand upon the system more and make it more widespread, covering some holes in production of objects.

spray bottles, blood bags etc.

That is unless you want to change oil completely and make us mine it out of the ground via mekhi pumps on lava-land.

FantasticFwoosh added 3 commits May 5, 2017 13:02

Adds plastic sheet crafting recipie

70c5d4d

Adds plastic polymer reagent

8b7bc5a

Nothing particularly fancy about it, toxic to consume (obviously not a great idea) compliments its crafting recipe which is far more interesting.

tgstation-server added the Feature Exposes new bugs in interesting ways label May 5, 2017

FantasticFwoosh changed the title ~~Plastic sheet production - Chemistry recipie~~ Plastic sheet production - Chemistry recipe May 5, 2017

coiax reviewed May 5, 2017

View reviewed changes

Iamgoofball reviewed May 5, 2017

View reviewed changes

Consistency changes

83b1547

Listening to feedback removing dead code for a chem that won't be seen, and a minor description change.

ExcessiveUseOfCobblestone reviewed May 5, 2017

View reviewed changes

Fixes looping

cea6bc7

As to conform with community guidelines. Personally as a coder freshman i have no idea how this works, but half of me is glad its more compact way to type out.

Rectifies description

5f74387

lzimann merged commit ef48e1c into tgstation:master May 7, 2017

tgstation-server added a commit that referenced this pull request May 7, 2017

Automatic changelog generation for PR #26940 [ci skip]

27c0233

ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 May 7, 2017

Plastic sheet production - Chemistry recipe (#26940)

4a0ad54

ghost mentioned this pull request May 7, 2017

[MIRROR] Plastic sheet production - Chemistry recipe HippieStation/HippieStationdeprecated2020#1061

Merged

CitadelStationBot mentioned this pull request May 7, 2017

[MIRROR] Plastic sheet production - Chemistry recipe Citadel-Station-13/Citadel-Station-13#841

Merged

FantasticFwoosh deleted the FutureIsHere branch May 8, 2017 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plastic sheet production - Chemistry recipe #26940

Plastic sheet production - Chemistry recipe #26940

FantasticFwoosh commented May 5, 2017 •

edited

coiax May 5, 2017

FantasticFwoosh May 5, 2017 •

edited

coiax May 5, 2017

FantasticFwoosh May 5, 2017

lordpidey commented May 5, 2017

Iamgoofball May 5, 2017

FantasticFwoosh May 5, 2017 •

edited

Iamgoofball May 5, 2017

ExcessiveUseOfCobblestone May 5, 2017

ExcessiveUseOfCobblestone May 5, 2017

Iamgoofball May 5, 2017

Iamgoofball May 5, 2017

FantasticFwoosh May 5, 2017 •

edited

RemieRichards May 6, 2017

FantasticFwoosh May 7, 2017

ExcessiveUseOfCobblestone May 5, 2017

coiax May 5, 2017

ExcessiveUseOfCobblestone May 5, 2017

FantasticFwoosh May 5, 2017 •

edited

ExcessiveUseOfCobblestone May 5, 2017 •

edited

Iamgoofball May 5, 2017

octareenroon91 commented May 6, 2017

FantasticFwoosh commented May 6, 2017 •

edited

octareenroon91 commented May 6, 2017

lordpidey commented May 6, 2017

FantasticFwoosh commented May 6, 2017 •

edited

imtakingabreakdontatme commented May 7, 2017

FantasticFwoosh commented May 7, 2017 •

edited

Plastic sheet production - Chemistry recipe #26940

Plastic sheet production - Chemistry recipe #26940

Conversation

FantasticFwoosh commented May 5, 2017 • edited

Choose a reason for hiding this comment

FantasticFwoosh May 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lordpidey commented May 5, 2017

Choose a reason for hiding this comment

FantasticFwoosh May 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

read the contributing guidelines

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

go by the guidelines I told you to read

Choose a reason for hiding this comment

go read them

FantasticFwoosh May 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FantasticFwoosh May 5, 2017 • edited

Choose a reason for hiding this comment

ExcessiveUseOfCobblestone May 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octareenroon91 commented May 6, 2017

FantasticFwoosh commented May 6, 2017 • edited

octareenroon91 commented May 6, 2017

lordpidey commented May 6, 2017

FantasticFwoosh commented May 6, 2017 • edited

imtakingabreakdontatme commented May 7, 2017

FantasticFwoosh commented May 7, 2017 • edited

FantasticFwoosh commented May 5, 2017 •

edited

FantasticFwoosh May 5, 2017 •

edited

FantasticFwoosh May 5, 2017 •

edited

FantasticFwoosh May 5, 2017 •

edited

FantasticFwoosh May 5, 2017 •

edited

ExcessiveUseOfCobblestone May 5, 2017 •

edited

FantasticFwoosh commented May 6, 2017 •

edited

FantasticFwoosh commented May 6, 2017 •

edited

FantasticFwoosh commented May 7, 2017 •

edited