New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Head-on-a-stick #28201
Head-on-a-stick #28201
Conversation
Viva |
To do: Just clicking a spear with a head will also attach it |
upvote |
Just glass spears or bone spears too? |
Bone spears are their own separate thing instead of being a subtype of regular spears for whatever reason, so no. |
make the heads sit atop the spears instead of being in the middle. The spear should just barely stick out of the head |
Yeah it kinda makes no sense for them to be midway down the spear unless you tied their heads there |
I've been waiting for this feature, now ashwalkers can finally line the tunnels to their nest with the heads of unrobust miners. |
Make the spears wrenchable or something so we can keep them in place as a form of Decoration. |
@Pascal125 Spears start anchored, having them wrenchable seems odd for what is a head on a stick. They place on the spot where you crafted them. |
Let crowbars remove them out of the ground or something or add rods/metal to make a basing. Some other little decorative spikes or something. |
Can you make the rod color different so it doesn't blend with the floor |
@Tacolizard The heads are just an overlay added on to the spike, the heads themselves are technically inside the spike for storage purposes. @Iamgoofball The rod uses the same exact color pallete as regular spears and having the spears magically shift their hue slightly might look off. Really only an issue on some station tiling, anyway. |
icon = 'icons/obj/structures.dmi' | ||
icon_state = "headpike" | ||
density = 0 | ||
anchored = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FALSE, TRUE
..() | ||
var/obj/item/bodypart/head/H = locate() in contents | ||
if(H) | ||
overlays = H.overlays //head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things.
- this line should be in
update_icon()
- It won't work with overlay_queuing. You need
copy_overlays(H, TRUE)
var/obj/item/bodypart/head/H = locate() in contents | ||
var/obj/item/weapon/twohanded/spear/S = locate() in contents | ||
if(H && S) | ||
to_chat(user, "<span class='notice'>You take down the head spike.</span>") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You take down [src]
to_chat(user, "<span class='notice'>You take down the head spike.</span>") | ||
H.forceMove(get_turf(src)) | ||
S.forceMove(get_turf(src)) | ||
qdel(src) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unindent this qdel
That's the most common station tile by far though, and I think players can mind a slight hue shift or outlining to allow you to be able to actually see it while moving instead of just a head on a floor tile. |
just change the color of the spear in it's icon. Don't make it change color when spiked |
i withhold all my emojis until you make the heads be closer to the top of the spear |
it'd also be better if it wasn't aligned with the floor tile. makes it hard to tell there's even a spear there at all. |
Ashwalkers can now farm legions to get heads for their decorating |
Easy fix for the station tiles, randomly pixel shift them 12px to the right or left |
update_icon() | ||
name = "[H.real_name]'s head on a spear" | ||
|
||
/obj/structure/headpike/Initialize() | ||
pixel_x = rand(-8, 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. = ..()
..() | ||
var/obj/item/bodypart/head/H = locate() in contents | ||
if(H) | ||
copy_overlays(H, TRUE) //copy the head's visuals to put on the spear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var/mutable_appearance/MA = new()
MA.overlays = H.overlays.Copy()
MA.pixel_y = 12 //Or some value that lines it up on the spike bit better
add_overlay(MA)
This will fix the head being in the middle, and put it on the top.
Would be nice if you can keep a hat on a dismembered head. Good addition otherwise. |
should be able to be deepfried too |
..() | ||
var/obj/item/bodypart/head/H = locate() in contents | ||
if(H) | ||
copy_overlays(H, TRUE) //copy the head's visuals to put on the spear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move 馃憦 overlay 馃憦 calls 馃憦 to 馃憦 update 馃憦 icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no.
do what I said.
(and then move it to update_icon()
)
var/obj/item/bodypart/head/H = locate() in contents | ||
var/mutable_appearance/MA = new() | ||
if(H) | ||
MA.overlays = H.overlays.Copy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It pains me to delay this PR, but you'll have to wait for #28233 to be merged so you can do this the right way
var/mutable_appearance/MA = new() | ||
if(H) | ||
MA.overlays = H.overlays.Copy() | ||
MA.pixel_y = 12 //Or some value that lines it up on the spike bit better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really? the comment was meant for you, not the code ;_;
@MMMiracles pls do the needful |
Ping for reopen |
馃啈 MMMiracles
add: You can now adorn spears with the heads of your fallen enemies to act as a deterrence to those who dare challenge you.
/:cl:
Simple enough. You get a spear and a head, then you combine them in the tribal section of the crafting menu. Clicking on the head spike will take it down and give back the head and spear.