Applies a temporary fix over player_list having a null until the proper solution is found #28751
Conversation
lzimann
changed the title
|
This is always related to somebody getting kicked back to lobby. it tends to be a runtime in destroy preventing ..() from getting called. Edit, could also be logout, i can't remember what assigns to player list |
|
I'll look over that aswell. |
|
could you log the type of the null somehow, maybe by making it an assoc list via |
|
Could probably be done and way more helpful than a stack trace. |
|
Also @MrStonedOne |
|
I am not totally sure if it will keep the type if it becomes a null, but better than nothing. |
code/modules/mob/living/say.dm
Outdated
| @@ -225,8 +225,8 @@ GLOBAL_LIST_INIT(department_radio_keys, list( | |||
| for(var/_M in GLOB.player_list) | |||
| var/mob/M = _M | |||
| if(!M) | |||
| stack_trace("Null detected in player_list. Type: [GLOB.player_list[M]]") | |||
| listclearnulls(GLOB.player_list) | |||
There was a problem hiding this comment.
You should probably remove this in case there's multiple nulls, which could be important info.
code/modules/mob/living/say.dm
Outdated
| @@ -224,6 +224,10 @@ GLOBAL_LIST_INIT(department_radio_keys, list( | |||
| var/list/the_dead = list() | |||
| for(var/_M in GLOB.player_list) | |||
| var/mob/M = _M | |||
| if(!M) | |||
| stack_trace("Null detected in player_list. Type: [GLOB.player_list[M]]") | |||
There was a problem hiding this comment.
there is a flaw here.
This reverts commit dfa9ef0.
|
If the problem is Destroy runtiming, maybe instead, add this line after the Destroy call in qdel? |
|
Feels kinda awful to add that check to qdel though. |
|
This bug is pretty awful, tbh
…On Jun 25, 2017 10:05 AM, "Leo" ***@***.***> wrote:
Feels kinda awful to add that check to qdel though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28751 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHywep1fsCh3a-hVxiViKoGAJhtkSQFhks5sHmk8gaJpZM4OELw7>
.
|
|
Eh, this would require proper tracking, which then would require a bunch of changes to player_list. |
So basically something is not being removed from the
GLOB.player_listproperly. This doesn't seem to happen as often(I believe pAIs were causing it aswell) but they still do.I'm well aware this is not the solution to the problem, but a temporary bandaid is better than
bleedingruntiming to death.