Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late join antagonists will try to target late join players #31560

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Oct 11, 2017

To address some concerns in this thread: https://tgstation13.org/phpBB/viewtopic.php?f=9&t=13322

@Cyberboss Cyberboss added Tweak Do Not Merge You must have really upset someone labels Oct 11, 2017
@Cyberboss
Copy link
Member Author

#31570

@Cyberboss Cyberboss removed the Do Not Merge You must have really upset someone label Oct 24, 2017
@ChangelingRain ChangelingRain merged commit 5a4f56b into tgstation:master Oct 24, 2017
ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 Oct 24, 2017
@Cyberboss Cyberboss deleted the DelayedTargets branch October 24, 2017 01:14
MrStonedOne added a commit to MrStonedOne/tgstation that referenced this pull request Oct 24, 2017
ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 Oct 27, 2017
* Inlines compile_overlays

* Optimizes COMPILE_OVERLAYS

* Add missing '\'

* fixes reflectors dropping extra mats

* Selecting multiple choice polls with 1 choice now become a single option poll

* Update mecha_defense.dm (#31834)

* Fixes grinders (#31885)

* But you're still hungry

* Update reagentgrinder.dm

* Automatic changelog generation for PR #31885 [ci skip]

* Removes duplicate typecaches (#31883)

* Audits all typecache calls for performance gains

* Fix invalid var

* Makes cleanbots clean up remains (#31876)

* Makes cleanbots clean up remains

* Gooooooooo

* Acid_act

* fixes AIs being able to teleport the id card console inserted cards to their core (#32003)

* Update card.dm

* Update card.dm

* Fixes get_turf_pixel returning null when called on turfs (#32000)

* Removes mob references from camera motion tracking (#32002)

* Delicious Ron's Country Club Cameras

* requested changes

* requested changes 2: electric boogaloo

* Requested changes 3: back to perfection

* Automatic changelog generation for PR #32002 [ci skip]

* Fixes missing mag controllers on delta (#32006)

* Rebalances clockwork marauders

* Fixes teleporters not actually denying teleports from Centcom

* Atmos construction rework again (#31944)

* initial atmos construction commit ft todo list

* cleans up pipe/construction.dm

* compile

* rpd tgui

* revert rpd tgui because no icon support zzzzzz

* fixes RPD

also fixes the one RPD bug i caused the last time i touched pipe construction where you'd get null pipes if you switched from disposals to atmos pipes

* cleanup

* Use phpenv for the php build, instead of a PPA

* Late join antagonists will try to target late join players (#31560)

* Fixes shades hearing heartbeats

* Fixes changling golem exploit

* Blacklists holo injectors from surplus crates (#32001)

* Update uplink_item.dm

* Update uplink_item.dm

* Automatic changelog generation for PR #32001 [ci skip]

* Automatic changelog compile, [ci skip]

* Fixes xenobio sentience giving the wrong name (#32016)

* Automatic changelog generation for PR #32016 [ci skip]

* Moves opened firedoors underneath opened airlocks (#32018)

* Moves opened firedoors underneath opened airlocks

* Shutters

* Corrects disabled vent in delta toxins lab.

* Fixes heartbeat message spam

* Update crayons.dm (#32024)

* fixes pentetic acid dealing radiation damage instead of healing it (#32027)

* Update medicine_reagents.dm

* sorry i alughed so hard i hit a key

* adds logging to ripley gibs (#32032)

* maybe this works, and maybe it doesn't

* cyberfriend

* oh right

* Automatic changelog compile, [ci skip]

* FIXES THE NEW LATEJOIN RUNTIME PROPER (#32068)

* FIXES EVERYTHING IN ONE SIMPLE LINE

* Fix it properly

* Dullahans (#31855)

* Dullahans

* Vision toggle

* The worst part of the code right here

* No wings

* to_chat

* Hearing relay that works, vision toggle that works

* Fixes hair not appearing on severed heads

* Halloween event

* Moves dullahans to their own file

* Forgot to commit a file

* Fixes deafness and backpack issues

* Don't need to breath because you dont have a head

* Breaking the dullahan rules

* Encourage dullahans to lose their heads

* Cyberboss doing his job to head off any bad code trying to enter the repo

* Committing while compiling again

* Can't eat

* Halloween!

* qdeleted

* Get rid of the head var entirely, just track the easily deletable relay

* Moves the stuff out of process to destroy

* Automatic changelog generation for PR #31855 [ci skip]

* Transit space blocks explosions

* Automatic changelog compile, [ci skip]

* Ratvar summoning now ends the round/triggers mass proselytize  (#31956)

* Slight changes to ratvar ending

* Tick check

* T

* Why Xhuis?

* Lots of fire

* That src made sense 10 minutes ago but no longer

* More commits than line changes

* Check Tick

* heart of darkness revives non-shadow as shadowpeople

* Automatic changelog generation for PR #31912 [ci skip]

* Footprints no longer contain stupid amounts of blood (#32056)

* Fixes supermatter tongs not updating icon if the sliver is dropped

* Automatic changelog generation for PR #32061 [ci skip]

* Automatic changelog generation for PR #32059 [ci skip]

* Shuttle navigation computers ignore the shuttle when placing a new location (#31722)

* Fixed the shuttle navigation computer allowing you to move stationary docking ports

* Made the shuttle navigation computer ignore the shuttle it controls when determining valid turfs

* Removed a redundant list

* Moved a var from stationary docking ports to mobile docking ports

* Removed a sanity check

* Automatic changelog generation for PR #31722 [ci skip]

* Automatic changelog compile, [ci skip]

* Fixes being able to stack stargazers on one tile (#32085)

* Automatic changelog generation for PR #32085 [ci skip]

* Fixes excessive overlay churn  (#32065)

* Fixes excessive overlay chern

Adding an overlay on every cross and uncross of every player (with how bloody the station gets this is called on just about every fucking movement, some times multiple times if there are multiple types of stains (oil, blood, alien, etc) is an excessive as fuck amount of chern in the overlay subsystem.

This is likely the cause of overlays being so high.

* I APOLOGIZE FOR NOTHING!

* Cogscarab shells/construct chassis on spawn menu (#32048)

* Automatic changelog generation for PR #32048 [ci skip]

* Greyscale cables (#31972)

* cable code is shit

* cleanup

* Automatic changelog generation for PR #31972 [ci skip]

* Fixes pipe runetime

* Fixes braindead aliums

* Fixes light source qdel issues.

* 1

* Automatic changelog generation for PR #31954 [ci skip]

* Adds ambience to the SM and portable generators (#31945)

* Adds aambience to the SM and portable generators

* lowered pitch of supermatter

* start and end fix

* Automatic changelog generation for PR #31945 [ci skip]

* Fixes a runtime on organ replacement

* --no-edit

* Makes staff of change randomly assign a borg module

* Automatic changelog generation for PR #32075 [ci skip]

* Makes luxurious emergency shuttle noteleport

* Automatic changelog generation for PR #32057 [ci skip]

* Fixes minor runtime

* Fixes defib ghost prompt (#32019)

* Fixes #32013

* proc instead.

* Automatic changelog generation for PR #32019 [ci skip]

* Removes outdated tips

* Fixes lightgeist spawning

* Automatic changelog generation for PR #32058 [ci skip]

* Allows components to qdel from Initialize

* Actual performance improvements for GetAllContents (#32029)

* Actual performance improvements for GetAllContents

* Shaving off literal tens of clock cycles

* Automatic changelog generation for PR #32039 [ci skip]

* Automatic changelog generation for PR #31991 [ci skip]

* Webhook processor no longer removes [tags] from titles (#32053)

* Webhook processor no longer removes [tags] from titles

This was shit

* Does the oranges

* Halloween Tweaks (#32087)

* Halloween Tweaks

* Halloween Event Changes

* Vampire species for halloween (#32096)

* Vampires

* Action name

* Cooldown so you can't queue drains

* Blood drain rate

* Vampire cleanup/additional checks

* Vampires can drink blood (reagent) (#30)

* New DRINKSBLOOD species_trait

All species can drink blood, but species with this trait
will restore lost blood_volume when drinking it

* Vampires have vampire blood and DRINKSBLOOD

People with vampire blood can take all other blood
Vampire blood can't be used for anyone that doesn't have it

* Vampire tweaks (#31)

* Universal Blood

* Removes spell on species loss

* Vampire heart for checking blood level

* Automatic changelog generation for PR #32096 [ci skip]

* Fixes losing species preferences (#32093)

* Forgot to credit JJRcop for help with vampires

* Automatic changelog compile, [ci skip]
ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 Oct 28, 2017
* Adds a method to transfer all components from one datum to another

* Inlines compile_overlays

* Optimizes COMPILE_OVERLAYS

* Add missing '\'

* fixes reflectors dropping extra mats

* Selecting multiple choice polls with 1 choice now become a single option poll

* Update mecha_defense.dm (#31834)

* Fixes grinders (#31885)

* But you're still hungry

* Update reagentgrinder.dm

* Automatic changelog generation for PR #31885 [ci skip]

* Removes duplicate typecaches (#31883)

* Audits all typecache calls for performance gains

* Fix invalid var

* Makes cleanbots clean up remains (#31876)

* Makes cleanbots clean up remains

* Gooooooooo

* Acid_act

* fixes AIs being able to teleport the id card console inserted cards to their core (#32003)

* Update card.dm

* Update card.dm

* Fixes get_turf_pixel returning null when called on turfs (#32000)

* Removes mob references from camera motion tracking (#32002)

* Delicious Ron's Country Club Cameras

* requested changes

* requested changes 2: electric boogaloo

* Requested changes 3: back to perfection

* Automatic changelog generation for PR #32002 [ci skip]

* Fixes missing mag controllers on delta (#32006)

* Rebalances clockwork marauders

* Fixes teleporters not actually denying teleports from Centcom

* Atmos construction rework again (#31944)

* initial atmos construction commit ft todo list

* cleans up pipe/construction.dm

* compile

* rpd tgui

* revert rpd tgui because no icon support zzzzzz

* fixes RPD

also fixes the one RPD bug i caused the last time i touched pipe construction where you'd get null pipes if you switched from disposals to atmos pipes

* cleanup

* Use phpenv for the php build, instead of a PPA

* Late join antagonists will try to target late join players (#31560)

* Fixes shades hearing heartbeats

* Fixes changling golem exploit

* Blacklists holo injectors from surplus crates (#32001)

* Update uplink_item.dm

* Update uplink_item.dm

* Automatic changelog generation for PR #32001 [ci skip]

* Automatic changelog compile, [ci skip]

* Fixes xenobio sentience giving the wrong name (#32016)

* Automatic changelog generation for PR #32016 [ci skip]

* Moves opened firedoors underneath opened airlocks (#32018)

* Moves opened firedoors underneath opened airlocks

* Shutters

* Corrects disabled vent in delta toxins lab.

* Fixes heartbeat message spam

* Update crayons.dm (#32024)

* fixes pentetic acid dealing radiation damage instead of healing it (#32027)

* Update medicine_reagents.dm

* sorry i alughed so hard i hit a key

* adds logging to ripley gibs (#32032)

* maybe this works, and maybe it doesn't

* cyberfriend

* oh right

* Automatic changelog compile, [ci skip]

* FIXES THE NEW LATEJOIN RUNTIME PROPER (#32068)

* FIXES EVERYTHING IN ONE SIMPLE LINE

* Fix it properly

* Dullahans (#31855)

* Dullahans

* Vision toggle

* The worst part of the code right here

* No wings

* to_chat

* Hearing relay that works, vision toggle that works

* Fixes hair not appearing on severed heads

* Halloween event

* Moves dullahans to their own file

* Forgot to commit a file

* Fixes deafness and backpack issues

* Don't need to breath because you dont have a head

* Breaking the dullahan rules

* Encourage dullahans to lose their heads

* Cyberboss doing his job to head off any bad code trying to enter the repo

* Committing while compiling again

* Can't eat

* Halloween!

* qdeleted

* Get rid of the head var entirely, just track the easily deletable relay

* Moves the stuff out of process to destroy

* Automatic changelog generation for PR #31855 [ci skip]

* Transit space blocks explosions

* Automatic changelog compile, [ci skip]

* Revheads now always recieve a HUD when created

* Ratvar summoning now ends the round/triggers mass proselytize  (#31956)

* Slight changes to ratvar ending

* Tick check

* T

* Why Xhuis?

* Lots of fire

* That src made sense 10 minutes ago but no longer

* More commits than line changes

* Check Tick

* heart of darkness revives non-shadow as shadowpeople

* Automatic changelog generation for PR #31912 [ci skip]

* Footprints no longer contain stupid amounts of blood (#32056)

* Fixes supermatter tongs not updating icon if the sliver is dropped

* Automatic changelog generation for PR #32061 [ci skip]

* Automatic changelog generation for PR #32059 [ci skip]

* Shuttle navigation computers ignore the shuttle when placing a new location (#31722)

* Fixed the shuttle navigation computer allowing you to move stationary docking ports

* Made the shuttle navigation computer ignore the shuttle it controls when determining valid turfs

* Removed a redundant list

* Moved a var from stationary docking ports to mobile docking ports

* Removed a sanity check

* Automatic changelog generation for PR #31722 [ci skip]

* Mummies for halloween

* Automatic changelog compile, [ci skip]

* Fixes being able to stack stargazers on one tile (#32085)

* Automatic changelog generation for PR #32085 [ci skip]

* Fixes excessive overlay churn  (#32065)

* Fixes excessive overlay chern

Adding an overlay on every cross and uncross of every player (with how bloody the station gets this is called on just about every fucking movement, some times multiple times if there are multiple types of stains (oil, blood, alien, etc) is an excessive as fuck amount of chern in the overlay subsystem.

This is likely the cause of overlays being so high.

* I APOLOGIZE FOR NOTHING!

* Cogscarab shells/construct chassis on spawn menu (#32048)

* Automatic changelog generation for PR #32048 [ci skip]

* Greyscale cables (#31972)

* cable code is shit

* cleanup

* Automatic changelog generation for PR #31972 [ci skip]

* Fixes pipe runetime

* Fixes braindead aliums

* Fixes light source qdel issues.

* 1

* Automatic changelog generation for PR #31954 [ci skip]

* Adds ambience to the SM and portable generators (#31945)

* Adds aambience to the SM and portable generators

* lowered pitch of supermatter

* start and end fix

* Automatic changelog generation for PR #31945 [ci skip]

* Fixes a runtime on organ replacement

* --no-edit

* Makes staff of change randomly assign a borg module

* Automatic changelog generation for PR #32075 [ci skip]

* Makes luxurious emergency shuttle noteleport

* Automatic changelog generation for PR #32057 [ci skip]

* Fixes minor runtime

* Fixes defib ghost prompt (#32019)

* Fixes #32013

* proc instead.

* Automatic changelog generation for PR #32019 [ci skip]

* Removes outdated tips

* Fixes lightgeist spawning

* Automatic changelog generation for PR #32058 [ci skip]

* Allows components to qdel from Initialize

* Line by line profiling system

This allows you to profile shit in a line by line fashion, getting a neat little report about how long (in milliseconds) was spent on what line(s).

Only one can be running at a time. You just have to call PROFILE_START then call PROFILE_TICK between lines, and finally, use profile_show(mob/client) to show the profile results to a mob. Profiles are sorted by avg cost per run.

Example usage: tgstation/tgstation@ef876c6#diff-7664a9b9849fbd5b5d688654469b26d9R417

Example output: https://gist.github.com/MrStonedOne/06a275be398499db41da702dde7fc518

* makes thermite a component

* Check again after waiting

* Actual performance improvements for GetAllContents (#32029)

* Actual performance improvements for GetAllContents

* Shaving off literal tens of clock cycles

* Automatic changelog generation for PR #32039 [ci skip]

* Automatic changelog generation for PR #31991 [ci skip]

* Webhook processor no longer removes [tags] from titles (#32053)

* Webhook processor no longer removes [tags] from titles

This was shit

* Does the oranges

* Halloween Tweaks (#32087)

* Halloween Tweaks

* Halloween Event Changes

* Updates the cloning manual

* Vampire species for halloween (#32096)

* Vampires

* Action name

* Cooldown so you can't queue drains

* Blood drain rate

* Vampire cleanup/additional checks

* Vampires can drink blood (reagent) (#30)

* New DRINKSBLOOD species_trait

All species can drink blood, but species with this trait
will restore lost blood_volume when drinking it

* Vampires have vampire blood and DRINKSBLOOD

People with vampire blood can take all other blood
Vampire blood can't be used for anyone that doesn't have it

* Vampire tweaks (#31)

* Universal Blood

* Removes spell on species loss

* Vampire heart for checking blood level

* Automatic changelog generation for PR #32096 [ci skip]

* Fixes losing species preferences (#32093)

* Forgot to credit JJRcop for help with vampires

* Automatic changelog compile, [ci skip]

* Blocks world proc calls

* Fix log call

* Makes ImmediateInvokeAsync a world proc

* cleanup

* debug verbs, less overhead, more sorts, fix for 16m call count bug

* Remove some unneeded null checks in lighting

These weren't needed, and ran thousands of times per second during high lighting activity, and were pretty high up in the line by line profile of lighting for what was basically a noop.

* Remove stray parent proc call in collector code

* Assmos part 1, #2 (#30791)

* First part of Assmos

* Adds tritium synthesis and basic in-body effects.

* Begins adding the higher tier gases. Removes Freon(not completely yet) adds new gases to scrubers. Fixes some dumb bugs.

* Whoops

* Adds effects and synthesis reactions for pluoxium and stimulum

* Kills Freon.

* Adds sprites

* Removes the magic numbers

* Hyper-Nobelium formation

* Removes Freon from maps.

* Initial Dunc Review changes

* Should ACTUALLY fix the maps this time.

* Dunc Final Review

* Debugging part 1

* Fixes brown gas synthesis

* Auto stash before merge of "assmos-pathconflicts" and "origin/master"

* fix compile errors

* Moves defines. Fixes stimulum coefficents.

* Reworks how Stim and brown gas work, adds tritium to tile fires, fixes a lot of general reaction bugs.

* fixes typo

* Hopefully fixes UI

* compiles tgui

* Tritium balance.

* Automatic changelog generation for PR #30791 [ci skip]

* More radiation balance changes and fixes (#32051)

* more balance changes and fixes

* cleanup

* Automatic changelog generation for PR #32051 [ci skip]

* Fixes motion runtimes from deleted targets (#32121)

* Add a safety check to buildmode, also fix a bug with corner selection (#32009)

* Update buildmode.dm

* Add files via upload

* Update buildmode.dm

* Update buildmode.dm

* Automatic changelog generation for PR #32009 [ci skip]

* Find references fix. (#32022)

* Find references fix.

Made it go from taking years to hours

Removed Datum based recursion, this was unneeded.

Fixed it calling a proc for what ended up being a costly noop millions of times (this was a moderate speed up as it would call DoSearchVar on every fucking number or string or null in a things vars list.)

Fixed it calling itself on the vars list. luckily it only checked keys, so this didn't stack overflow.

I'm intentionally leaving the debugging stuff in right now so that its on the record somewhere. I'll remove that when I pr line by line profiling as its own separate thing

* Remove debugging stuff

* i forgot

* Automatic changelog compile, [ci skip]

* Automatic changelog generation for PR #32116 [ci skip]

* Adds some new grindables to the grinder (#32107)

* Adds some new grindables to the grinder

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Update reagentgrinder.dm

* Adds the extra ")"

* Update reagentgrinder.dm

* Automatic changelog generation for PR #32107 [ci skip]

* Automatic changelog generation for PR #32112 [ci skip]

* build_appearance_list no longer edits the list it is passed (#32066)

* build_appearance_list no longer edits the list it is passed

* Mistakes were made

* Update overlays.dm

* Map config cleanup (#32132)

* Map config cleanup

* Fix

* Automatic changelog generation for PR #31864 [ci skip]

* Restricts some more areas from servant warp, and lets admins start the Ark on non-clockcult rounds (#31723)

* Cleans up clockcult code a little

* Another thing with servants_active

* Now it compiles

* Automatic changelog generation for PR #31723 [ci skip]

* Automatic changelog compile, [ci skip]

* Automatic changelog generation for PR #32108 [ci skip]

* Automatic changelog compile, [ci skip]

* Update DME & Maps

* meep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants