Moths #34243
Moths #34243
Conversation
ghost
requested a review
from 
|
no |
|
FUCKING SCREAMING |
|
Take a look at https://github.com/tgstation/tgstation/blob/master/code/modules/mob/living/carbon/human/species_types/flypeople.dm#L31 you might want to add something similar here. |
|
it begins |
|
Add that when a moth player sees a torch they have to compulsively follow it |
code/__HELPERS/names.dm
Outdated
| @@ -241,3 +241,9 @@ GLOBAL_VAR(syndicate_code_response) //Code response for traitors. | |||
| . += "." | |||
| else | |||
| . += ", " | |||
|
|
|||
| /proc/moth_name(gender) | |||
There was a problem hiding this comment.
I can't tell the difference between the names in each list so you should probably reconsider this proc.
code/modules/mob/living/emote.dm
Outdated
| if(ishuman(user)) | ||
| var/mob/living/carbon/human/H = user | ||
| if(H.dna.species.scream_sound) | ||
| playsound(H.loc, H.dna.species.scream_sound, 50, 1, 4, 1.2) |
There was a problem hiding this comment.
I do not think this is a good idea
There was a problem hiding this comment.
It's a port from hippie's screamsound mechanics. This is an unlogged change that should probably get added to the changelog.
There was a problem hiding this comment.
It also calls ..() twice in some situations which may be a bad
|
Leave the scream in. Without it, this pr is bad. with it, it's fantastic. |
|
Let them headbutt lights and break them on accident. |
|
No pc access rn you fuck |
|
The actual default variant of moth wings isn't set correctly, resulting in wingless moths. |
|
Balls |
|
I freaking love this. |
|
I'm...Worried, to say the least. As what goof said, Slippery slope. Maybe i'm just becoming disabled and have a lead pipe through my skull, but slippery slope, man. We already have citadel for this. |
|
Moths are the best thing to be added since atmospherics. |
optimumtact
added
Feature
|
What're their unique features? Without features to make them distinct, they're just reskinned humans. Screaming is not a unique feature. |
|
So, let's see:
That's barely anything. If you're going to add a silly race, at least make them interesting - A species's unique mechanics shouldn't consist of a mere 21 lines of code. They have wings, right? You could do something with that, rather than just saying "They're unuseable due to gravity.". In exchange, you could make them a highly fragile species. That's just a suggestion - Figure out a way to make them distinct. |
|
@BlueNexus Tell me, how are lizards unique? |
|
They aren't - But they should be. It makes very little sense that a species which evolved on an entirely different planet would be exactly identical to humans except in appearance. Regardless, this is a good opportunity to make a unique and interesting species. |
|
@BlueNexus apply the same arguments to lizards |
|
Moths now walk towards light. |
|
@MoreRobustThanYou bad, will be abused to grief. Make it a flavor text instead. |
|
Lizards are vunerable to cold but have heat resistance, have unique blood, can't possess certain genetics powers and have a tail organ ontop of cosmetic decals for horns/spine fins etc. Real question, how are mothpeople different to flypeople? If you want people to take this PR seriously.
|
|
Can you guys stop shitting up a PR that was made in good faith and is popular with a majority of the community in some awful attempt to settle petty discord grudges with a third party |
code/modules/mob/living/emote.dm
Outdated
| @@ -257,6 +256,8 @@ | |||
| message_mime = "acts out a scream!" | |||
| emote_type = EMOTE_AUDIBLE | |||
|
|
|||
| //here lies moth *scream. 2018-2018, murdered by oranges. | |||
code/game/machinery/teleporter.dm
Outdated
| to_chat(M, "<span class='italics'>You hear a buzzing in your ears.</span>") | ||
| human.set_species(/datum/species/fly) | ||
| else | ||
| to_chat(M, "<span class='italics'>You hear fluttering in your ears.</span>") |
There was a problem hiding this comment.
what justification do you have for this?
If they're going to be added it'll be a server decision to enable them as a race
There was a problem hiding this comment.
the whole fly thing is a backported reference and isn't subject to the same rules
| liked_food = VEGETABLES | DAIRY | ||
| disliked_food = FRUIT | GROSS | ||
| toxic_food = MEAT | RAW | ||
| //<pineapples> morty you need to listen to the people who have the merge button not randos in sligcord |
|
Joan did better |
New PR opened because I rebased old one.
<pineapples> reopen button greyed out🆑 More Robust Than You
add: Adds Moths! They're a new species that have (unusable due to gravity and shit) wings, and are prone to autism.
/:cl:
Why:
CREDITS TO @tortellinitony, @FuryMcFlurry, and @TDcoolguy300 for their original work on moths!