[DNM] Experimentor Refactor and Changes #35466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Code Improvement
|
can you still make random battery cells from it or is that gone? |
|
That's the transform reaction iirc, I still have to move it over to the new system. |
|
but muh timegate |
|
Get the fuckin timegate outta my house |
|
Finally someone does something with the blood-magic machine. Great stuff |
|
You forgot a stage |
tgstation-server
added
the
Merge Conflict
…dragonroll # Conflicts: # code/modules/research/experimentor.dm
tgstation-server
removed
the
Merge Conflict
- supermatter - setting people on fire - passive effects
- Makes experiment forcing actually work via VV - Adds cost effects and relic type datums - Appearance effects now correctly use /datum/relic_effect
|
oh I'm dumb the 5th stage missing (at that time) was intentional |
…till revamping the powergame machine
…dragonroll # Conflicts: # code/game/objects/items/grenades/clusterbuster.dm
|
is this ready? |
|
i'll remove the [DNM] and ping a maintainer when it is, shouldn't be long now but people keep asking me to fix bugs in unrelated things |
|
y tho |
|
stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
refactor: Refactored and modularized the Experimentor
add: Added some extra reactions for the Experimentor
tweak: The Experimentor generates points now instead of just boosting nodes whatever that does
code: Added the ability to change sounds for the clusterbuster, removed a spawn() and made it possible to clusterspawn objects other than grenades (why)
/:cl:
I only have one more commit to finish this or it will ruin the joke
Another step in the ladder to get rid of passive generation.
Experiment Results are now datumized, so new ones can be (and will be) added easily.
Experiment Results also generate points. They will only generate a meager amount of points, and the amount gained from each experiment result diminishes. The formula is
(base_points) / (number of times the result happened ^ 2), so full points for the first time, a quarter for the second, one ninth for the third, etc...