Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MortyMed: Part 1 #35803

Closed
wants to merge 11 commits into from
Closed

MortyMed: Part 1 #35803

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 18, 2018

🆑 More Robust Than You
experimental: TIME FOR A MEDICAL OVERHAUL, STRAIGHT FROM MRTY!
experimental: spoiler alert, it's a hybrid of vg and paramed
experimental: ------------------------
experimental: Spacemen can now feel pain.
experimental: Tramadol, Morphine, or Oxycodone can negate or reduce pain.
experimental: Too much pain equals shock!
experimental: ------------------------
experimental: Dragging people on the floor can hurt them, if they're bleeding!
experimental: Use roller beds, or lockers!
experimental: ------------------------
experimental: Added wheelchairs. Sprites from /vg/.
experimental: ------------------------
experimental: You are able to still walk around and use items, albeit slowly, in very early crit (<10 below 0)
experimental: ------------------------
experimental: Losing blood may result in temporary paralysis and loss of balance.
experimental: Losing wayy too much blood may result in cardiac arrest.
/:cl:

contains lots of copy paste from vg and para

@ghost ghost requested review from ShizCalev and WJohn as code owners February 18, 2018 14:50
@IconDiffBot
Copy link

IconDiffBot commented Feb 18, 2018

Icons with diff:

icons/mob/screen_gen.dmi
Key Old New Status
health_numb health_numb Created
icons/obj/vehicles.dmi
Key Old New Status
wheelchair[1] wheelchair[1] Created
wheelchair[3] wheelchair[3] Created
wheelchair_overlay[3] wheelchair_overlay[3] Created
wheelchair_overlay wheelchair_overlay Created
wheelchair wheelchair Created
wheelchair[2] wheelchair[2] Created
wheelchair_overlay[1] wheelchair_overlay[1] Created
wheelchair_overlay[2] wheelchair_overlay[2] Created

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Feb 18, 2018
MoreRobustThanYou added 2 commits February 18, 2018 09:53
@Wilchenx
Copy link
Contributor

Wilchenx commented Feb 18, 2018

Nerf bruise packs fixing mortal wounds, same with ointment healing 2nd degree burns. Make synthflesh required to fix them.

@ghost
Copy link
Author

ghost commented Feb 18, 2018

how about just remove them entirely

@Wilchenx
Copy link
Contributor

Make it so you can bandage a wound instead and it will heal, sort of like baymed does it.

if(HEALTH_THRESHOLD_CRIT to HEALTH_THRESHOLD_PRECRIT)
stat = PRE_CRIT
if(HEALTH_THRESHOLD_PRECRIT to HEALTH_THRESHOLD_CRIT)
stat = SOFT_CRIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from A to B = precrit, from B to A = softcrit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops.


var/pain_shock_stage = 0
var/pain_level = 0 //Gets overwritten every tick! If you want to add pain "resistance" or constain pain, see update_pain_level()
var/pain_numb = 0 // When this is set, the mob isn't affected by shock or pain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this a trait

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not a bool, that's like stuttering/slurring/eye_blurry/etc, it gets decreased every tick

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally you want a status effect for that then, but a trait that does this is generally easier and more appropriate when using chems (see pax for example)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pain_level -= R.pain_resistance

if(slurring) //I'm not sure why this is here.
pain_level -= 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then remove it

update_pain_level()

/mob/living/carbon/proc/has_painkillers()
return (reagents.has_reagent("oxycodone") || reagents.has_reagent("tramadol"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snowflake

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snowflake and also typical baycode

@XDTM
Copy link
Contributor

XDTM commented Feb 18, 2018

I really like the idea of implementing pain and can't wait to integrate it with our other systems.

@81Denton
Copy link
Member

I feel like morphine should also reduce pain

@FatCat1978
Copy link
Contributor

I don't think you realize how much of a pain in the ass bones are on baycode. And I don't say this as a TG contributer, just some shitcoder from above the northern border.

Bone repair surgery would work fucking horrible on tg, especially if you can't do it by yourself, as unga bunga boye with toolbox can just fuck you over and make you need surgery after like 2 hits... and I've yet to see a doctor do surgery at all on tg.

Shock is also the worst fucking thing about baymed, and only serves to fuck people over even more, without actually adding much substance to the game.

I don't play TG all that much anymore, but I can assure you that this will end in a shitheap regardless.

@XDTM
Copy link
Contributor

XDTM commented Feb 18, 2018

There's no bone stuff in this PR

@FatCat1978
Copy link
Contributor

experimental: ------------------------
experimental: Spacemen now actually have bones.
experimental: Bone repair surgery is in!

@ghost
Copy link
Author

ghost commented Feb 18, 2018

i haven't pushed it yet, @XDTM

@XDTM
Copy link
Contributor

XDTM commented Feb 18, 2018

oh, i didn't refresh the page and i couldn't see the updated description

@81Denton
Copy link
Member

/tg/ rounds on average have 2 doctors of which neither know how to even spell surgery. Most of the time they can't even use sleepers properly or forget to take hardsuits off before cryo.
Now imagine 10 spessmen with shattered legs waiting for Smoothbrain MD to fix them up. The absolute horror

I'd still like to see this testmerged though, maybe docs might do their job for once?

@ghost
Copy link
Author

ghost commented Feb 18, 2018

Actually, you know what, no bones. Bonecode is hard.

@XDTM
Copy link
Contributor

XDTM commented Feb 18, 2018

It's kind of a vicious cycle, if doctors don't need to know/do anything to do their jobs you won't see many of them, and if you don't doctors you think that there are no doctors for anything complicated.

That said, i'd rather have medical changes one at a time, instead of dumping the whole thing, testmerging it a couple rounds, until it's abandoned because barely anybody knows what to do and everyone complains.

@ghost
Copy link

ghost commented Feb 18, 2018

@Iamgoofball every single one? can you list them

Copy link
Contributor

@Iamgoofball Iamgoofball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall you not understanding how baymed works resulted in you fucking up this baymed port

visible_message("<span class='danger'>[src] clutches at [p_their()] chest as if [p_their()] heart is stopping!</span>", "<span class='userdanger'>It feels as if your heart has stopped!</span>")
stop_sound_channel(CHANNEL_HEARTBEAT)
playsound_local(src, 'sound/effects/singlebeat.ogg', 100, 0)
set_heartattack(TRUE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

players threw a fit in my goonmed port when low blood could result in death why do you think people will like it here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a bit above the instant death threshold anyway? You're already taking massive oxyloss by this point

@@ -666,6 +666,8 @@
//Fire and Brute damage overlay (BSSR)
var/hurtdamage = getBruteLoss() + getFireLoss() + damageoverlaytemp
if(hurtdamage)
if(has_trait(TRAIT_NUMB))
hurtdamage = max((hurtdamage - 20) / 2, 0) //Make the damage appear smaller than it really is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

people threw a fit over miner's salve hiding the damage amount

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what, when? i remember complaints about the instastun, but i don't think hiding damage was ever an issue

@@ -268,6 +268,7 @@
if(resting)
resting = 0
update_canmove()
reagents.add_reagent("paracetamol", 1) //the power of hugs reduces pain!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undocumented and easy to spam change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree it shouldn't use a chem

0.7 * getToxLoss() + \
1.5 * getFireLoss() + \
1.2 * getBruteLoss() + \
1.7 * getCloneLoss()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the absolute fuck is this layout

1.2 * getBruteLoss() + \
1.7 * getCloneLoss()

for(var/datum/reagent/R in reagents.reagent_list)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typelesss lists

@@ -261,7 +261,7 @@
return 1

/mob/living/proc/InCritical()
return (health <= HEALTH_THRESHOLD_CRIT && (stat == SOFT_CRIT || stat == UNCONSCIOUS))
return (health <= HEALTH_THRESHOLD_CRIT && (stat == SOFT_CRIT || stat == UNCONSCIOUS || stat == PRE_CRIT))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean this shit up

"<span class='numb'>You feel a little high of energy, and it makes you smile...</span>", \
"<span class='numb'>You nod to yourself... it's nothing, it just feels good to nod a little...</span>", \
"<span class='numb'>Hello?... Is there anybody in there?...</span>", \
"<span class='numb'>You feel... comfortably numb.</span>"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a list

metabolization_rate = 0.05 * REAGENTS_METABOLISM
color = "#C805DC"
taste_description = "bitterness"
addiction_threshold = 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no actual defined addiction steps

no downsides to this either, I can just ride high on oxy all fucking shift and nullify everything you did here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's supposed to be a warning like "hey dipshit you're getting close to overdose"

name = "Oxycodone"
id = "oxycodone"
results = list("oxycodone" = 3)
required_reagents = list("plasma" = 1, "ethanol" = 1, "tramadol" = 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao shit this is easy to make

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plasma not stable plasma

if(hands <= 0)
return FALSE
movedelay = normal_move_delay * (4 / hands)
vehicle_move(direction)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only good thing in this PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@Iamgoofball
Copy link
Contributor

@Armhulen he clarified in irc he's not banned from ftl apparently

@ghost
Copy link

ghost commented Feb 18, 2018

when did he get banned from hippie

@ghost
Copy link

ghost commented Feb 18, 2018

also wheelchairs don't work right grrrrrrr

@ghost
Copy link

ghost commented Feb 18, 2018

THIS ISN'T CODE >:(

@praisenarsie
Copy link
Contributor

@Armhulen when he fucked up the codebase and/or server like three times

@ghost
Copy link

ghost commented Feb 18, 2018

explain

@ghost
Copy link
Author

ghost commented Feb 18, 2018

salty admin and prick host happened

@Iamgoofball
Copy link
Contributor

i think trying to add *poo didnt help either

@ghost
Copy link

ghost commented Feb 18, 2018

doesn't explain much

@ExcessiveUseOfCobblestone
Copy link
Contributor

@MoreRobustThanYou stop evading shitler

1 similar comment
@praisenarsie
Copy link
Contributor

@MoreRobustThanYou stop evading shitler

@ghost
Copy link

ghost commented Feb 18, 2018

cant be banned from ftl if he hasnt been on there, he wouldnt last for a weekend on ftl

@ghost
Copy link

ghost commented Feb 18, 2018

found him evading today no more testmerges

@praisenarsie
Copy link
Contributor

@Armhulen are you saying this unironically or ironically or "unironically"

@ghost
Copy link

ghost commented Feb 18, 2018

unironically

@ghost
Copy link

ghost commented Feb 18, 2018

embarrassing innit

@ghost
Copy link
Author

ghost commented Feb 18, 2018

seems more ""unironically"" due to radio silence on discord

@ghost
Copy link

ghost commented Feb 18, 2018

🤦‍♀️

@ghost
Copy link
Author

ghost commented Feb 18, 2018

pain mechanics on /tg/ out of all places

why must you do this, everybody knows this is powergame central

@ghost
Copy link

ghost commented Feb 18, 2018

lol rekt

@ghost
Copy link
Author

ghost commented Feb 18, 2018

capture

@ghost
Copy link

ghost commented Feb 18, 2018

he was banned for that very out of place

@Shadowflame909
Copy link
Contributor

DARN YOU MRTY! >MRTY MED BROKE XENOBIO BLOOD REACTIONS. HOW TO TEST OUT. >testmerge morty med, get blood in a syringe. >inject it into any slime extract except for grey. >the slime extract will not do anything. For some reason grey works, but nothing else does with blood. DARN YOU, REEE

@ghost ghost deleted the mortymed branch August 20, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet