[READY]Circuit balance #35931

arsserpentarium · 2018-02-23T19:30:35Z

🆑 Selea
balance:custom ticker
balance:Implement external manipulation cooldown(0.1 s).so you can stack throwers for faster fire.But they can't fire all at once.
balance:ability to beat the crap out from drones with bat on harm intent
balance: reduce CD of all non manipulative non list output circuits to 0.1
balance: add to locomotion circuit output ref with object, which assembly was bumped to.
balance: upgrade disks have multiuse.
balance:iducer efficiency= efficiency/number of inducers on 1 tile.
balance: unnerf fuel cell.about 3-5 times.Make blood more powerful.
/:cl:
Sorry, fast locomotion and powernet interaction not this time probably.

epochayur · 2018-02-23T19:50:31Z

balance: ability to beat the crap out from drones with bat on harm intent

ghost · 2018-02-23T20:12:22Z

iducer efficiency= efficiency/number of inducers on 1 tile.

If I'm right, this would cause any amount of inducers to be equal in power to just one inducer, right? Since 3 inducers would have a power transmission rate of 0.33 of the normal, it'd equal out to just one. I feel like this is a strange way of doing it, especially since there's no indicator in description or otherwise about how it works.

One idea would be to limit the amount of transmission circuits possible in one assembly to the assembly's weight class minus one (so small = 1 inducers, normal = 2 inducers, bulky = 3; should be easy to check with just w_class - 1) so that they can still be used effectively without nerfing them into uselessness. Or maybe give them a shared cooldown? I'm not really sure.

arsserpentarium · 2018-02-23T20:18:20Z

@Xhuis Inducer is very far from being useless. I've never used more than one in one assembly.They have huge transmission rate. Barely you able to overfeed one inducer without stack of fuel cells.
But stack them on one tile now not veru useful.But I can change loss formula if you will suggest good alternative.

evsey9 · 2018-02-23T21:35:27Z

fun removal

arsserpentarium · 2018-02-23T21:38:48Z

@evsey9 oh, come on!Why you calls fast brains fun removal?
also, you still can make holy shit how robust throwerdrone.it is still 10 hatchets/sec.Just in queue.

evsey9 · 2018-02-23T22:03:40Z

nah i was just kidding, the CD decrease on other things is pretty neat

silicons · 2018-02-24T00:02:33Z

cd limit on throwing shouldnt' be taht low why should a bot be able to throw 10 things a second when everything is balanced around attack delays and why can it throw itself with the same module?
should be 0.3 atleast.

arsserpentarium · 2018-02-24T01:05:32Z

@kevinz000 You should count it like assembly cooldown.You mean , that assembly should't move or 0.3 sec at least after throw.I implemented it to avoid both instant locomotion and throwing.But to avoid instant actions.It haven't more goals.

silicons · 2018-02-24T01:37:32Z

more concerned with throwing being too rapid due to it allowing instant kills.

arsserpentarium · 2018-02-24T01:38:59Z

Well,now it isn't instant.

evsey9 · 2018-02-24T12:31:28Z

@kevinz000 you can make your own PR after that to do that if you want to, this at least makes it somewhat better

arsserpentarium · 2018-02-24T15:30:09Z

But you shouldn't, because external cooldown mechanic is works good mostly to prevent instant actions. But will be to clunky to use with different cooldowns.I've tryed.

JStheguy · 2018-02-25T00:23:48Z

balance: reduce CD of all non manipulative non list output circuits to 0.1

did i die and go to space heaven

arsserpentarium · 2018-02-25T02:11:39Z

@JStheguy even if so, you'll be cloned soon.

…tgstation into circuit_balance

vuonojenmustaturska · 2018-02-27T19:06:52Z

code/__HELPERS/unsorted.dm

@@ -527,7 +527,8 @@ Turf and target are separate in case you want to teleport some distance from a t
 		//Byond does not allow things to be in multiple contents, or double parent-child hierarchies, so only += is needed
 		//This is also why we don't need to check against assembled as we go along
 		processing_list += A.contents
-		assembled += A
+		if(!T || istype(A,T))


This is a fairly performance-sensitive proc so I recommend making a different version like GetAllContentsOfType or something, alternatively put your if before the while and have a different loop based on whether you're looking for specific types only or not.

AnturK · 2018-02-27T19:17:44Z

code/modules/integrated_electronics/passive/power.dm


 /obj/item/integrated_circuit/passive/power/chemical_cell/New()
 	..()
 	create_reagents(volume)
+	var/p = text2path("/datum/config_entry/flag/disable_human_mood")


What are you trying to do here ? Why is this path a string and why are you not using the common config helpers?

Because there is no such flag in game yet.So it is error safe version of flag check.

vuonojenmustaturska · 2018-03-02T22:37:48Z

code/modules/integrated_electronics/subtypes/time.dm

+/obj/item/integrated_circuit/time/ticker/custom/on_data_written()
+	var/delay_input = get_pin_data(IC_INPUT, 2)
+	if(delay_input && isnum(delay_input) )
+		var/new_delay = CLAMP(delay_input ,1 ,36000) //An hour.


Like the delay above, you can write this as var/new_delay = CLAMP(delay_input ,1 ,1 HOURS) to be explicit and skip the comment

* cooldowns, power cell,disks * NUMBERS NUMBERS NUMBERS * 1 8 9 * PR PR PR * DESC DESCDSCDCC * <br> * GET ALL CONTENTS * Update power.dm * Update power.dm * Update time.dm

arsserpentarium added 4 commits February 20, 2018 10:19

cooldowns, power cell,disks

ded7b21

NUMBERS NUMBERS NUMBERS

9a3b665

1 8 9

f4ac22d

PR PR PR

e0306df

tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways Tweak labels Feb 23, 2018

DESC DESCDSCDCC

d85acaf

arsserpentarium changed the title ~~Circuit balance~~ [READY]Circuit balance Feb 26, 2018

tgstation-server added Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts Needs Review labels Feb 26, 2018

Merge branch 'master' into circuit_balance

ed0bf90

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Feb 26, 2018

optimumtact removed Feature Exposes new bugs in interesting ways Tweak labels Feb 26, 2018

<br>

9b788bc

Merge branch 'circuit_balance' of https://github.com/arsserpentarium/…

6a9b7c0

…tgstation into circuit_balance

vuonojenmustaturska suggested changes Feb 27, 2018

View reviewed changes

tgstation-server removed the Needs Review label Feb 27, 2018

AnturK requested changes Feb 27, 2018

View reviewed changes

GET ALL CONTENTS

97177bf

tgstation-server added the Needs Review label Feb 28, 2018

arsserpentarium added 2 commits March 2, 2018 10:35

Update power.dm

23ff52b

Update power.dm

8f408d0

vuonojenmustaturska reviewed Mar 2, 2018

View reviewed changes

Update time.dm

a2eb4d8

vuonojenmustaturska merged commit 09051dd into tgstation:master Mar 2, 2018

ghost mentioned this pull request Mar 2, 2018

[MIRROR] Circuit balance HippieStation/HippieStationdeprecated2020#6903

Merged

tgstation-server added a commit that referenced this pull request Mar 2, 2018

Automatic changelog generation for PR #35931 [ci skip]

e582cd0

CitadelStationBot mentioned this pull request Mar 2, 2018

[MIRROR] [READY]Circuit balance Citadel-Station-13/Citadel-Station-13#5760

Merged

vuonojenmustaturska mentioned this pull request Mar 3, 2018

Circuit assemblies can't be broken via weapons #32904

Closed

arsserpentarium deleted the circuit_balance branch March 3, 2018 00:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[READY]Circuit balance #35931

[READY]Circuit balance #35931

arsserpentarium commented Feb 23, 2018 •

edited

epochayur commented Feb 23, 2018

ghost commented Feb 23, 2018 •

edited by ghost

arsserpentarium commented Feb 23, 2018 •

edited

evsey9 commented Feb 23, 2018

arsserpentarium commented Feb 23, 2018

evsey9 commented Feb 23, 2018

silicons commented Feb 24, 2018 •

edited

arsserpentarium commented Feb 24, 2018

silicons commented Feb 24, 2018

arsserpentarium commented Feb 24, 2018

evsey9 commented Feb 24, 2018

arsserpentarium commented Feb 24, 2018

JStheguy commented Feb 25, 2018 •

edited

arsserpentarium commented Feb 25, 2018

vuonojenmustaturska Feb 27, 2018

arsserpentarium Feb 28, 2018

AnturK Feb 27, 2018 •

edited

arsserpentarium Feb 28, 2018 •

edited

vuonojenmustaturska Mar 2, 2018

[READY]Circuit balance #35931

[READY]Circuit balance #35931

Conversation

arsserpentarium commented Feb 23, 2018 • edited

epochayur commented Feb 23, 2018

ghost commented Feb 23, 2018 • edited by ghost

arsserpentarium commented Feb 23, 2018 • edited

evsey9 commented Feb 23, 2018

arsserpentarium commented Feb 23, 2018

evsey9 commented Feb 23, 2018

silicons commented Feb 24, 2018 • edited

arsserpentarium commented Feb 24, 2018

silicons commented Feb 24, 2018

arsserpentarium commented Feb 24, 2018

evsey9 commented Feb 24, 2018

arsserpentarium commented Feb 24, 2018

JStheguy commented Feb 25, 2018 • edited

arsserpentarium commented Feb 25, 2018

vuonojenmustaturska Feb 27, 2018

Choose a reason for hiding this comment

arsserpentarium Feb 28, 2018

Choose a reason for hiding this comment

AnturK Feb 27, 2018 • edited

Choose a reason for hiding this comment

arsserpentarium Feb 28, 2018 • edited

Choose a reason for hiding this comment

vuonojenmustaturska Mar 2, 2018

Choose a reason for hiding this comment

arsserpentarium commented Feb 23, 2018 •

edited

ghost commented Feb 23, 2018 •

edited by ghost

arsserpentarium commented Feb 23, 2018 •

edited

silicons commented Feb 24, 2018 •

edited

JStheguy commented Feb 25, 2018 •

edited

AnturK Feb 27, 2018 •

edited

arsserpentarium Feb 28, 2018 •

edited