Adds the Family Heirloom, Nyctophobia, and Monochromacy traits, and rebalances Social Anxiety #36426

ghost · 2018-03-14T23:18:26Z

🆑 Xhuis
add: Added the Family Heirloom trait. This makes you spawn with a special object on your person; if you don't have it with you, you will gain a mood debuff.
add: Added the Nyctophobia trait. This makes you walk slowly in complete darkness, and gain a mood debuff from the fear!
add: Added the Monochromacy trait, which makes you perceive (almost) the entire world in black-and-white.
balance: Social Anxiety's trigger frequency is now correlated to the number of people near you.
/:cl:

Thanks to PKP for the Nyctophobia and Monochromacy ideas. Thanks to Polyphynx on the forums for the input about Social Anxiety.

Picture of Monochromacy:

I'm not sure why lights are still perceived in color, which is why I included the "almost" bit.

Family Heirloom (minor neg.): You spawn with an item in your backpack and gain a mood debuff if you don't have it on your person, and a small boost when you do. This can be a d20, deck of cards, crowbar, or Zippo lighter by default. The object itself is named "(last name) family (normal name)" to distinguish it. The object spawned also varies based on job:
- Clowns get a golden bike horn
- Mimes get a baguette
- Lawyers get a gavel
- Janitors get a mop
- Security Officers get a space law book
- Scientists get a slime plushie
- Assistants get a rusty toolbox that starts empty, does low damage, and fits in backpacks
- On April Fools' Day, the heirloom can be any item in the game, using the same limitation code as the Christmas gifts (only valid items, so non-abstract and has an icon)
Nyctophobia (minor neg.): You can't run in complete darkness, and are forced to walk instead. You also gain a small mood debuff from fear. Combine with Night Vision for the ultimate meta.
Monochromacy (neutral): You can't see colors. The entire world (except for light) is black-and-white to you.

I also reordered the Jolly, Depression, and Apathetic traits to be alphabetical in the menu because it pleases my autism. Social Anxiety was rebalanced so that you didn't randomly go mute for no reason, and because it makes more sense to get anxious when talking to a group of people than at random. Thoughts and input are welcome.

ghost · 2018-03-14T23:20:06Z

add: Added the Family Heirloom trait. This makes you spawn with a special object on your person; if you don't have it with you, you will gain a mood debuff.

AAAAA I LOVE YOUUU

optimumtact · 2018-03-14T23:20:34Z

it's because the lights are on the wrong layer, which is why they don't spin when you rotate the players HUDs either

edit:wrong plane probably, but it might be for lighting reasons, cna't remember

ghost · 2018-03-14T23:22:13Z

code/datums/traits/good.dm

@@ -11,6 +11,23 @@



+/datum/trait/apathetic


undocumented change (not that i mind the change beind made)

I also reordered the Jolly, Depression, and Apathetic traits to be alphabetical in the menu because it pleases my autism.

xenon-difluoride · 2018-03-14T23:22:30Z

On April Fools' Day, the heirloom can be any item in the game, using the same limitation code as the Christmas gifts (only valid items, so non-abstract and has an icon)

Hell yes.

ghost · 2018-03-14T23:23:50Z

code/datums/traits/negative.dm

+/datum/trait/family_heirloom
+	name = "Family Heirloom"
+	desc = "You are the current owner of an heirloom. passed down for generations. You have to keep it safe!"
+	value = -1


Minus points for what is essentialy free mood unless you suck?

You have to clutter your inventory to lug around a random object that, in likelihood, won't have any use.

just have it be 0 value to be safe

I view the concept as inherently negative, so I might end up removing the mood boost instead.

it has a passive buff, but I suppose its fair for the 1 mood boost and it means this is an attractive negative trait pick, which I like. So fine with me :D

@Xhuis also dont remove the mood boost just keep it like this tbf

silicons · 2018-03-14T23:24:29Z

monochromacy

Time for detecting!

XDTM · 2018-03-14T23:34:59Z

Can you make trauma versions of monochromacy and nyctophobia? They're pretty cool

Tacolizard · 2018-03-14T23:35:09Z

monochromacy should give 1 point, because you can't see hacked APCs, some syndie gear, etc

ghost · 2018-03-14T23:43:21Z

Playing monochromatically significantly affects perception, but not gameplay; someone who plays with monochromacy will be able to catch onto the tints of objects and be able to distinguish them from normal ones at a glance, much like monochromatic patients do in real life. I don't think it detracts enough from gameplay to be worth a point, but I'll have to consider it.

Hatterhat · 2018-03-14T23:45:08Z

the official meta of monochromacy is

play det
activate monochromacy
play the Gunpoint OST

case in point:
https://www.youtube.com/watch?v=AASeTbHFvSQ
https://www.youtube.com/watch?v=6LZ12RGcU1U

PKPenguin321 · 2018-03-15T00:02:58Z

>tfw you post your idea on the forums and some madman actually codes it

feels good, thanks

optimumtact · 2018-03-15T00:04:26Z

a detective with the monochromatic should spawn with the original revolver that fires real bullets in honour of their awesomeness

Tacolizard · 2018-03-15T00:05:59Z

det bullets are better than real bullets because they stun

optimumtact · 2018-03-15T00:06:45Z

the original revolver would crit you in two shots taco you newfag

Tacolizard · 2018-03-15T00:07:16Z

ree

ghost · 2018-03-15T00:10:37Z

detectives with monochrome do get a special sound and message cue, so they don't go entirely unacknowledged

cebutris · 2018-03-15T02:03:52Z

Loss of color doesn't seem like a huge deal at first, but it's a pretty significant drawback. I wouldn't go so far as to say that it's a major setback, but it's certainly not something to be written off.

Try playing a round as security with SecHUDs and glasses color enabled (alt-click the glasses), you'll see what I mean

81Denton · 2018-03-15T08:17:50Z

Monochromacy is going to be fun as an atmos tech lmao

Jalleo

Just some comments you can take them aboard or throw them out (Messaged from my mobile sorry for spelling errors)

Jalleo · 2018-03-15T09:30:04Z

code/datums/traits/negative.dm

+				heirloom_type = /obj/item/storage/toolbox/mechanical/old/heirloom
+	if(!heirloom_type)
+		heirloom_type = pick(
+		/obj/item/toy/cards/deck,


Can I suggesy it be basically anything from the arcade machine?

McUrist family pulse rifle

Jalleo · 2018-03-15T09:31:21Z

code/datums/traits/negative.dm

+
+
+
+/datum/trait/family_heirloom


What we then need next is a possibility for antags to buy a steal heirloom trait which can give them a positive buff.

imtakingabreakdontatme · 2018-03-15T15:27:18Z

Traits and moods are both config options. What happens to traits based around mood if moods are toggled off? Do they become freebies?

ghost · 2018-03-15T16:15:52Z

Mhm, they do. It'd be very easy to add a way to disable them from appearing in the menu if moods are disabled. I can see about doing that after this PR is in, or in the PR itself if wanted.

epochayur · 2018-03-15T17:43:56Z

that monochromacy is seriously cool, you're doing god's work xhuis

ghost · 2018-03-15T17:52:53Z

@KorPhaeron ofcourse nobody would disable mood right?

Iamgoofball · 2018-03-16T18:23:38Z

@KorPhaeron The solution is we remove the config options and make them default, and stop being cowards about a vocal minority quitting for hippie just because we made a game design decision

ghost · 2018-03-18T19:20:26Z

code/datums/traits/negative.dm

+	if(mood)
+		if(heirloom in trait_holder.GetAllContents())
+			mood.clear_event("family_heirloom_missing")
+			mood.add_event("family_heirloom", /datum/mood_event/family_heirloom)


Use the send signals instead (changed due to my pr)

ghost · 2018-03-19T07:09:16Z

Sorry about not working on this lately, other stuff has come up + haven't had time to work on it. I haven't forgotten about this, so I'll get some work done when I'm able.

ShizCalev · 2018-03-20T00:12:54Z

conflict

imtakingabreakdontatme · 2018-03-20T00:14:09Z

@Iamgoofball @Xhuis

Maybe eventually yeah, but until then you need to make sure it works with whichever config settings a server is using

drawsstuff · 2018-03-20T12:50:09Z

If you're adding monochrome for the detective, at least do it the way para did and make things such as discarded bullets and blood still colored.

here's a shitty mock up

ghost · 2018-03-20T17:35:12Z

@drawsstuff A neat idea, but my prodding couldn't figure out any immediate ways to do it, so if I do it I'll wait till after this PR.

Xhuis added 2 commits March 14, 2018 19:03

Adds some more traits

5fa4a11

April Fools' heirlooms

8a1e00d

tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways labels Mar 14, 2018

ghost reviewed Mar 14, 2018

View reviewed changes

Fixes the detective sound

8882026

Jalleo reviewed Mar 15, 2018

View reviewed changes

ghost suggested changes Mar 18, 2018

View reviewed changes

ShizCalev added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Mar 20, 2018

Merge branch 'master' into new_traits

faaa240

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Mar 20, 2018

Refactor to use signals

21e5fdf

vuonojenmustaturska merged commit bd42041 into tgstation:master Mar 28, 2018

ghost mentioned this pull request Mar 28, 2018

[MIRROR] Adds the Family Heirloom, Nyctophobia, and Monochromacy traits, and rebalances Social Anxiety HippieStation/HippieStationdeprecated2020#7322

Merged

tgstation-server added a commit that referenced this pull request Mar 28, 2018

Automatic changelog generation for PR #36426 [ci skip]

42ec761

yogstation13-bot mentioned this pull request Mar 28, 2018

[MIRROR] Adds the Family Heirloom, Nyctophobia, and Monochromacy traits, and rebalances Social Anxiety yogstation13/Yogstation#183

Merged

CitadelStationBot mentioned this pull request Mar 28, 2018

[MIRROR] Adds the Family Heirloom, Nyctophobia, and Monochromacy traits, and rebalances Social Anxiety Citadel-Station-13/Citadel-Station-13#6135

Merged

ghost deleted the new_traits branch March 28, 2018 19:36

ghost mentioned this pull request Jul 30, 2021

Monochromacy is now a 2 points negative quirk. #60568

Closed




		/datum/trait/family_heirloom

Adds the Family Heirloom, Nyctophobia, and Monochromacy traits, and rebalances Social Anxiety #36426

Adds the Family Heirloom, Nyctophobia, and Monochromacy traits, and rebalances Social Anxiety #36426

Conversation

ghost commented Mar 14, 2018 • edited by ghost

ghost commented Mar 14, 2018

optimumtact commented Mar 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xenon-difluoride commented Mar 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

silicons commented Mar 14, 2018

XDTM commented Mar 14, 2018

Tacolizard commented Mar 14, 2018 • edited

ghost commented Mar 14, 2018

Hatterhat commented Mar 14, 2018

PKPenguin321 commented Mar 15, 2018

optimumtact commented Mar 15, 2018

Tacolizard commented Mar 15, 2018

optimumtact commented Mar 15, 2018

Tacolizard commented Mar 15, 2018

ghost commented Mar 15, 2018

cebutris commented Mar 15, 2018

81Denton commented Mar 15, 2018

Jalleo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imtakingabreakdontatme commented Mar 15, 2018

ghost commented Mar 15, 2018

epochayur commented Mar 15, 2018

ghost commented Mar 15, 2018 • edited by optimumtact

Iamgoofball commented Mar 16, 2018 • edited

Choose a reason for hiding this comment

ghost commented Mar 19, 2018

ShizCalev commented Mar 20, 2018

imtakingabreakdontatme commented Mar 20, 2018

drawsstuff commented Mar 20, 2018

ghost commented Mar 20, 2018

ghost commented Mar 14, 2018 •

edited by ghost

optimumtact commented Mar 14, 2018 •

edited

Tacolizard commented Mar 14, 2018 •

edited

ghost commented Mar 15, 2018 •

edited by optimumtact

Iamgoofball commented Mar 16, 2018 •

edited