Removes Roundstart Active Turfs #36756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Removal
duncathan
added
Performance
|
Ok so far so good... except I figured out that the Ash Lizard ruin produces active turfs by default... gonna have to squeeze a mapedit into this. |
|
Maps with diff: _maps/RandomRuins/LavaRuins/lavaland_surface_ash_walker1.dmm
_maps/RandomRuins/LavaRuins/lavaland_surface_swarmer_crash.dmm
Full job logs available here Please report any issues here. |
|
Looks like whoever did the swarner ruin already followed my advice in the OP and used a noop area. Unfortunately unless I figure out how to get rid of the air differential, I won't be able to stomp out ATs completely. |
AnturK
previously requested changes
Mar 29, 2018
| @@ -211,6 +209,9 @@ | |||
| if(istype(tunnel)) | |||
| // Small chance to have forks in our tunnel; otherwise dig our tunnel. | |||
| if(i > 3 && prob(20)) | |||
| if(!tunnel || isspaceturf(tunnel) || istype(tunnel.loc, /area/mine/explored) || (istype(tunnel.loc, /area/lavaland/surface/outdoors) && !istype(tunnel.loc, /area/lavaland/surface/outdoors/unexplored))) | |||
There was a problem hiding this comment.
First two check on tunnel here are redundant you're doing it above anyway.
|
You look at mapdiffbot and sigh |
|
@MapDiffBot |
Cyberboss
approved these changes
Apr 6, 2018
ghost
referenced
this pull request
in HippieStation/HippieStationdeprecated2020
Apr 6, 2018
* River AT fix * Roundstart AT fix * simpler * Wait simpler is bad * Webediting * more weebediting * Remove ashwalker active turfs * Swarmer Crash has lavaland atmos * Removed redundant checks
ghost
mentioned this pull request
Gwolfski
pushed a commit
to Gwolfski/tgstation
that referenced
this pull request
Apr 18, 2018
* River AT fix * Roundstart AT fix * simpler * Wait simpler is bad * Webediting * more weebediting * Remove ashwalker active turfs * Swarmer Crash has lavaland atmos * Removed redundant checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got sick of MSO telling me to HEY LISTEN
The side effect is that lava/tunnels are less likely to directly "touch" certain ruins that have a lot of mineral walls around them but don't use an "unexplored" area type.
If your lava ruin is surrounded by an "explored" Lava area, you can address this by replacing that area with a no-op area where appropriate.
Currently at 10 rounds with no roundstart AT but finding these things is down to luck now.