Adds the Cat and Dog Person traits

[ghost]

🆑 Xhuis
add: You can now be a cat person or a dog person in Space Station 13!
/:cl:

Thaw PR: #36663

You know how you ask someone their favorite kind of pets, and they might say something like "oh, I'm a cat person?" Now you can be one. These two new neutral traits give you preference to dogs or cats, meaning you gain a slightly higher mood increase from petting your preferred one and slightly lower mood increase from petting the inferior other one. So, if you're a dog person, you get +5 to mood from petting a corgi and +1 from petting a cat, instead of +3 from either like normal.

Having both traits will cancel each other out. Also changed the pet_corgi association for moodlets gained by petting animals to wuv since there's now a mood increase from petting cats, too.

[JJRcop]

This should have some interaction with cat mutant parts.

[imtakingabreakdontatme]

You need to fix moodlet traits being available when moodlets are not before you add more of them

[Anonmare]

Lucky for you I'm a dog lover

[ghost]

@KorPhaeron I've been intending to make an "is_available" system for traits, but I'm not sure how to implement them since in its current state the objects aren't created, just read from their initial vars. Would it be cleaner to use those initial vars like incompatible_with and moodlet_trait, or to have a separate datum for the purchase entry that has an is_available() proc that can be overriden?

[nicbn]

In other words free mood by petting mobs

[ghost]

Mood boosts from petting corgis has been around since moodlets were first added.

[ma44]

What if you were a dog lover but a cat person.

-50 mood from identity crisis

[ghost]

Having both traits cancels each other out and makes no change to either mood bonus from its normal value.

[ExcessiveUseOfCobblestone]

@Xhuis replace mood with braindamage when mood is disabled, problem solved :^)

[ghost]

I made mood traits be unavailable for purchase if moodlets are disabled, plus a failsafe that removes them from your setup if they're disabled but you added them before they were turned off.

Also some more tweaks to Social Anxiety, the eternal conundrum. I'd like to atomize this PR a bit, but since the freeze is currently going on and I can only make one thaw PR, I've bundled them up here.

[ExcessiveUseOfCobblestone]

why would you tie the fix to a feature pr you hecker

[ghost]

I can only make one thaw PR during the freeze and the bundle of features here is what I'd wanted to add once it ended. Unless any maintainers have a notable problem with it and want me to slice off the Social Anxiety portion, the other two are fine in the same PR, I think.

[ExcessiveUseOfCobblestone]

sorry my last post was meant to be lighthearted banter but text is hard.

[ghost]

I'll stab my light knife through your heart

[ExcessiveUseOfCobblestone]

watch it buddy i'll take your heirloom.

[ghost]

i read this and thought moodlets were disabled for a second because there isn't an if between "traits" and "moodlets"

[ghost]

Oops.

[ninjanomnom]

Please atomize this pr

[ghost]

As I already mentioned, the feature freeze prevents me from atomizing all of it. If I wanted to add the Cat and Dog Person traits in another PR, I'd have to add the framework separately in a different PR since the thaw only covers one PR.

I can remove the social anxiety tweaks if that's your main concern, though. Otherwise, I'm not sure the best way to handle it.

[ninjanomnom]

I primarily meant splitting up the code disabling traits, the anxiety changes, and the [animal] person traits. You can include the framework for whatever changes you need in those.

[ghost]

It seems like the best idea would be to set this PR to the original scope (adding the two traits), and then once that's in, I can add the restriction as it wouldn't conflict with the freeze. The social anxiety changes can wait.

[ghost]

There we go, quick and clean.

[ExcessiveUseOfCobblestone]

You've already secured the spot in the thaw, make the fix then fix conflicts in here post.

[ninjanomnom]

Kor requested the traits get their fix before more features are merged so this'll have to wait until that gets merged.

Or at least approved

[ghost]

I'll make a second PR that includes the framework/fix standalone, and once that gets in I can update this one.

[optimumtact]

uhm this is all backwards.

Send only a signal that a cat has been petted.

then let the thing that processes the signal figure out what trait the person has.

You're leaking the systems abstractions

[ghost]

Unless I misunderstand moodlet code, wouldn't that require me to check every moodlet event to see if it's a certain type, and if so, if the traits were present?

[ExcessiveUseOfCobblestone]

Currently, yes. You will have to edit moodlet code to allow for some moodlets to receive nonstandard signals.

[optimumtact]

@Qustinnus didn't I make you do this for something else, how did you implement it?

[ghost]

I think my case was unique because everyone gets the same moodlet (table) except I modified it after if you are a catperson. Ill look into a different way of approaching this

[ghost]

I don't have any more desire to work on this or wait for more days hoping Qustinnus will respond so I'm gonna close this

[ghost]

Oh im sorry I havnt been on github for a while due to personal issues and uni keeping me busy. Ill look into it now