Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s] Hallucinations 4.0 #37423

Merged
merged 10 commits into from May 9, 2018
Merged

[s] Hallucinations 4.0 #37423

merged 10 commits into from May 9, 2018

Conversation

XDTM
Copy link
Contributor

@XDTM XDTM commented Apr 25, 2018

No ingame changelog cause these are supposed to fool people.

Changes:

  • Hallucinations now pick from a single weighted list, instead of being separated in tiers. The more obvious a hallucinations, the less likely it is to appear.
  • Hallucination is now a contantly ticking down variable. 1 hallucination = 2 seconds duration. Hallucinating effects have been rebalanced to fit this.
  • Hallucinations have a random cooldown ranging from 10 to 60 seconds. The status will still tick down in the meantime.
  • The Sounds hallucinations has been split in three: realistic sounds (likely), weird sounds (rare), and station messages (i.e. the shuttle arrived, blob warning, etc.)(also rare).
  • The Bolts hallucination now stops you from bumping doors open. You can still click them to open them.
  • Removed the singulo hallucination. It's pretty much impossible to make it realistic enough, and it's too widely known to scare someone. It's an annoyance and a definite tell that you're hallucinating.
  • Removed the xeno attack for the same reasons. It was kept in the code to serve as a pseudotemplate for hallucination mobs.
  • Removed the fake attacker hallucination. Trying to replicate full attack and defense code as well as managing icon generation with blacklists and all is just not worth it. It would never be realistic enough.
  • RDS hallucinations have been either rolled into normal ones or removed (the OOC ones). No reason to keep them separate, aside from throwing off the hallucination odds (which has resulted in complaints about the cult victory warning being too common).
  • Added/edited a lot of strings for the text-based hallucinations. I could definitely use a few more for the message hallucination, i got writer's block there.

@demonfiren
Copy link

removed fake attacker
than fuck that was never not annoying as fuck

@Mickyan
Copy link
Contributor

Mickyan commented Apr 25, 2018

I could never stand the ooc hallucinations in RDS so I might actually use it now

You know perhaps for mob hallucinations it would be interesting if they could be controlled by ghosted players, assuming that's even possible

@Barhandar
Copy link
Contributor

Barhandar commented Apr 25, 2018

Do they need to be realistic? Also, I kinda doubt that players won't recognize they're hallucinating anyway, so I don't consider "a definite tell that you're hallucinating" to be valid.

@sawrge
Copy link

sawrge commented Apr 25, 2018

I'll give this a closer look and post my thoughts later today but for now it mostly looks good, thanks for listening to feedback 👍

@XDTM
Copy link
Contributor Author

XDTM commented Apr 25, 2018

@Barhandar hallucinations will never be believed 100% of the time, but my goal is to increase the amount of times it fools people into acting in interesting ways, while reducing the amount of times hallucinations annoy people.

More "oh shit i killed the AI because someone on the radio saw a blue APC and it was actually a hallucination", less "i just got randomly stunned".

@arsserpentarium
Copy link
Contributor

I think, that hallucinations may be different from different drugs/causes.
So don't delete singulo/fake attacker. And leave it for case of extreme hallucinations. Like being too high on spess drugs.

@Shadowflame909
Copy link
Contributor

You fool. If you make hallucinations realistic you're gonna trick people into getting banned for killing the ai over a hallucination. "Why did you do that." "I saw this incredibly realistic hallucination where the apc turned blue. The doors bolted and shocked me." "Being insane is never an argument." You have been permanently banned. Talk to the coders to Nerf hallucinations.

@GuppyLaxx
Copy link
Contributor

I liked the OOC hallucinations. In the sense of the concept, how they were put in was atrocious. If you want some ideas for that, fake bwoinks and the like. If you feel like adding another rare hallucination, shuttle being called with some small random reasons like "shits fucked" would work. Also fucking, there's a hacking hallucination sound that's really obvious due to the use of the old hacking sounds.

I'm still not 100% straight on how this is gonna affect RDS, but out of that it seems to be fine, aslong as I'm not having my chat spammed by NAR SIE HAS RISEN, constantly being on fire, and getting shocked, it's good

@XDTM
Copy link
Contributor Author

XDTM commented Apr 25, 2018

@GuppyLaxx OOC is not ok because stuff like an admin contacting you should not be confused for an ingame mechanic, ever.

RDS will now just be intermittent hallucinations, and those should be less frequent and obnoxious.

I thought about the shuttle call hallucination, but unless i add a really wide list of motivations it's gonna be easy to detect as a hallucination.

About the hacking hallucination, i removed the clicking sounds inbetween. Maybe i should play the game once in a while.

@XDTM
Copy link
Contributor Author

XDTM commented Apr 25, 2018

@Shadowflame909 jokes aside there is fairly precise logging for hallucinations, so you can verify is the player has been fooled or is trying to fool you

@Shadowflame909
Copy link
Contributor

Oh, nevermind then. Let the hallucinations continue to get realistic!

@newfren
Copy link
Contributor

newfren commented Apr 26, 2018

Most of the sound hallucinations are quite obvious because they make the noise with no bearing on direction - is it possible for them to update with a random directional influence? Then they might actually sound like, e.g., someone's lasering someone to death in maint near you instead of inside your own brain.

@XDTM
Copy link
Contributor Author

XDTM commented Apr 26, 2018

Yeah, i guess i can pick a random tile. Do we actually have directional sound and i never noticed?

@newfren
Copy link
Contributor

newfren commented Apr 26, 2018

We definitely have directional sound, yes.

@YakumoChen
Copy link
Contributor

can you change the fire hallucination so you can actually put it out? The stamina damage is really annoying and an obvious tell.

@XDTM
Copy link
Contributor Author

XDTM commented Apr 27, 2018

Already did! I forgot to put that in the change list.

@XDTM
Copy link
Contributor Author

XDTM commented Apr 28, 2018

In this commit:

  • Sounds now have a localized, random source instead of being centered on the victim. Definitely more realistic.
  • The Items-Other hallucination now properly picks a random tartget instead of the first available.
  • Made a Shock hallucination. Now the door shock uses the hallucination instead of local code. Fixed the black outline not falling down with you.
  • Reworked the dangerflash hallucination; now creates interactive hallucination effects. Currently: Lava (sets you of fake fire), Chasm ("drops" you), Electric Anomaly (shocks you). Open to more ideas.
  • Whispers' speech is now always capitalized.

@XDTM
Copy link
Contributor Author

XDTM commented Apr 28, 2018

I want to replace husks with a hallucination that shows creepy or weird stuff/shapes in the distance. If anyone has some sprites that could fit that purpose i'd love to add them

@ghost
Copy link

ghost commented Apr 28, 2018

not a fan of the rds removal, the point of the hallucinations was to make the trait unique in a way that wasn't just "occasional hallucinations" and why the trait was made so wordy and strangely-named to begin with. if you want to remove the only thing that makes it unique, rename the trait, and if it bothers you that badly then reduce the odds.

@XDTM
Copy link
Contributor Author

XDTM commented Apr 28, 2018

The hallucinations it had were of the same category of existing hallucinations (i.e narsie rising is pretty much the same as the AI delta alert). Those that weren't were instead OOC-based (i.e. the big messages saying to leave the server or close the game window) which, last i've heard, are a no-no, aside from being really obvious after the first time.

I would've kept special hallucinations if they were actually special and not just kept apart for the sake of it.

@ghost
Copy link

ghost commented Apr 28, 2018

The 4th-wall breaking traits have never been brought up as problematic until this PR when you cut them. There's ultimately nothing I can do to keep it as-is, but part of the reason why RDS is named so uniquely and has such a wordy description and disclaimer is because you see and hear things with RDS that you don't see with anything else. I'll insist again that if you remove the unique traits that you should make it more subtle in naming or description.

@ShizCalev ShizCalev added the Feature Exposes new bugs in interesting ways label Apr 29, 2018
@ExcessiveUseOfCobblestone
Copy link
Contributor

Regardless of if it's never been brought up or not, having immersion breaking hallucinations is not cool outside of ooc situations, and even then would probably be frustrating.

set waitfor = FALSE
..()
var/hits = rand(3,6)
var/list/turf/sourcelocs = list()
for(var/turf/open/T in range(world.view+1,target)-range(world.view-2,target))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're just picking one random offset is better than iterating all these (twice). Could probably pick from off-view locations only alternatively.

@improvedname
Copy link
Contributor

New brain tumor fake attackee you get a fake that attacts you 24/7

@improvedname
Copy link
Contributor

Also keep shuttle hallicination which makes a fake shuttle appear so you walk into it but instead your spacing yourself

@XDTM
Copy link
Contributor Author

XDTM commented May 8, 2018

@AnturK should be fine now

@AnturK AnturK changed the title Hallucinations 4.0 [s] Hallucinations 4.0 May 9, 2018
@optimumtact optimumtact merged commit aa782ff into tgstation:master May 9, 2018
@ShizCalev ShizCalev added this to the Cult milestone Jun 10, 2018
@XDTM XDTM deleted the Hallucinations4.0 branch September 11, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet