Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'State Laws' verb for Cyborgs #399

Merged
merged 3 commits into from
Apr 20, 2013
Merged

'State Laws' verb for Cyborgs #399

merged 3 commits into from
Apr 20, 2013

Conversation

AndroidSFV
Copy link

  • AI's State Laws verb copy-pasted for Cyborgs.

@Petethegoat
Copy link
Contributor

Consider moving the statelaws() proc up to mob/living/silicon, rather than having it define separately for AIs and cyborgs.

@AndroidSFV
Copy link
Author

Well there is the issue of pAIs having it then, too

@MrPerson
Copy link
Contributor

Frankly pAI's having them is ok, assuming it's cased to stating their directives and whatnot.

@AndroidSFV
Copy link
Author

Another issue I thought of is that the verb would show up exclusively in a tab called "AI Commands" or "Robot Commands" depending on choice made in the code. This would result in either the AI or cyborgs having a tab with just 1 verb in it, which is kinda dumb.

The best alternative I can think of to that is restructuring all of /mob/living/silicon/ into having one unified verb tab, 'Silicon Commands.'

@caelaislinn
Copy link
Contributor

You won't be able to directly merge these changes with another repo (that's not in sync with tg), but you can forcibly make these changes overwrite that other repos files (dangerous, but possible).

@Giacom
Copy link
Contributor

Giacom commented Apr 19, 2013

Just make a proc with all the code and make different verbs that just call that proc.

@AndroidSFV
Copy link
Author

Restructured it as recommended

@Giacom
Copy link
Contributor

Giacom commented Apr 20, 2013

Works fine.

Giacom added a commit that referenced this pull request Apr 20, 2013
'State Laws' verb for Cyborgs
@Giacom Giacom merged commit 6669148 into tgstation:master Apr 20, 2013
EgorDinamit pushed a commit to EgorDinamit/tgstation that referenced this pull request Jul 3, 2020
* Updated the show_laws() proc to add feedback in the logs.

Much needed addition, was actually a lot simpler to implement than I previously anticipated.

* Added comments to show_laws()

* Added round_end_antags.json and added .json as a valid extension for files viewable by people

Hopefully this won't cause any issue, otherwise I can just change round_end_antags and round_end_data to be .txt files, I tested it and it works fine as well. Just did this because folks on coderbus told me that it was the way to do it. Now, round_end_data.json is also viewable, even if I doubt anyone would want to look at that useless mess.
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 31, 2020
* senior titles are saved to the savefile

* fixed order of operations on alt/senior title check

Co-authored-by: Untrius <untrius@protonmail.com>
Co-authored-by: Mark Suckerberg <tommjd54321@outlook.com>
Co-authored-by: Shayne Fitzgerald <shaynefitzgerald0@gmail.com>
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 31, 2020
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 12, 2021
* Tree randomization distance fix capitalization on handy names -and brown

* Changes job selection colour background

Co-authored-by: Popoff <ProfessorPopoff@users.noreply.github.com>
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Mar 12, 2023
…ion#399)

* Allow Monkey used injector to generate CRISPR Charge (tgstation#65552)

Changed DNA Console behavior so it will accept unfilled dna injector, allowing use of monkeys to generate a CRISPR charge, as per Wiki Genetics Guide statement that this should be possible.

Fixes CRISPR charge to not be added despite the message saying so.

* Allow Monkey used injector to generate CRISPR Charge

Co-authored-by: MrNihil <33802925+MrNihil@users.noreply.github.com>
Co-authored-by: Debian <debian@packer-output-01d6f1be-59bf-4994-80ec-c61b12fe30e1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants