Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Luxury shuttle charges bank cards #40334

Merged
merged 2 commits into from Sep 24, 2018
Merged

[READY] Luxury shuttle charges bank cards #40334

merged 2 commits into from Sep 24, 2018

Conversation

cacogen
Copy link
Contributor

@cacogen cacogen commented Sep 18, 2018

馃啈 cacogen
add: Luxury shuttle now attempts to charge humans' bank accounts in addition to taking held and dragged money
add: Luxury shuttle now attempts to return change to humans' bank accounts
add: You can now pay for the luxury shuttle in instalments (mostly useful for handless mobs)
tweak: Luxury shuttle ticket booth messages are now spoken, so you can spend loudly
/:cl:

Other changes:

  • Gives the ticket booth a unique name and description
  • Gives humans a proc to return their bank account datum, or false if they don't have one

Why:

  1. Allows handless mobs to pay with denominations smaller than 500 credits
  2. Ticket booth talks because it's better.

What else I'd like to add:

  • Gets money straight from ID
  • Change proc?

This originally gave tickets that could be stolen from other players but Goof's economy pull means most people will have the money to board now.

@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Sep 18, 2018
@ninjanomnom
Copy link
Member

Please only open prs which build on code in the master branch. Wait for the other pr to be merged before opening a further pr building on that. Ask any maintainer to reopen this later

@cacogen
Copy link
Contributor Author

cacogen commented Sep 18, 2018

It duplicates the code from the previous PR

@cacogen
Copy link
Contributor Author

cacogen commented Sep 19, 2018

@ninjanomnom Old one got merged so reopen pls

@ninjanomnom ninjanomnom reopened this Sep 20, 2018
@ninjanomnom
Copy link
Member

Ask in the coderbus irc to get it open faster, that's where the maintainers hang out.

@cacogen cacogen changed the title Luxury shuttle payment in increments and stealable tickets Luxury shuttle payment in increments Sep 24, 2018
@cacogen cacogen changed the title Luxury shuttle payment in increments [READY] Luxury shuttle charges bank cards Sep 24, 2018
@Iamgoofball
Copy link
Contributor

this should work exclusively with the bank card, we don't want people using other forms of money

they can convert it to their bank card by just smashing the ID with it if they want to

@cacogen
Copy link
Contributor Author

cacogen commented Sep 24, 2018

I'm going to keep it so dragged money works so simple mobs can access the shuttle, but I can remove it looking for held money.

Copy link
Member

@ninjanomnom ninjanomnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate how istype-ey this proc is but this seems fine. At some point we really should refactor how the money is counted

@ninjanomnom ninjanomnom merged commit 9d258ff into tgstation:master Sep 24, 2018
ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 Sep 24, 2018
* Payment in increments, for handless mobs

* Luxury shuttle now works with bank cards
@Iamgoofball
Copy link
Contributor

@ninjanomnom im telling you, this should just only allow money from your account

@ninjanomnom
Copy link
Member

I don't see a good reason why

@Iamgoofball
Copy link
Contributor

Unifying all the money systems. We can just make it easy to slam all these other types of cash into your account, so that we only have to just do a check against the account instead of all these istype checks.

@ShizCalev ShizCalev added this to the Economy milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants