New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Luxury shuttle charges bank cards #40334
Conversation
Please only open prs which build on code in the master branch. Wait for the other pr to be merged before opening a further pr building on that. Ask any maintainer to reopen this later |
It duplicates the code from the previous PR |
@ninjanomnom Old one got merged so reopen pls |
Ask in the coderbus irc to get it open faster, that's where the maintainers hang out. |
this should work exclusively with the bank card, we don't want people using other forms of money they can convert it to their bank card by just smashing the ID with it if they want to |
I'm going to keep it so dragged money works so simple mobs can access the shuttle, but I can remove it looking for held money. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate how istype-ey this proc is but this seems fine. At some point we really should refactor how the money is counted
* Payment in increments, for handless mobs * Luxury shuttle now works with bank cards
@ninjanomnom im telling you, this should just only allow money from your account |
I don't see a good reason why |
Unifying all the money systems. We can just make it easy to slam all these other types of cash into your account, so that we only have to just do a check against the account instead of all these istype checks. |
馃啈 cacogen
add: Luxury shuttle now attempts to charge humans' bank accounts in addition to taking held and dragged money
add: Luxury shuttle now attempts to return change to humans' bank accounts
add: You can now pay for the luxury shuttle in instalments (mostly useful for handless mobs)
tweak: Luxury shuttle ticket booth messages are now spoken, so you can spend loudly
/:cl:
Other changes:
Why:
What else I'd like to add:
Change proc?This originally gave tickets that could be stolen from other players but Goof's economy pull means most people will have the money to board now.