Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paystand Modifications #41588

Merged
merged 4 commits into from Dec 2, 2018
Merged

Paystand Modifications #41588

merged 4 commits into from Dec 2, 2018

Conversation

MMMiracles
Copy link
Contributor

@MMMiracles MMMiracles commented Nov 18, 2018

馃啈 MMMiracles
add: Signalers can now be attached to active paystands to send a signal when a certain amount of money is deposited.
add: Swiping your card on a paystand you own will let you lock it down, preventing it from being unbolted from the ground.
tweak: Paystands now ask for how much you want to deposit when interacting instead of a static price.
/:cl:

I thought it was pretty dumb the paystands designed to encourage shops was also forced to a single static price instead of allowing the person to put in how much they actually wanted to pay.

The signaler attaching lets you hook up a signaler to any active paystand and set up a threshold. Any amount of money deposited after this will start counting up to the threshold and reset when said threshold is hit, activating the signaler in the process.

@PKPenguin321
Copy link
Contributor

Allow the stand owner to set a min and max, maybe?

@MMMiracles
Copy link
Contributor Author

I dunno exactly what you could use with a minimum/maximum amount, but I am going to add an option to slap a signaler on it that activates when a threshold is hit on depositing.

@MMMiracles MMMiracles changed the title Paystands now take a custom input for payment Paystands now take a custom input for payment + signaler attaching Nov 19, 2018
@davethwave
Copy link
Contributor

Set up a hellnade hidden outside or inside sec with a signaler attached to it. Then make a paystand saying I will destroy sec for 500 moneys or something. Watch as sec gets hellnade by the power of capitalism.

@81Denton
Copy link
Member

Now I can finally swallow a signaller and have people pay me to die

@MMMiracles MMMiracles changed the title Paystands now take a custom input for payment + signaler attaching Paystand Modifications Nov 19, 2018
@coiax
Copy link
Member

coiax commented Nov 19, 2018

@MMMiracles coding tills with payment terminals when

Copy link
Member

@Cyberboss Cyberboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other spelling reviews +

code/modules/economy/pay_stand.dm Outdated Show resolved Hide resolved
code/modules/economy/pay_stand.dm Outdated Show resolved Hide resolved
@MMMiracles
Copy link
Contributor Author

I wanna do ATMs next to allow pulling credits out and depositing physical cash. Maybe even let people hack them for their internal hold of physical cash and give grey shirts more !FUN! ways of getting dirty money.

desc = "Owned by [assistant_mains_need_to_die.registered_account.account_holder]. Pays directly into [user.p_their()] account when swiped with an ID card."
price = price2
name = msg
desc = "Owned by [assistant_mains_need_to_die.registered_account.account_holder], pays directly into [user.p_their()] account."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: make desc customizable

@Iamgoofball
Copy link
Contributor

Fuck off with that atm idea holy shit we literally do not need ATMs
The pr is good though

@MMMiracles
Copy link
Contributor Author

open source I do whatever I want lol

@Iamgoofball
Copy link
Contributor

Iamgoofball commented Nov 21, 2018

fair fucking christ there goes my thanksgiving and also my portfolio

@PKPenguin321
Copy link
Contributor

WOW goof, reported you to github for being rude/ableist which violates their ToS.

@Militaires
Copy link

Goof has been attacked, this will not stand.

ghost pushed a commit to HippieStation/HippieStationdeprecated2020 that referenced this pull request Dec 2, 2018
@optimumtact
Copy link
Member

[2018-12-02 21:00:58.676] runtime error: Cannot read null.secured
[2018-12-02 21:00:58.676] proc name: attackby (/obj/machinery/paystand/attackby)
[2018-12-02 21:00:58.676]   source file: pay_stand.dm,64
[2018-12-02 21:00:58.676]   usr: Grant Tin (/mob/living/carbon/human)
[2018-12-02 21:00:58.676]   src: Pay to kill me (/obj/machinery/paystand)
[2018-12-02 21:00:58.676]   usr.loc: the floor (108,116,2) (/turf/open/floor/plasteel)
[2018-12-02 21:00:58.676]   src.loc: the floor (108,115,2) (/turf/open/floor/plasteel)
[2018-12-02 21:00:58.676]   call stack:
[2018-12-02 21:00:58.676] Pay to kill me (/obj/machinery/paystand): attackby(the remote signaling device (/obj/item/assembly/signaler), Grant Tin (/mob/living/carbon/human), "icon-x=19;icon-y=17;left=1;scr...")
[2018-12-02 21:00:58.676] the remote signaling device (/obj/item/assembly/signaler): melee attack chain(Grant Tin (/mob/living/carbon/human), Pay to kill me (/obj/machinery/paystand), "icon-x=19;icon-y=17;left=1;scr...")
[2018-12-02 21:00:58.676] Grant Tin (/mob/living/carbon/human): ClickOn(Pay to kill me (/obj/machinery/paystand), "icon-x=19;icon-y=17;left=1;scr...")
[2018-12-02 21:00:58.676] Pay to kill me (/obj/machinery/paystand): Click(the floor (108,115,2) (/turf/open/floor/plasteel), "mapwindow.map", "icon-x=19;icon-y=17;left=1;scr...")
[2018-12-02 21:00:58.676] Blargety (/client): Click(Pay to kill me (/obj/machinery/paystand), the floor (108,115,2) (/turf/open/floor/plasteel), "mapwindow.map", "icon-x=19;icon-y=17;left=1;scr...")

@MMMiracles
Copy link
Contributor Author

d'oh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet