Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready] Adds 5 new negative/minor negative mutations, mutation conflict system #42524

Conversation

PKPenguin321
Copy link
Contributor

@PKPenguin321 PKPenguin321 commented Jan 26, 2019

🆑
add: New system in genetics: Conflicting mutations. Some mutations will not allow others to activate. Example - If you have mutation A, and it conflicts with B, then B will never activate until you get rid of mutation A (and visa versa). The only mutations to currently use this are Dwarfism and Gigantism. Speaking of which...
add: New minor negative mutation: Gigantism. Opposite of dwarfism, makes you larger.
add: New disability: Spastic. You will randomly take a step in a random direction, will randomly change intent, and will randomly try to click on somebody near you (which can hug them, punch them, use whatever is in your hand on them, etc).
add: New disability: Acid flesh. Pockets of acid bubble beneath your skin. They will occasionally pop, coating you with acid. This will melt clothes and deal damage to you.
add: New disability: Spatial Instability. You will randomly teleport, similar to a wizard's blink teleport. This is a very nauseating process, and will inevitably make you very sick if you don't rid yourself of it.
add: New disability: Two Left Feet. Your right foot becomes a second left foot. You take longer to get up from stuns.
/:cl:

Will probably add combination-only powers that use these as components in future PRs.

also adds a mutation conflict system
@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Jan 26, 2019
@Razharas
Copy link
Contributor

Razharas commented Jan 26, 2019

A general solution to this is recipe system
With recipe resolving you can have smooth tricky cases like mutations X and Y are conflicting but when you get new one the old one is displaced
Or Mutation X always overrides mutation Y but not the other way
Or custom things like "you can only have any 4 of these 6 mutation types" or "you can only get this mutation if you have these 2 others"

@PKPenguin321
Copy link
Contributor Author

Until there are mutations that would actually benefit from a system like that, I see no point. Plus I think that powers should prevent other powers when they conflict rather than be overwritten, because if they were to overwrite you could just swap powers on the fly with injectors.

Copy link
Contributor Author

@PKPenguin321 PKPenguin321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes to self

code/datums/mutations/body.dm Show resolved Hide resolved
code/datums/mutations/body.dm Outdated Show resolved Hide resolved
@Shadowflame909
Copy link
Contributor

Negative Mutations lower instability right? Allowing you to take more powers with the more negative ones you have?

@PKPenguin321
Copy link
Contributor Author

No, they simply add 0 instability as a general rule.

@ModDownloading
Copy link
Contributor

add: New disability: Spastic. You will randomly take a step in a random direction, will randomly change intent, and will randomly try to click on somebody near you (which can hug them, punch them, use whatever is in your hand on them, etc).

I think it would be pretty funny if this and Clumsy were made into Quirks in addition to mutations (since we already have some mutation/quirk duos like Blindness), but maybe I'm just a bit too eccentric to want this to be a thing.

@Time-Green
Copy link
Contributor

Does this still add the mutation to the discovered mutations? Otherwise people are gonna be confused with what they did wrong with sequence solving

@PKPenguin321
Copy link
Contributor Author

Good question. I believe it shouldn't affect that but I could be wrong, haven't looked at the code for that

@Time-Green
Copy link
Contributor

Looks like it doesn’t discover judging by code. I guess not having your subject have alot of mutations might be a good solution, because bypassing this will be a pain codewise

@Jordie0608 Jordie0608 added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jan 30, 2019
@SouDescolado
Copy link
Contributor

SouDescolado commented Feb 5, 2019

I assume Spastic ignores Pacifism when punching people?

@SouDescolado
Copy link
Contributor

Also it would be funny if every time someone got cured from a mutation that has a conflict, there is a chance (maybe low, maybe 50) it gets the conflicting mutation. Like.. Had Gigantism? You are now Dwarf.

@PKPenguin321
Copy link
Contributor Author

I assume Spastic ignores Pacifism when punching people?

Not sure if there's a clean way to do that due to the way pacifism works, sadly

code/datums/mutations.dm Outdated Show resolved Hide resolved
code/datums/mutations.dm Outdated Show resolved Hide resolved
code/datums/mutations/body.dm Outdated Show resolved Hide resolved
code/datums/mutations/body.dm Outdated Show resolved Hide resolved
code/datums/mutations/body.dm Outdated Show resolved Hide resolved
code/datums/mutations/body.dm Outdated Show resolved Hide resolved
code/datums/mutations/body.dm Outdated Show resolved Hide resolved
code/datums/mutations/body.dm Show resolved Hide resolved
…genetics-negatives-bundle

# Conflicts:
#	code/__DEFINES/DNA.dm
#	code/game/objects/items/dna_injector.dm
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Feb 8, 2019
and a message given to the subject when a mutation fails to manifest because of conflicts
@PKPenguin321
Copy link
Contributor Author

Should be good to go. Tested on a local server

@PKPenguin321 PKPenguin321 changed the title Adds 5 new negative/minor negative mutations, mutation conflict system [Ready] Adds 5 new negative/minor negative mutations, mutation conflict system Feb 8, 2019
@adamkad1
Copy link

So are disabilities gonna increase stability some time?

@Time-Green
Copy link
Contributor

maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet