Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s] Clowncar exploit fix #43237

Merged
merged 2 commits into from Mar 22, 2019
Merged

Conversation

ShizCalev
Copy link
Member

Fixes #43233
馃啈 ShizCalev
fix: Fixed an exploit allowing you to grab people from anywhere with a clowncar.
/:cl:

@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Mar 20, 2019
@fluffe9911
Copy link
Contributor

clown car should prob be able to grab people who rest now honestly due to the fact resting people can now crawl around and fire weapons at the clown car and the clown car cant do anything to fight back but nice fix

@ShizCalev
Copy link
Member Author

@fluffe9911 i'd lean more towards having them be hurt like mulebots do when they run you over, that'd be for a different PR though.

@ATH1909
Copy link
Contributor

ATH1909 commented Mar 21, 2019

@fluffe9911 i'd lean more towards having them be hurt like mulebots do when they run you over, that'd be for a different PR though.

That's actually a really good idea.

Also, thanks for making a PR to fix this so quickly.

mob_forced_enter(M, silent)
return TRUE
return FALSE

/obj/vehicle/sealed/car/proc/is_car_stationary(atom/old_loc)
if(old_loc == loc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do return (old_loc == loc)

@SpaceManiac SpaceManiac merged commit 896236f into tgstation:master Mar 22, 2019
@ShizCalev ShizCalev deleted the clowncar-exploit branch March 22, 2019 03:57
ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 Mar 22, 2019
Fixed an exploit allowing you to grab people from anywhere with a clowncar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clown Car Can Yoink You From Across The Map
7 participants