Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the damage deflection from reinforced windows #45875

Closed
wants to merge 2 commits into from
Closed

Removes the damage deflection from reinforced windows #45875

wants to merge 2 commits into from

Conversation

ATH1909
Copy link
Contributor

@ATH1909 ATH1909 commented Aug 12, 2019

About The Pull Request

This PR removes the damage deflection that actioninja added to reinforced windows in his recent PR (#45609). It does NOT remove/revert the damage deflection that plasmaglass windows were given, the extra armor given to reinforced windows, or the additional step that was added to the deconstruction process of reinforced windows.

Why It's Good For The Game

Reinforced windows (now) already effectively have 750 health against non-armor piercing melee attacks, which I think is enough to discourage players from causally breaking down reinforced windows.

The damage deflection is completely unnecessary, seeing as how even an armor piercing-less force 10 weapon (just below the damage deflection threshold) would require a whopping 75 whacks to break down a reinforced window if the damage deflection wasn't there anyway.

The presence of this damage deflection on reinforced windows unfortunately can create a few rare/accidental GBJ (gay baby jail, a term for an inescapable (without outside help, which you may or may not be able to contact) prison cell) situations ("'oh no, the power went out in this room and I have no crowbar, guess I'll just sit here and wail over comms (if they aren't down as well) until I'm rescued"). The force threshold for this damage deflection is so low (even a red toolbox bypasses it) that I don't think that it will stop (m)any tiding incidents, and to be honest, it doesn't look like it will ever really come up EXCEPT for in GBJ situations.

This damage deflection on reinforced windows has an almost entirely negative impact on this game's quality and does very little to stop the "problem" that it was added to solve (unlike the extra deconstruction step and extra armor that were added in the same PR that added damage deflection to reinforced windows), which is why I believe that it should be removed.

Changelog

馃啈 ATHATH
del: Reinforced windows no longer have damage deflection (they still have their increased armor and extra deconstruction step, though). Plasmaglass windows still have damage deflection, however.
/:cl:

@tgstation-server tgstation-server added the Removal This was too fun, too fun! I'm turning this feature around label Aug 12, 2019
@actioninja actioninja added Balance Changes to functionality that modifies how effective certain methods are at powergaming and removed Removal This was too fun, too fun! I'm turning this feature around labels Aug 12, 2019
@KetasDotepasto
Copy link
Contributor

Taking out the damage deflection would make it possible to break out of perma again.

@belltop1
Copy link
Contributor

Taking out the damage deflection would make it possible to break out of perma again.

You already can, by smashing machines to make a spear

@PKPenguin321
Copy link
Contributor

I like the technical breakdown of what a GBJ is

@Tlaltecuhtli
Copy link
Contributor

windows are stronger than walls

@MCterra10
Copy link
Contributor

Not really, last I checked you couldn't break walls with a toolbox

@Tlaltecuhtli
Copy link
Contributor

hit a window 750 times vs weld and wrench

@Ratvar
Copy link

Ratvar commented Aug 12, 2019

screw and crowbar window out vs get welding sunglasses or you are blind

@KetasDotepasto
Copy link
Contributor

@Ratvar That changed, the current deconstruction is welder, screwdriver, crowbar, wirecutter, wrench.

@Ratvar
Copy link

Ratvar commented Aug 12, 2019

Stop, that balance change added welder to list of window tools?.. Walls are less protected then windows, I suddenly agree

@belltop1
Copy link
Contributor

Stop, that balance change added welder to list of window tools?

image

from the pr^

@MMMiracles
Copy link
Contributor

I appreciate that simpleflips is relevant enough now for GBJ to be a more common term used.

Also what the fuck are those deconstruction steps? Walls are easier to break apart now in comparison??

@CPTANT
Copy link
Contributor

CPTANT commented Aug 12, 2019

This is not a solution, the time required to bash windows down is prohibitively long even without the deflection.

With a toolbox it already takes TWO MINUTES of non stop bashing to crack a window.

@ATH1909
Copy link
Contributor Author

ATH1909 commented Aug 12, 2019

This is not a solution, the time required to bash windows down is prohibitively long even without the deflection.

With a toolbox it already takes TWO MINUTES of non stop bashing to crack a window.

Aye, that was the intention of actioninja's PR. If that's the direction that the maintainers want to go in, who am I to stop them? I'm merely trying to refine a PR slightly, not undo it completely.

@ExcessiveUseOfCobblestone
Copy link
Contributor

those decon steps lmao

@optimumtact
Copy link
Member

Im happy with how windows are right now

@wesoda25
Copy link
Contributor

bro have you experienced the change yet? I'm all for windows not being a joke to break through, but they are basically just as strong as walls in their current state.

@ATH1909
Copy link
Contributor Author

ATH1909 commented Aug 13, 2019

@optimumtact I literally just encountered an actual GBJ situation with reinforced windows on Bagil: https://cdn.discordapp.com/attachments/326826573951008769/610687754082189322/actual_gbj_situation.PNG

How can you be "happy" with this?

@optimumtact
Copy link
Member

because it's pretty short work to remap the escape to have non reinforced windows

@ATH1909
Copy link
Contributor Author

ATH1909 commented Aug 13, 2019

because it's pretty short work to remap the escape to have non reinforced windows

*arrivals

By that same logic, you could say that it's pretty short work to remap the permabrig to use plasmaglass windows instead of reinforced ones.

I just... don't see how you see the damage deflection as adding to the intended reinforced window experience. How exactly is it supposed to help achieve the goal of the reinforced window buff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet