Readd cooldowns on the world topic

[optimumtact]

Thanks to whomever removed these, you're a real star

[deathride58]

putting the cooldowns/spam checks prior to TGS_TOPIC means that all of the relevant spam checks will essentially be bypassed, since most of the things that respond to topic calls are handled via TgsTopic()

[optimumtact]

I actually mean to move that and forgot

[optimumtact]

@Cyberboss @MrStonedOne

[MrStonedOne]

This would trigger for the webserver, it requests topic at a rate of once per second.

[MrStonedOne]

Use an associated list reference instead of in.

in is O(n), blah[key] is O(log n)

[optimumtact]

for some reason I thought that gives a runtime about the key if it doesn't exist

[NethIafin]

This would trigger for the webserver, it requests topic at a rate of once per second.

I think if you add TGS to some sort of IP whitelist...

[Cyberboss]

All that would be needed is localhost

…

On Sat, Jan 4, 2020, 3:20 PM Neth ***@***.***> wrote: This would trigger for the webserver, it requests topic at a rate of once per second. I think if you add TGS to some sort of IP whitelist... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#48542?email_source=notifications&email_token=AB6LA6QKHNNYLWHIHTJ7BF3Q4DVQZA5CNFSM4KCG63TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIC7QJA#issuecomment-570816548>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6LA6XUI5O6HGXW7UG4CJDQ4DVQZANCNFSM4KCG63TA> .

[NethIafin]

instead use
lasttimeaddr[addr] = world.time + 2 SECONDS
and check that
if(world.time < lasttime)

[MrStonedOne]

I think if you add TGS to some sort of IP whitelist...

The webserver/game banners do not use TGS.

They do not come from localhost. they come from a lan ip for all servers except the eu servers, those see the internet ip of the webserver.

[MrStonedOne]

This needs to be configurable, and should either be the normal standard format of count in time, or a better count in static timeframe system.

Look at the topic limiter for an example of a robust anti-spam system.

The ability to add ips on a whitelist would also help.

[NethIafin]

this doesn't appear to help. Tested close enough implementation on CM, stayed dead.

[Crossedfall]

Would still be good to have regardless. As for the whitelisting, could just open up a new config entry for that? That way you don't have to hardcode IPs into the handling.

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.