Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY TO BE MERGED] King Goat Achievements, bugfixes, and minor tweaks #49159

Merged

Conversation

fluffe9911
Copy link
Contributor

@fluffe9911 fluffe9911 commented Feb 2, 2020

About The Pull Request

Just some minor tweaks/fixes

Why It's Good For The Game

Makes king goat slightly less bullshite while lowering cheese slightly (until people find a new way to cheese it)

Changelog

🆑
add: King Goat achievements
tweak: King Goat spells per phase lowered from 10 to 5
tweak: King Goat goes back to normal speed after casting super speed spell 2x faster
fix: Hiro teleport no longer works in NOTELEPORT areas
fix: moved king goat file to proper area
tweak: better goat hoof and goat gun sprite courtesy of Usnavi!
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Sprites A bikeshed full of soulless bikes. Tweak labels Feb 2, 2020
@Arathianen
Copy link

Kink Goat

hmm

@Buggy123
Copy link
Contributor

Buggy123 commented Feb 2, 2020

Did you fix the arena being fully pressurized, making most mining weapons near-useless?

@HomocidlePancakes
Copy link

Did you fix the arena being fully pressurized, making most mining weapons near-useless?

It's intentional in his opinion, lol.

@fluffe9911
Copy link
Contributor Author

Actually I just never bothered making it not pressurized

@tgstation-server tgstation-server added the Map Edit Thank you for your tile-placing service. It's always appreciated. label Feb 2, 2020
@Taylorkills2
Copy link

From what I saw, King Goat ignores deflect chance on Katanas and Captain's Sabre. It'd be nice for it to be changed so Ash Walkers with tendril loot might have a chance at beating it.

@fluffe9911 fluffe9911 changed the title King Goat bugfixes and minor tweaks King Goat Achievements, bugfixes, and minor tweaks Feb 4, 2020
@fluffe9911
Copy link
Contributor Author

Ready to be merged/more reviews wheneves

@fluffe9911 fluffe9911 changed the title King Goat Achievements, bugfixes, and minor tweaks [READY TO BE MERGED] King Goat Achievements, bugfixes, and minor tweaks Feb 14, 2020
@@ -319,6 +319,11 @@
button_icon_state = "vortex_recall"

/datum/action/item_action/vortex_recall/IsAvailable()
var/turf/current_location = get_turf(target)
var/area/current_area = current_location.loc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_area?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing get_turf to get_area just break things while the current method works perfectly fine unless im missing something

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be figured out, you shouldn't have to make an intermediate var for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voodoo magic man

code/modules/cargo/packs.dm Outdated Show resolved Hide resolved
…f_goats.dm

Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
@IndieanaJones
Copy link
Contributor

IndieanaJones commented Feb 23, 2020

Not going to lie, this ruin still seems like a shitty meme. The fact that it got added where it's just a small room (that's not pressurized) with mobs that are pretty much regular hostile mobs in a random box in space certainly seems lackluster.

@ExcessiveUseOfCobblestone
Copy link
Contributor

If you didn't edit anything please don't press 'resolve'.

@ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone merged commit 5eea399 into tgstation:master Feb 25, 2020
@Fikou Fikou mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants