Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new skater skill, gained (and lost!) by wracking up some unholy gnar! #49215

Conversation

tralezab
Copy link
Contributor

@tralezab tralezab commented Feb 6, 2020

alternativation of #49204

About The Pull Request

Cowabunga! I snark to see a wheelie boy like you rise up to the rankulation of master sidewalk cruster! Unfortunately for you, tech dog, you'll have to rink some hella five oh if you want to cork us!

If you manage to avoid sacking it, you'll be able to quickly drop your board and hop on!

If you get to be some kinda pro who snacks on hill bombs on the reg, you'll be able to grind over people (and i aint talking bout no pro ho haha 🤙 )! tubular!

Why It's Good For The Game

I can't just let some suit boy poser work up a crowd because he can drop in! (letting people go from hand skate to buckle moving is really strong and it should be EARNED)

Changelog

🆑
add: Skating skill! Will you slappie or slam?
/:cl:

@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Feb 6, 2020
@tralezab
Copy link
Contributor Author

tralezab commented Feb 6, 2020

i'm trying to run a wallie on 18th street but i'll be back to add achievies 2nite!

V.grinding = TRUE
V.icon_state = "[V.board_icon]-grind"
addtimer(CALLBACK(V, /obj/vehicle/ridden/scooter/skateboard/.proc/grind), 2)
next_ollie = world.time + 5

/mob/proc/kek()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test proc!! gotta blam that fore my dumb dad oranges grounds me 😔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'course bro, gotta lay low so the man dont see, ya dig?

@PKPenguin321
Copy link
Contributor

rad

@ATH1909
Copy link
Contributor

ATH1909 commented Feb 6, 2020

How long will it take to (literally) grind up to master skating skill?

@evilcyborgmrt
Copy link

Next add half pipe construction so we can make illicit maint skate park

@improvedname
Copy link
Contributor

Youre+off+fine+without+the+tails+one+_7c7fc729b31370817c9cf5521a62449f

@tralezab
Copy link
Contributor Author

tralezab commented Feb 6, 2020

hands off the drip, bro

@cacogen
Copy link
Contributor

cacogen commented Feb 6, 2020

♫ you know the day destroys the night ♫

code/__DEFINES/skills.dm Outdated Show resolved Hide resolved
@Ty-the-Smonk
Copy link
Contributor

At max skill they should get a skater language

@tralezab
Copy link
Contributor Author

tralezab commented Feb 7, 2020

okacious hot dogs, i'm gonna ratatat those issues 😎

@XDTM
Copy link
Contributor

XDTM commented Feb 7, 2020

I'm not sure if you should lose skill when failing a grind, everyone learns by failing after all. At worst simply make it not give anything, or a bad moodlet for the uncool display

@ghost
Copy link

ghost commented Feb 7, 2020

@XDTM no no he's like keeping tally essentially, if you fuck up you lose the gained experience.

Although you should probably add the xp gained after the grind and just keep count

return
var/mob/living/L = buckled_mobs[1]
var/the_legend = L.mind.get_skill_level(/datum/skill/skating) >= SKILL_LEVEL_MASTER
var/list/valid_grinds = the_legend ? list(/obj/structure/table, /mob/living) : list(/obj/structure/table)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix that thing where skater legends grind on themselves

@XDTM
Copy link
Contributor

XDTM commented Feb 7, 2020

@XDTM no no he's like keeping tally essentially, if you fuck up you lose the gained experience.

Although you should probably add the xp gained after the grind and just keep count

L?.mind.adjust_experience(/datum/skill/skating, -saved_grind_skill)
saved_grind_skill = initial(saved_grind_skill)

I'm pretty sure the code stores an amount of xp, and either grants you the amount on a successful grind, and then resets the amount to 0, or removes that same amount, while resetting it afterwards to 0.

@@ -498,6 +498,19 @@ GLOBAL_LIST_EMPTY(species_list)
if(!HAS_TRAIT(L, TRAIT_PASSTABLE))
L.pass_flags &= ~PASSTABLE

/proc/passmob_on(target, source)
var/mob/living/L = target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to restrict this proc to mobs, you could move these as well as the passtable helpers into atoms, and use them for the skateboard too instead of setting the flag manually

@Mickyan
Copy link
Contributor

Mickyan commented Feb 7, 2020

I would suggest scaling experience gain so grinding 5 tables at once is worth a bit more than grinding 1 table 5 times and also give a bit of exp just for doing ollies

@tralezab
Copy link
Contributor Author

tralezab commented Feb 7, 2020

I got a loadness monster of ideas to hot drop in. Stay cool!

@kriskog
Copy link
Contributor

kriskog commented Feb 13, 2020

I didnt understand a word of this.

You also got a merge conflict

@kriskog kriskog added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Feb 13, 2020
@tralezab
Copy link
Contributor Author

alternate was merged peace

@tralezab tralezab closed this Feb 15, 2020
@PKPenguin321
Copy link
Contributor

weak

@Mickyan
Copy link
Contributor

Mickyan commented Feb 15, 2020

not radical

@cacogen
Copy link
Contributor

cacogen commented Feb 15, 2020

two broken legs down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet