-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new skater skill, gained (and lost!) by wracking up some unholy gnar! #49215
new skater skill, gained (and lost!) by wracking up some unholy gnar! #49215
Conversation
i'm trying to run a wallie on 18th street but i'll be back to add achievies 2nite! |
V.grinding = TRUE | ||
V.icon_state = "[V.board_icon]-grind" | ||
addtimer(CALLBACK(V, /obj/vehicle/ridden/scooter/skateboard/.proc/grind), 2) | ||
next_ollie = world.time + 5 | ||
|
||
/mob/proc/kek() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test proc!! gotta blam that fore my dumb dad oranges grounds me 😔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'course bro, gotta lay low so the man dont see, ya dig?
rad |
How long will it take to (literally) grind up to master skating skill? |
Next add half pipe construction so we can make illicit maint skate park |
hands off the drip, bro |
♫ you know the day destroys the night ♫ |
At max skill they should get a skater language |
okacious hot dogs, i'm gonna ratatat those issues 😎 |
I'm not sure if you should lose skill when failing a grind, everyone learns by failing after all. At worst simply make it not give anything, or a bad moodlet for the uncool display |
@XDTM no no he's like keeping tally essentially, if you fuck up you lose the gained experience. Although you should probably add the xp gained after the grind and just keep count |
return | ||
var/mob/living/L = buckled_mobs[1] | ||
var/the_legend = L.mind.get_skill_level(/datum/skill/skating) >= SKILL_LEVEL_MASTER | ||
var/list/valid_grinds = the_legend ? list(/obj/structure/table, /mob/living) : list(/obj/structure/table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix that thing where skater legends grind on themselves
I'm pretty sure the code stores an amount of xp, and either grants you the amount on a successful grind, and then resets the amount to 0, or removes that same amount, while resetting it afterwards to 0. |
@@ -498,6 +498,19 @@ GLOBAL_LIST_EMPTY(species_list) | |||
if(!HAS_TRAIT(L, TRAIT_PASSTABLE)) | |||
L.pass_flags &= ~PASSTABLE | |||
|
|||
/proc/passmob_on(target, source) | |||
var/mob/living/L = target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to restrict this proc to mobs, you could move these as well as the passtable helpers into atoms, and use them for the skateboard too instead of setting the flag manually
I would suggest scaling experience gain so grinding 5 tables at once is worth a bit more than grinding 1 table 5 times and also give a bit of exp just for doing ollies |
I got a loadness monster of ideas to hot drop in. Stay cool! |
I didnt understand a word of this. You also got a merge conflict |
alternate was merged peace |
weak |
not radical |
two broken legs down |
alternativation of #49204
About The Pull Request
Cowabunga! I snark to see a wheelie boy like you rise up to the rankulation of master sidewalk cruster! Unfortunately for you, tech dog, you'll have to rink some hella five oh if you want to cork us!
If you manage to avoid sacking it, you'll be able to quickly drop your board and hop on!
If you get to be some kinda pro who snacks on hill bombs on the reg, you'll be able to grind over people (and i aint talking bout no pro ho haha 🤙 )! tubular!
Why It's Good For The Game
I can't just let some suit boy poser work up a crowd because he can drop in! (letting people go from hand skate to buckle moving is really strong and it should be EARNED)
Changelog
🆑
add: Skating skill! Will you slappie or slam?
/:cl: