Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Airlock Authentication Override Card #50636

Merged
merged 7 commits into from Apr 28, 2020

Conversation

MrDoomBringer
Copy link
Contributor

@MrDoomBringer MrDoomBringer commented Apr 23, 2020

About The Pull Request

Cryptographic sequencers can no longer open airlocks
The Airlock Authentication Override Card can open airlocks (3 charges, each charge refills over the course of a couple minutes)

Why It's Good For The Game

@optimumtact said it was good for the game
The data says the emag is the most bought traitor item. This is because the emag has too much bloat. To help mitigate this this we've taken away airlock hacking from the emag, however instead of removing the feature outright (as in #50632) we move the feature to a new item, for those who really still want to be able to hack doors

Changelog

馃啈 MrDoomBringer with some code stolen from itseasytosee
add: added the Airlock Authentication Override Card. Use it to open airlocks!
add: added Syndicate Jaws of Life to the nuke op uplink. Use it in it's crowbar configuration to open as many doors as you'd like!
del: The cryptographic sequencer can no longer open airlocks :(
/:cl:

Closes #50632

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Removal This was too fun, too fun! I'm turning this feature around Sprites A bikeshed full of soulless bikes. labels Apr 23, 2020
@EgorDinamit
Copy link
Contributor

Please don't.
Also put a valid reason for why it is good for the game.

@@ -0,0 +1,96 @@
/* Emags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot the pumpkin emag here

@Megarop
Copy link
Contributor

Megarop commented Apr 23, 2020

I can get not wanting traitors to be able to open as many doors as they like with a cryptographic sequencer, but this is a pretty harsh nerf for nuke ops.

Also the Airlock Authentication Override card sounds awful, especially for a 6 TC item that you have to dump even more TC in in order to use it more than five times.

@MrDoomBringer
Copy link
Contributor Author

@EgorDinamit ok
@Megarop sorry, didn't change TC values. It'll be updated in a second

@TheVekter
Copy link
Contributor

Yeah, I'm not sure how I feel about this. oranges can put their two cents in on this, but I'm not a fan. If we're gonna nerf the emag, we probably need a better solution than "an emag but worse".

@MrDoomBringer
Copy link
Contributor Author

@TheVekter It's literally the same as the other PR but instead of removing the feature outright it just makes a new item that has that feature if you still really want to use it

@MrDoomBringer
Copy link
Contributor Author

@Megarop I made the PR without tweaking the TC values first. Take a look now, prices are more reasonable

@TheVekter
Copy link
Contributor

@TheVekter It's literally the same as the other PR but instead of removing the feature outright it just makes a new item that has that feature if you still really want to use it

It being an alternative for an already bad PR doesn't magically make it good. Have you considered making it infinite but it takes like 5-10 seconds to open the door?

@Shadowflame909
Copy link
Contributor

why would I spend 3 tc, (plus more if I want more charges.) on a limited use door opener, when I could spend 8 tc on an e-sword, that's a lethal weapon which doubles as a door opener.

The reason the e-mag was so good, was because it was the best door-opener, and also doubled as a non-lethal sabotage option.

There are so many more lethal options, cheaper depending on what you're trying to do. Like buying x4, or getting the agent card which allows you to kill people and steal their access.

I think this is useless and at the very worse, a gross waste of a new player's tc.

If someone really wants 5 magic door opening chances. They'll just buy a bag of c4. If they want to spend more tc on more charges, they'll buy the c4 individually.

But what I think the majority of experienced players are going to do? Much more cost-expensive tc wise to break down a door with a very strong weapon, like the infinite use dual e-sword or a holoparasite, then waste tc on this.

@wesoda25
Copy link
Contributor

I think you should just consolidate this into the emag so that it has unlimited uses on machines, but with the limited uses for doors. Also one tc per door is way too steep a price, it should be double or triple. Still I don鈥檛 like this, there is no need for this PR since there was no guarantee the other would be merged.

@Megarop
Copy link
Contributor

Megarop commented Apr 23, 2020

The data says the emag is the most bought traitor item. This is because the emag has too much bloat.

Why don't you remove the functions of the emag that make it 'bloated' then instead of removing the main function of the emag so it has nothing but 'bloat'?

@Megarop I made the PR without tweaking the TC values first. Take a look now, prices are more reasonable

I'm still against the entire concept of having a traitor item that you need to constantly insert TC into to keep using like it's an arcade machine but I guess this is slightly more reasonable

one tc per door is way too steep a price, it should be double or triple.

I just assumed that was a placeholder and they were gonna change it later, with that price it's cheaper to just buy another card over and over again than to put TC in the one you already have.

@necromanceranne
Copy link
Contributor

necromanceranne commented Apr 23, 2020

I actually hate this more than outright nothing. Generally speaking, emags were a convenience item at best and could be replaced with a RCD (kinda). Meanwhile, for ops, it is somewhat mandatory but also enables blitz ops off the back of the item alone. For ops, this basically means nothing and they are the biggest offenders for using emags for quick mobility.

If anything this is a buff to blitz ops since about 5 doors is all you'll need to hit to reach the captain with his pants down. And if I expect to go through more doors Ill just...buy another doormag and pay the old emag tax?

Also that tc to charges conversion rate is 1 for 1? Why would I not just buy a fresh doormag?

@ATH1909
Copy link
Contributor

ATH1909 commented Apr 23, 2020

If you really HAVE to do this, why not make this work like fulpstation's budget emag, in that it has only two charges, but regenerates one of its charges every 30 seconds?

@MrDoomBringer
Copy link
Contributor Author

@ATH1909 I've gotten a couple suggestions about making it a time-based recharge with a certain number of charges, I'll look into that

@ATH1909
Copy link
Contributor

ATH1909 commented Apr 23, 2020

For reference, here's how Fulp did it:
TheSwain#273
TheSwain#295

@AdamElTablawy
Copy link
Contributor

If i'm being made to spend 6 tc on an item that has no use other than opening doors, I'm buying a 1tc syndie toolbox and going from there.

@optimumtact
Copy link
Member

that is pretty much what the goal is mate

@Shadowflame909
Copy link
Contributor

Shadowflame909 commented Apr 23, 2020

Orange man. no!

You must realize that a sabotage omni tool like the emag is preferable to the traitor deciding to buy a standard holoparasite who beats the crap out of you.

An emag cant beat the crap out of you! That's why it's 6 tc!!!!!

Edit: Comparison because the standard holoparasite can instantly break down non r-walls.

@optimumtact
Copy link
Member

I'd prefer they use the holoparasite, the emag is stale.

@MrDoomBringer
Copy link
Contributor Author

@Shadowflame909 Spending 18 tc on something that will tell everyone you're a traitor that can do nothing put punch is not really an option when you want to stealthily break into a department, you know

@BeeSting12
Copy link
Contributor

Keep this rolled into the emag but make it rechargeable like the EMP flash light. Four doors and then you have to wait for it to recharge.

@optimumtact
Copy link
Member

@tgstation tgstation locked as too heated and limited conversation to collaborators Apr 23, 2020
@tgstation tgstation unlocked this conversation Apr 25, 2020
@optimumtact optimumtact merged commit 74d9291 into tgstation:master Apr 28, 2020
@CRITAWAKETS CRITAWAKETS mentioned this pull request May 5, 2020
8 tasks
@saprasam

This comment was marked as spam.

@optimumtact
Copy link
Member

No!

@saprasam

This comment was marked as spam.

@MrDoomBringer
Copy link
Contributor Author

No! You're stupid!

@saprasam

This comment was marked as spam.

@ujiohiugyihljhujh
Copy link

you all are stupid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Removal This was too fun, too fun! I'm turning this feature around Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet