New tgui based orbit menu #51585
New tgui based orbit menu #51585
Conversation
tgstation-server
added
Feature
|
To be honest the only thing about this I don't like is how annoying it'll be to find that one person out of a clump of sixty. Some sort of way to search would be neat (emulating how with the current menu we can tap a letter to cycle through all mobs with that name). Maybe a search bar at the top that you can start typing in, and it only lists mobs below who's names start with the text you entered? Also don't forget that we have the ability to orbit ghosts too. |
|
Completely meant to add a search but forgot! Thanks for reminding me. Yes, ghosts are supported in here, I just forgot to scroll down I believe. |
|
Just using startsWith is a bit too naiive in my opinion since you won't be able to search stuff like CTF, but it's better than nothing and can be improved later. Committing this soon.
|
| const PATTERN_NUMBER = / \(([0-9]+)\)$/; | ||
|
|
||
| const searchFor = bySearch => thing => { | ||
| return thing.name.toLowerCase().startsWith(bySearch.toLowerCase()); |
There was a problem hiding this comment.
I don't know shit about JS tbh, but couldn't this be a regex search? That way you don't need to exactly type the starting characters of your search.
There was a problem hiding this comment.
It could just as easily just check contains, I can change that later.
|
|
Co-authored-by: Emmanuel S. <emmanuelssr@gmail.com>
|
Whoops, rebasing didn't do what I expected it to--will just do a normal merge commit next time. |
|
Hitting Enter in the search bar should snap you to orbit the most relevant result |
|
CC @stylemistake for a quick check on the latest commit, not sure if you get notifications for it. |
|
I do get notifications. All looks good. Rebasing is preferred; you can use tgui git hooks, which make rebasing easier. |
|
Will definitely set those up when I can, thanks. |
|
Late on the draw to this but it would also be nice if this could automatically give focus to the text input when the window is opened so you don't have to click it |
|
@PKPenguin321 I tried this, but couldn't get it to work. I think even in |
About The Pull Request
Replaces the default BYOND input window with a new tgui window that provides a friendly layout to ghosts.
Will show antagonists if those antagonists aren't meant to be stealthy, such as nightmare and ninjas. Basically, antags you would be able to obviously figure out just from being a ghost anyway.
For alive players and antagonists, will show the number of ghosts orbiting them, if there are any.
Previews:
Why It's Good For The Game
The current Orbit menu is infuriating to use. It's not even in alphabetical order so you have to just scroll through to find who you want to orbit, or just keep pressing the first initial until you're lucky. It also treats objects most players don't care about (such as the cleaner bots) alongside more important figures such as alive players.
Changelog
🆑
add: Added a new organized orbit menu.
/:cl: