New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] The Portable Chemical Mixer #51964
Conversation
Will plastic bottles fit? I really miss plastic bottle being a beaker subtype. |
This must require an anomaly core to make. Pick whatever one suits you best that isn't used See: https://hackmd.io/@tgstation/r1tzxpwPL Available types:
|
Don't you think 50 beakers is a bit excessive |
O man I really like your plans for anomaly cores. According to your design doc, other items that should require cores are phazon, beam rifle and BoH. |
Anomaly core for chem bag with interface is too much! |
What amount do you think is acceptable? |
It's not a request it's a precondition for merge and it doesn't need to share the same core as the BoH |
What is the reasoning? I don't understand. It's not BoH or phason, it's just a tool for mixing chems, like chem bag with ui. |
It's a portable chem mixer, it's undeniably useful and powerful, I want to be able to precisely control how many of them exist in the game in a round, and the anomaly system allows me to do that. |
It can not produce chemicals, you still need dispenser to do that. |
@ExcessiveUseOfCobblestone your thoughts on this? We removed its ability of producing chems from thin air. We made it not purify chemicals. |
I can see that, but it's still a portable mixer, nothing like this has existed before, so I am not going to take any chances. Lot easier for people to swallow the removal of the anomaly core requirement post merge if we find it's not actually strong/utility than it will be to add it on after the fact. Easiest route for me is to require it now and review it after a period of use. |
My problem with anomaly cores is that it makes you dependant on R&D. |
technically also cargo, but you should be able to curry favour with both. |
Compromise: it could start with a low beaker count (5 maybe?) and if you want more you need to upgrade it with an anomaly core and maybe better matter bins or some other limited resource? I feel locking it completely behind anomaly cores will render it undesirable and you won't get much feedback on whether it's OP or not since no one will use it. |
Listen, I'm open to changing it after it's been in the game and had some time to play out, but I'm aiming to over shoot on initial restriction because in my experience it's a lot easier to buff something after the fact than it is to nerf it. |
…nto portable-mixer # Conflicts: # tgui/packages/tgui/public/tgui.bundle.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have generated new variables/procs/defines without proper documentation for the autodoc to work.
Please click here for a guide on how to properly document these items.
I have added the documentation to my best ability, I hope this meets all the requirements |
…nto portable-mixer # Conflicts: # tgui/packages/tgui/public/tgui.bundle.js
…nto portable-mixer # Conflicts: # tgui/packages/tgui/public/tgui.bundle.js
…nto portable-mixer # Conflicts: # tgui/packages/tgui/public/tgui.bundle.js
I'm going to run a poll sometime this week asking people if they have experienced this yet and what they think. If people are generally positive we can lift the core requirement |
Thank you, I am interested in their feedback as well 👍 |
* sets EOL to LF * Normalize all the line endings * Sets vscode to default to unix / LF line endings (tgstation#52273) * Adds ignored commit file for git blame (tgstation#52344) * Adds ignored commit file for blame * contributing.dm * Changes ignored blame commit to an accurate one * [READY] The Portable Chemical Mixer (tgstation#51964) * New device: Portable Chemical Mixer * Added entries to the tech web and the medical techfab * removed unused icons for chemical cartridges * small bugfix in build_path of portablechemicalmixer * changed description and added info message * Added newline * Added a functioning newline * Added a vortex anomaly core requirement * Replaced old sorting method with sortBy * Updated tgui.bundle to work with the latest code changes * Added documentation to all variables and procs * Small fix in wording * Removed all non-class level documentation * Updated tgui.bundle for the newest offical code version * Updated tgui.bundle to work with the newest code version * Updated the tgui.bundle to work with the newest version * Arconomy Productions presents: The Bounty Board (tgstation#51449) * Startwork * stopwork again * AGAIN. * Good place to call it for now * Startwork but I actually put some work in * The left list doesn't work, stop for now. * God remind me to squash these commits later. * Well, I think I can safely say I have actual work done now * The post-Brisk iced tea patch. * God damnit nothing works I hate this worl * Good place to stop, stuck in a chronic error state * I take it back now I need to sleep jesus god * I am grown POWERFUL in my dispair * FINALLY READY TO PR. * Request order swap * Update and tgui recompile * Adds a kiosknet, so adding a new bounty alerts all the bountyboards * Renames file, attempts to port to modular app too because fuck my life * Fuckin feature creep I tells ya * Removes an unused proc * Rebuildin * Hopefully updates tgui and fixes an easy runtime * Finishes updating/conflicts * Mapmerges my shit. * Rebuilds tguiiiiiiiiiiii * Updates tgui * Updated once more * merge conflict fixaroni * God I wish that I had a game I was dedicated enough to finish in a single setting * Rebuild of PR: You will (Not) compile * Cobby's changes and Anturk's Suggestions. * Should probably prevent a runtime. * Rebuilds TGUI. * Lets not delete my own files please god * Style's changes * ALL the warriors * What if I didn't delete ZX's app sprites again * Start workin on a text component later * Makes some code suggestions, doing it all in UI will kill me * tgui update * DNM until I get this gosh darn text working. * The changes that I need afaik * And a tgui rebuild to boot * When that program datum spoke to me, I felt that. * Makes changes to text input sanity, Pray * By god I think I've cracked the code. * Had no idea you could atomize UIs like that, this is revolutionary * Spaces Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * tgui: MIT License (tgstation#50969) * MIT license headers * various tweaks - Tweak jsdoc headers a bit - Use an old-school format with SPDX-License-Identifier for SCSS - Add headers to tgui dmcode * Simplify the license section * Rebuild tgui, small tweaks Co-authored-by: ZeWaka <zewakagamer@gmail.com> About The Pull Request All relevant source code now contains copyright headers, that explicitly assert copyright and license for every file. This has been done to prepare TGUI for wider adoption. Goon station devs are interested in using TGUI, and hopefully this will result in a nice collaboration and improvements to both codebases. The following files were relicensed under MIT: code/controllers/subsystem/tgui.dm code/modules/tgui/*.dm tgui/**/*.js tgui/**/*.scss The following files were kept untouched: tgui/packages/tgui/interfaces/**/*.js tgui/packages/tgui/styles/interfaces/**/*.scss Project is still basically AGPL-3.0 under /tg/station's parent license (with added MIT texts), but allows importing MIT code into MIT-compatible codebases. * Adds Syndicate tablets, replaces the pinpointer used by Nuke Ops (tgstation#51386) * Synux * cleanup * I bet this merge conflicts we hate tgui.bundle * extra bits * Syndix * small fixes * Summary (required) * this linter drives me up the wall * final touchups * Forgot this thing * fixes and tweaks * Replace BSQL with rust-g, paramaterize all queries (tgstation#51255) cl refactor: BSQL has been replaced with rust-g, improving SQL reliability and safety. /cl Queries were parameterized as much as possible. Careful code read by someone else also versed in SQL would be a good idea. Things seemed fine spot-testing roundstart, library, bans, and polls, but more stress-testing may be useful. Also updates rust-g to v0.4.5: Improved Linux .so detection Perlin noise functions Also updates Travis script to bionic. * tgui: Jukebox (tgstation#52014) * Jukebox TGUI * Line endings * Review fixes * tgui: Tachyon-Doppler Array (tgstation#51568) * Doppler array UI without actions * TachyonArray UI * Final version * TGUI fixes * tgui: Biogenerator (tgstation#51022) * First version * Pre-release version * Cleanup * Review fixes and finishing touches * Updates vend-a-trays to have a unique UI, improves accessibility. (tgstation#51931) * Initial commit, updates trays into 2020 * Adds vend-a-trays as a service machine, without it being a machine. * Replaced the mapped vend-a-trays with service unique versions. * "YoUr BuIlD DiFfErS fRoM mAsTeR" * Removes {}s from img, workin on the other part * All my homies recompile on merge conflict * Fixes end of line because honestly there must be no god on this green earth * hopefully this isn't too excessive. * How's this? * Applies Anturk's Confirm suggestion. * Shipped, workshopped with style a bit * Alright that's probably enough fiddling for now * Rebuilds. * html moment (tgstation#51956) * Turret Control TGUI (tgstation#51777) * tgui: Portable Turret (tgstation#51840) * Turret TGUI * Review fixes Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> * Review fixes 2 * Finishing touches Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> * [Ready] Skillcapes II: Revenge of the broken github: A Skill Menu Special: New Sprites Edition (tgstation#50656) * 10K hours 60,000 minutes hahah sure if you want a trailing newline i can do that default cloak gets default skill lazy list and no equip good necessary ig Update code/datums/skills/_skill.dm Co-Authored-By: nemvar <47324920+nemvar@users.noreply.github.com> Update code/datums/skills/gaming.dm Co-Authored-By: Angust <46400996+Angustmeta@users.noreply.github.com> WIP PDA skill monitor program hacky fixes till i refactor skills refactors skills a bit, adds admin skill edit menu If you have a failing, it's that you're always demanding perfection ...IF you have a failing i think that's it for the admin skill manger appeases lord flord bruh level names FUCK!! unga Update code/modules/vehicles/vehicle_key.dm Co-authored-by: Rohesie <rohesie@gmail.com> Update code/modules/admin/topic.dm Co-authored-by: Rohesie <rohesie@gmail.com> Update code/modules/admin/skill_panel.dm Co-authored-by: Rohesie <rohesie@gmail.com> Update code/modules/admin/skill_panel.dm Co-authored-by: Rohesie <rohesie@gmail.com> Apply suggestions from code review frick Co-authored-by: Rohesie <rohesie@gmail.com> EOL and dumb spaces more rohsie bait tgui: Query Windows Registry for BYOND cache directory hell yeah brother update tgui and dmi CLRF and bat file typo ig * tgui and new janicloak that i accdiently changed on another branch * jani * gamer cloak * trim trailing whitespace * tgui * bruh * variable renaming * Tiny skill neatness tweaks (tgstation#51309) * minor neatness tweaks * topic * tgui: Fix Seed Extractor and update to tgui (tgstation#50928) * Initial Seed Extract Update Updates the seed extractor to work and the ui * Damnit, forgot to run webpack * Removed the logger and fixed toTitleCase You would think working on a PR for 14 hours you would remember the small stuff * Fixed the wierd Table.cell spacing. I have no clue how that got there. * Trying to fix some webpack issues Travis is reporing a dffrent webpack id so its failing? did a yarn update and repack * forgot the lock file * Clean up the code, final rebuild * Deleted yarn.lock in the root Co-authored-by: Style Mistake <stylemistake@gmail.com> * tgui 4.0 (tgstation#52085) * tgui 4.0 hyper squash * Upgrade dependencies * tgui 4.0: Reduced Logging (tgstation#52280) * CDN asset scaffolding: generated urls. * tgui: Fixes assets, CDN support (tgstation#52321) * tgui: Better asset code, CDN support * Rebuild tgui * µ-fix * Fix sending of updates (tgstation#52282) tgui: Fix sending of updates for non-interactive but observable UIs. * tgui: Scalable UI (tgstation#52283) * tgui: Scalable UI * ProgressBar scaling fix * Rebuild tgui * tgui 4.1 version bump (tgstation#52408) * Fix bluescreens due to a localStorage bug in IE11 (tgstation#52356) * 2spooky now no interact with tgui * tgui: Telecommunications UI (tgstation#52357) * Telecommunication Machine UI Overhaul This replaces the UI of the tcomm machines from the old html system to the new TGUI system. * Telecommunication Machine UI Overhaul This replaces the UI of the tcomm machines from the old html system to the new TGUI system. * Updated TGUI.Bundle * Housekeeping Added final newline, shortened value-values, spread out boxes, renamed Tcomm to Telecomms, and made the backend use full numbers while the frontend used decimals. Thanks for the feedback, y'all. * Removes forcesay on attack (tgstation#52341) * Fix pulsing the power wire shocking you repeatedly unless you close tgui (tgstation#52541) * Fixes tgstation#52538 * Allow those with insulated gloves to mess with airlocks still * Fix not being able to interact with insulos * Fix style qualms * Add shock immune to should_electrocute * updates turdis to not use BSQL * Bumps minimum savefile version, fixes some forgotten hotkeys (tgstation#52312) * Bumps minimum savefile version, fixes some forgotten hotkeys * Removes job flags * Fixes keybind fuckup (tgstation#52406) * Fixes keybind fuckup * Right fix * improved savefile versioning by MSO, cherrypick too fucked to want to fix * Adds Runechat Subsystem - Deprecates Use of Timers for Runechat (tgstation#52425) * first pass * one wacky dot * documentation * we're the garbage man now * doc update * couple of bugs never hurt nobody * Gun locker now uses a radial menu (tgstation#52506) * Gun Locker Radials * Smaller radius * Review fixes * Update code/game/objects/structures/guncase.dm Co-authored-by: Rohesie <rohesie@gmail.com> * Review fixes 2 * Apply suggestions from code review Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Rohesie <rohesie@gmail.com> * Drone radial menus (tgstation#52618) * Patching the DMAPI (tgstation#50862) * DMAPI 5.2.2 (tgstation#51100) * Update DMAPI to v5.1.0 * Add more event handlers * Patch * DMAPI 5.2.0 * DMAPI 5.2.1 * Add missing trailing new line * Fix the version we print after updates * 5.2.2 * Add handler for TGS_EVENT_WATCHDOG_SHUTDOWN (tgstation#51665) * Add handler for TGS_EVENT_WATCHDOG_SHUTDOWN Thought I did this... * speling * Gotta go fast * Update TGS DMAPI to 5.2.3 (tgstation#52608) * Fixes cinematics for widescreen. (tgstation#52464) * Simple mob AI wakes up less (tgstation#52228) There's no reason to wake every mob on the Z level when we can simply wake up only those nearest to the mob In theory we could even not do this at all, but there would be a few seconds delay before the idle automated actions ran and the AI wokeup anyway * SimpleMob AI now enters IDLE state when a client enters a z level This occurs if no client was on the z level before they moved in (implying the AI could have turned off) If they are within a certain distance we also ask them if they want to move from IDLE to fully awake and targeting * Remove instances of `var varname` in dm code * People drift through z levels properly now (tgstation#52686) * Adds more documentation to TGS chat funcs (tgstation#52601) * Fix using `tag` instead of `custom_tag` in send2chat (tgstation#52675) * Adds more documentation to TGS chat funcs * Fix using `tag` instead of `custom_tag` for chat channels * Make new game notifcation message clearer * Adds screen_glass.dmi (tgstation#52691) transparent hud * Replaces modular computer card eject verbs with UI buttons (tgstation#52489) * Replaces mod-CPU card eject verbs with UI buttons * ? * Try to replace light overlay to vis_contents (tgstation#52389) * Try to replace light overlay to vis_contents * move glowybit creation in Initialize * ups * change mutable_appearance to SSvis_overlays * set right settings * Adds reference tracking (tgstation#51467) About The Pull Request Adds extools-powered reference tracking. Includes a couple procs that retrieve the back and forward references of a datum - Back references let you see what is referencing your object and potentially preventing it from garbage collecting, and forward ones show you what your object in turn references. Also made a cool GUI to inspect and follow these references. The tracking adds some overhead to all variable sets and list operations. Init time is increased by ~15%. I haven't actually benched it so it might impact the actual game less. Why It's Good For The Game no lagging caused by hard dels scanning the entire planet (once coders fix them) * Reference tracking (tgstation#52403) * ref tracking * legacy * legacy procs * fixes * tweaks * clarity comments * wth * Adds an atmos debugging tool and excited group visualizer (tgstation#52395) * Adds an atmos debugging tool and excited group visualizer * rebuild moment * yarn install -> yarn run build * Sigh * Fixed UI, did not test, needs a rebuild. * Proper flexing * Adds varied colors, improved ui courtusy of stylemistake: * Fixes a runtime, updates tgui * added superconductors, cleaned up some shitcode, removed a clashing color * Woop * Speed * rebuild * Adds a tick count * begone auto-update * color defines * rebuild moment * color improvements, fixes updating * adds another preprocesser define to handle showing max shares in the ui * test of application system? * patches up some display issues, allows for smooth flowing from one group to another * overlay-ified * client testing * dmi moment * plane master * it fucking works * size change * passthrough * rebuild moment * adresses review concerns, toggles active turf vis on when testing Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * fixes the poll menu from breaking the join menu when the DB is misconfigured * Adds Documentation for Entire Timer Subsystem With Minor Refactors (tgstation#52415) * temp * cleanup * more * Revert "more" This reverts commit 8707bfe. * less is better * some documentation * almost there * we did it * words * better words * Update code/controllers/subsystem/timer.dm Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> * Update code/controllers/subsystem/timer.dm Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> * whitespace Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> * Revert "Adds an atmos debugging tool and excited group visualizer (tgstation#52395)" This reverts commit 5a17005ffef89f2d116b157397daad8c819e2af5. * rebuild TGUI * fixes some TGUI interfaces * rebuilding FUCKING TGUI * fixes prefs * more fixes * Hitscan Emitters 2 Electric Boogaloo (tgstation#375) * Emitters 2 Electric Boogaloo * margularize it in waspstation folder since Toast wont 👀 Co-authored-by: Shayne Fitzgerald <robotech417@yahoo.com> Co-authored-by: Shayne Fitzgerald <shaynefitzgerald0@gmail.com> * final runtime fixes * possible ORM fixes * misc runtime fixes * credits fixes and general runtime remedies * fucking undeleted queries Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com> Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com> Co-authored-by: LordVollkorn <66637090+LordVollkorn@users.noreply.github.com> Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: zxaber <37497534+zxaber@users.noreply.github.com> Co-authored-by: Tad Hardesty <tad@platymuus.com> Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Co-authored-by: Arkatos <arkatos1234@gmail.com> Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: MrDoomBringer <mrdoomboyo@gmail.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: WarlockD <warlockd@gmail.com> Co-authored-by: MrStonedOne <kyleshome@gmail.com> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: WondaMegapon <wondamegapon@gmail.com> Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: oranges <email@oranges.net.nz> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Fhaxaris <Chrisamcculler@gmail.com> Co-authored-by: Dennok <Deneles@yandex.ru> Co-authored-by: MCHSL <56649176+MCHSL@users.noreply.github.com> Co-authored-by: Shayne Fitzgerald <robotech417@yahoo.com> Co-authored-by: Shayne Fitzgerald <shaynefitzgerald0@gmail.com>
About The Pull Request
Adds the Portable Chemical Mixer to the game, an item that can be worn on the belt slot and dispenses and mixes chemicals. This item does not produce reagents on its own. Every single reagent has to be supplied to it. Using a screwdriver, the player can open the device to place in a maximum of 50 beakers, similar to the chemical bag. When closed and in usage, each beaker will appear as a usable button that states the primary reagent of said beaker, along with its remaining units. If a beaker contains more than one reagent, its respective button will dispense all of them in equal amounts. (In Cobbys words: The gunk you put in is the same gunk you get out. -> Your individual beakers dont get filtered.)
The Portable Chemical Mixer is printable at the Medical Techfab and starts out empty.
Why It's Good For The Game
This item offers an alternative style of gameplay that gives Chemists the incentive to leave their pharmacy and interact with other departments closer, better fulfilling the needs of e.g. the kitchen, botany or the janitor while not having to constantly run back to their dispensers. In the same way, Chemists are now more mobile in finding and receiving reagents (e.g. from Botany). The Portable Chemical Mixer is designed to be future-proof for any possible changes regarding Chemistry.
Changelog
🆑 Jay Smith & Michael Trauf
add: Portable Chemical Mixer (Requires a vortex anomaly core to activate)
imageadd: Unique sprites for the Portable Chemical Mixer
code: Added Portable Chemical Mixer to the Medical Techfab
/:cl: