Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bounty] Mutative Crossbreeds #52211

Closed
wants to merge 5 commits into from

Conversation

EdgeLordExe
Copy link
Contributor

About The Pull Request

Adds all mutative crossbreeds! I had to change a few of them, but majority work exactly like the ones on the wiki.

Changes from wiki:

  • Mutative Industrial sheets only work on girders

  • Mutative Yellow is not infinite but is instead a 300 stack of super compressed coil

  • Mutative Rainbow instead provides a one use holoprara injector with a single option: Power Farmer! It works like weaker support holopara but it's attacks feed slimes!

Why It's Good For The Game

Variety is good, and since i know cobby is gonna cockblock this pr, just leave a comment saying what parts you want changed about xenobio for this to be mergable.

Changelog

🆑
add: Added mutative Crossbreeds
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts Sprites A bikeshed full of soulless bikes. and removed Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts labels Jul 13, 2020
@tmtmtl30
Copy link
Contributor

i'm not cobby, but in terms of "what parts [I] want changed about xenobio, i'd say tearing out all the fucking crossbreeds and scattering their abilities to the winds between different jobs and antagonists. a single job shouldn't have the breadth of abilities it does, most fucking antagonists can't come close, it's utterly bizarre

@EdgeLordExe
Copy link
Contributor Author

blame fel for creating this system

@Doosteroni
Copy link

Mutative Rainbow instead provides a one use holoprara injector with a single option: Power Farmer! It works like weaker support holopara but it's attacks feed slimes!

I feel like no one would want to play this

@XDTM
Copy link
Contributor

XDTM commented Jul 13, 2020

It's literally a nonantag holoparasite, with 2.5 all-heal per hit and 15 damage punches if i read the code correctly. Even without those it still has the ability to drag the owner out of danger if incapacitated.

And yeah, crossbreeds are already a massive dump of random, redundant, poorly balanced effects which could really use a rework if not outright removal.

@Doosteroni
Copy link

I read it as it only feeds slimes and doesn’t do damage

@OverlyGeneric
Copy link

Xenobiology is a mistake and should be reworked like botany.

It's always been tip-toeing between rewarding and tedious with the payoff being "lol free antag & op abilities!!!1" that rivals mining which is its own separate game.

Hell, you rarely get to do anything with actual aliens despite the station being connected to lavaland. Seriously, give some love to actual aliens instead of these anime boogers.

@evilcyborgmrt
Copy link

Or give all jobs the breadth of content that xenobio has

@@ -363,3 +363,50 @@
/datum/status_effect/antimagic/on_remove()
REMOVE_TRAIT(owner, TRAIT_ANTIMAGIC, MAGIC_TRAIT)
owner.visible_message("<span class='warning'>[owner]'s dull aura fades away...</span>")

/datum/status_effect/lovers_hug
id = "Loner's Hug"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be "Loner's" or "Lover's"?

protected = hugged

/datum/status_effect/lovers_protection
id = "Loner's protection"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be "Loner's" or "Lover's"?

Copy link
Contributor

@ATH1909 ATH1909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, uh, that's the review. I left out grammar concerns because they'd bloat this review too much, but PLEASE get someone to proofread your descriptions before this PR gets merged (some of the, ah, "flawed" descriptions from the heretics PR actually made it into the game, and it's gonna be a bitch to find 'em all and fix 'em).

also, to clarify, the cost of a crossbreed is technically 10 slime cores+1 slime, but I'm counting that slime as being equal in value to a single slime core for convenience's sake.

Comment on lines +103 to 105
if(!unpleasant)
return
addtimer(CALLBACK(L, /mob/living/carbon.proc/vomit), 20)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(!unpleasant)
return
addtimer(CALLBACK(L, /mob/living/carbon.proc/vomit), 20)
if(unpleasant)
addtimer(CALLBACK(L, /mob/living/carbon.proc/vomit), 20)

Comment on lines +52 to +53
melee_damage_lower = 15
melee_damage_upper = 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
melee_damage_lower = 15
melee_damage_upper = 15
melee_damage_lower = 10
melee_damage_upper = 10

copy+pasted code detected


/obj/machinery/photocopier/slime
name = "Slime photocopier"
desc = "Used to copy important documents and anatomy studies, it can run on slime jelly!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wanna mention that it can still run on normal toner

. = ..()
create_reagents(100, OPENCONTAINER)

/obj/item/slime_iv/MouseDrop(mob/living/target)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might wanna make it also possible to attach this to someone by bopping them with it, with maybe 5u of it injecting instantly (like a hypospray), to reduce jank

return PROCESS_KILL

if(reagents.total_volume)
reagents.trans_to(attached, 5, method = INJECT, show_message = FALSE) //make reagents reacts, but don't spam messages
Copy link
Contributor

@ATH1909 ATH1909 Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so you're aware, as far as I can tell, this slime IV can pierce hardsuits

color = "#00ff15"
block_chance = 10

obj/item/tank/internals/emergency_oxygen/slime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk dude, this kinda already overlaps with the rebreather crossbreed item, which just straight up makes you not need to breathe


/obj/item/clothing/under/suit/blacktwopiece/slime
name = "slime suit"
color = "#00ff15"
Copy link
Contributor

@ATH1909 ATH1909 Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color = "#00ff15"
color = "#00ff15"
species_exception = list(/datum/species/golem)

I'd also suggest making this suit come with a matching set of golem-compatible (and/or digitigrade-compatible?) shoes, and making the item spawner for this suit reusable (with a cooldown, of course), so that we can at least PRETEND that someone is going to blow 11 slime cores on something they can buy from a vending machine for a handful of credits (plus, it'd be pretty cool if I could dress up my golem army in snazzy suits).

also, making these suits golem-compatible would finally allow us to give golems the medals that they truly deserve. hey, actually, a crossbreed that just makes a medal (that can be pinned even on people who aren't wearing/can't wear jumpsuits, like borgs and simplemobs?) might be a pretty good idea for a "filler" crossbreed... maybe replace one of the weaker crossbreeds (like the one that makes a 0 force knife) with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also recommend maybe throwing in some cool shades along with the golem shoes, as then this'd have a reasonable purpose for both powergamers (for making your golem army flashproof without needing welding gear) and people who just want to vibe with their classy golems.

/obj/item/stack/medical/slime_patch
name = "slime patch"
singular_name = "slime patch"
desc = "Potent patch containing smart chemicals, able to detect and fill out even inorganic damage."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wanna change this description to not mention chemicals and change the name to not use the word "patch", as the term "patch" in ss13 chemistry usually refers to chem patches, and that could cause some confusion

also, if possible, could you allow these to heal golems and skeletons, if they (and/or normal sutures?) can't heal them already?

colour = "black"

/obj/item/slimecross/mutative/item_spawner/lightpink
item_spawner = /obj/item/kitchen/knife/slime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dude just print a normal knife from an autolathe or buy one from a vending machine why the fuck would you spend 11 slime cores on a glorified PLASTIC KNIFE

colour = "light pink"

/obj/item/slimecross/mutative/item_spawner/adamantine
item_spawner = /obj/item/claymore/slime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has some use as a weapon with a decent force value, but, like, the rainbow knife costs ONE core and does only 3 less damage (admittedly, it'll sometimes roll oxyloss as its damage type, so ehhhhhhh).

maybe give this claymore a wound_bonus or something?

@optimumtact
Copy link
Member

xenobiology is on a path to destruction

@IndieanaJones
Copy link
Contributor

Crossbreeds were a mistake

@optimumtact
Copy link
Member

also there's no point in reviewing this ATHATH, there's very little chance it will get merged

@ShizCalev ShizCalev added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 20, 2020
@ShizCalev
Copy link
Member

conflict

@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 27, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Aug 4, 2020
@ExcessiveUseOfCobblestone
Copy link
Contributor

crossbreed PRs are getting BTFOd, I don't have someone who I can trust to give good balance insight on xenobio nor am I a fan of the crossbreed approach to xenobio.

It should be about capturing monsters and morphing them to usable entities (slime cow slime cow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Sprites A bikeshed full of soulless bikes. Stale Even the uncaring universe rejects you, why even go on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet