Airlock Seals 2: I'm dumb and a fool edition

[Jimmius]

About The Pull Request

This is basically just an exact remake of #52595 except without all the bumbling fuckups I made due to being dumb. Mega thanks to Rohesie for helping me, considering literally all of the problems were ones I made for myself (the merge conflict was literally due to a missing cricket bat icon). In conclusion, I'm dumb.

Adds door seals to the game, inspired by the ones used in Alien Isolation and SOMA. Trivially easy for a human to remove, but makes it a nightmare to try and smash through if you're an alien, an evil robot, or don't have hands. I also slightly changed how airlock reinforcement works, as now there are two ways to increase the integrity, the previous way of just resetting the max_integrity after the removal of the plating wouldn't work.

Why It's Good For The Game

Makes it harder for aliens, cyborgs, and simplemobs to get into places the crew don't want them, while being easy to remove by humans.

Changelog

🆑
add: Adds door seals to the game, printable at engineering and security lathes after they've been researched. Makes airlocks much harder to smash down if you can't remove them.
tweak: Slightly changed how bonus health to an airlock works
/:cl:

[actioninja]

The main issue I take with this from a design standpoint is that there's zero trade-off to them. There's no real reason to not just put these on literally every door and provide pretty objective advantages.

[ATH1909]

The main issue I take with this from a design standpoint is that there's zero trade-off to them. There's no real reason to not just put these on literally every door and provide pretty objective advantages.

Do you have to take off the seal every time you need to go through the door, then put it back on the door behind you?

[Jimmius]

Do you have to take off the seal every time you need to go through the door, then put it back on the door behind you?

Yes, there's a 3 second seal time and a 2 second unseal time (I made the unseal shorter so you're always losing ground if you're trying to use these in a chase against a human), so you'd have to wait 5 seconds after doing this to each door. I could up the times to make it more arduous to both apply and remove, if you think it's too quick. Something like 7 seconds seal, 2 seconds unseal (I don't want a long unseal time because that sort of gives them a use for delaying human enemies, which is not the goal) is probably long enough to put people off sealing literally every door on the station.

[tralezab]

Yeah, I would only put these on low traffic, high security or very high danger areas. maybe nuke ops? I dunno

[actioninja]

I forgot to ever comment again but yeh I actually just completely misunderstood the feature, it actually seems fine.

[cacogen]

This will make me play Alien: Isolation finally. Fuck aliens and fuck simple mobs.

[anconfuzedrock]

wait a second aren't airlock seals basically reinforced tables/ welding doors
gotta be human to climb a table

[Jimmius]

sort of, a lot of the things this is supposed to counter can just walk over tables anyway, like spiders and xenos and what have you. It also doubles the integrity of the airlock, which welding doesn't do.

[Timberpoes]

Geez laweez. Sorry this has been hanging so long. I've now assigned myself to it.

I'll see about getting this merged as soon as. It's definitely overdue and I'm not sure how you slipped under our radars.

Current triage is as follows:

• Code review -> Minor notes requesting improved documentation.
• Icon review -> Just noticed the Twaticus seal of approval.
• Have you tested this? -> While the above is happening, you can help expedite the process by explaining any testing you've done to be sure this feature works as intended.
• Mergies -> When the above 3 steps are completed, we'll get this in.

[Jimmius]

Things wot I have tested so far:

1: I have used the seal on every single airlock currently in the game (even the double airlock used in ruins). It works and displays correctly, and I can remove it from all of them.
2: Non-Cultists can safely remove this from Cult airlocks without getting bounced, so culties don't get a free lunch (bumping will still bounce).
3: If an airlock with safety unlocks is unpowered and sealed, clicking will remove the seal (you can unlock the safety system once it's removed).
4: The seal keeps the door closed during emags and staff of doors, and blocks attempts to open from the AI and Cyborgs, as well as pulsing the open wire.
5: Everything works fine if you seal AND reinforce and airlock, in either order.

If there's any other edge case interactions that I can't think of, just say and I'll test them.

[Timberpoes]

Suggested change

	* or try it's safety lock while it's sealed
	* or try its safety lock while it's sealed

[Timberpoes]

Yes, I am being that pedantic! Muahahaha.

He, his. She, hers. It, its.

[Jimmius]

fuck, how did I not notice this