Slightly optimize shroom spreading code #53652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimumtact
commented
Sep 12, 2020
| if(spreadsIntoAdjacent || !locate(/obj/structure/glowshroom) in view(1,earth)) | ||
| possibleLocs += earth | ||
| CHECK_TICK |
There was a problem hiding this comment.
You will note I have removed this.
If this causes server lag I will delete glowshrooms
optimumtact
force-pushed
the
shroompocalypse
branch
from
faabdc0
to
78e309a
Compare
We did a number of things here, first we collect the potential turfs for the view call in a single pass, not once per yield run. Second we dont' run a second view(1) on every single potential turf, instead we try to randomly pick a turf 3 times during yield phase and check the view then. If we fail to find a potential location then we bail out of that yield phase. This is a tradeoff between processing time spent finding locations and the chance that the glowshroom fails to spread Finally, we have maximum limit on how many times a glowshroom fails to spread, if it fails to spread at least 5 times over any iteration, it stops processing completely. As a bonus, the timers have been made unique, so we don't accidentally generate multiple timers for a single shroom, other than the two it already needs. This code would benefit from being a seperate subsystem and grouping, generations of the plants together as a single ticking entity and just spreading from selected edge plants. However I don't particularly feel like plumbing that together, so this will suit for now.
optimumtact
force-pushed
the
shroompocalypse
branch
from
78e309a
to
a261434
Compare
Timberpoes
requested changes
Sep 13, 2020
ExcessiveUseOfCobblestone
added
the
Test Merge Candidate
SpaceManiac
changed the title
SpaceManiac
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some recent lag events on the servers caused by the timer subsystem jamming
up with glowshroom timers. I whined about this but nobody did anything so
There are a few changes here, first we collect the potential turfs for
the view call in a single pass, not once per yield run.
Second we dont' run a second view(1) on every single potential turf,
instead we try to randomly pick a turf 3 times during yield phase and
check the view then.
If we fail to find a potential location then we bail out of that yield
phase. This is a tradeoff between processing time spent finding
locations and the chance that the glowshroom fails to spread
Finally, we have maximum limit on how many times a glowshroom fails to
spread, if it fails to spread at least 5 times over any iteration, it
stops processing for spread completely.
As a bonus, the timers have been made unique, so we don't accidentally
generate multiple timers for a single shroom, other than the two it
already needs.
This code would benefit from being a seperate subsystem and grouping,
generations of the plants together as a single ticking entity and just
spreading from selected edge plants. However I don't particularly feel
like plumbing that together, so this will suit for now.