Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove fusion from reactions, add hypertorus fusion machinery #54379

Merged
merged 86 commits into from Nov 18, 2020
Merged

[WIP] Remove fusion from reactions, add hypertorus fusion machinery #54379

merged 86 commits into from Nov 18, 2020

Conversation

Ghilker
Copy link
Contributor

@Ghilker Ghilker commented Oct 13, 2020

HFR guide Updated with more infos and tips

About The Pull Request

This PR removes fusion from reactions.dm and add the Hypertorus machine and its new and improved fusion reaction (results may vary).
To do:

  • Barebone PR
  • Machines working
  • Machines working well
  • Sprites
  • Barebone fusion code
  • Refined fusion code
  • Advanced fusion code
  • Integrity
  • Damage alerts
  • Sounds
  • Basic Gas Interactions
  • Advanced Gas Interactions
  • PR need review
  • PR finished
    (might add more along the way)

Why It's Good For The Game

Fusion is one of the most costly reactions from the atmos system, is one of the most complex and yet most simple ones; this will move fusion inside a buildable machine and it will allow a degree of complexity that can't be done inside react()

Changelog

🆑
del: remove fusion from reactions
add: hypertorus fusion machine
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Removal This was too fun, too fun! I'm turning this feature around Sprites A bikeshed full of soulless bikes. Work In Progress labels Oct 13, 2020
@trerri
Copy link

trerri commented Oct 13, 2020

Ok Ghilker, now you have no excuse not to make this realistic proton chain fusion with ions, deuterium, and all the fucking elements up to iron.
The excuse for it being so powerful is bluespace, so no "But we can't fuse up to iron on Earth!".

@optimumtact
Copy link
Member

I hope you're planning to get some sprites

@Ghilker
Copy link
Contributor Author

Ghilker commented Oct 13, 2020

I hope you're planning to get some sprites

Yep, those are placeholders

@tgstation-server tgstation-server added the Map Edit Thank you for your tile-placing service. It's always appreciated. label Oct 14, 2020
@Ghilker
Copy link
Contributor Author

Ghilker commented Oct 14, 2020

map changed for debugging purposes

@tgstation-server tgstation-server added Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts UI We make the game less playable, but with round edges labels Oct 14, 2020
@Ghilker
Copy link
Contributor Author

Ghilker commented Oct 14, 2020

need help on the tgui this is what i have (fugly i know)
aaa
how do i make the numbers not go with all those zeros but just go sci notation from 1e6? and how do i make them colored better?

@Dennok
Copy link
Contributor

Dennok commented Oct 14, 2020

@Ghilker Try this "[round(A / 10**round(log(10,A)),0.1)]e[round(log(10,A))]"

@Ghilker
Copy link
Contributor Author

Ghilker commented Oct 14, 2020

i can't make that work :(

@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Oct 14, 2020
@optimumtact
Copy link
Member

@stylemistake what formatting options exist for the numbers in tgui?

@stylemistake
Copy link
Member

stylemistake commented Oct 14, 2020

For joules, there is a formatSiUnit function in ../format.js module, which is a perfect fit for these sciency things. For kelvins... Well, you can duplicate formatSiUnit and make it print 12.34 × 10³ K, where 10³ replaces SI prefixes, shouldn't be too hard to implement, and it would look really nice.

@tgstation-server tgstation-server added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 14, 2020
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 14, 2020
@tgstation-server tgstation-server added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 16, 2020
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 16, 2020
Copy link
Member

@stylemistake stylemistake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have committed these suggestions directly, but I was busy with work. I cannot merge it in this state.

tgui/packages/tgui/interfaces/Hypertorus.js Show resolved Hide resolved
tgui/packages/tgui/interfaces/Hypertorus.js Show resolved Hide resolved
tgui/packages/tgui/interfaces/Hypertorus.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Hypertorus.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Hypertorus.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Hypertorus.js Outdated Show resolved Hide resolved
@tgstation-server tgstation-server added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 18, 2020
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 18, 2020
Copy link
Contributor

@EOBGames EOBGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map changes seem alright- is there enough free space on delta to build one of these things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. Removal This was too fun, too fun! I'm turning this feature around Sound Oh god my ears, they bleed, did you normalise the volume? Sprites A bikeshed full of soulless bikes. UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet