Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Scarcity 3 - The five minutes nerf #56999

Closed
wants to merge 9 commits into from
Closed

Internal Scarcity 3 - The five minutes nerf #56999

wants to merge 9 commits into from

Conversation

Ghilker
Copy link
Contributor

@Ghilker Ghilker commented Feb 17, 2021

About The Pull Request

This PR makes the emergency tanks smaller, lowering the time for one tank to drain to 5/6 minutes instead of the 14 it currently is.

Need to add docs

Why It's Good For The Game

Having a small emergency tank last 14 minutes is awful balance. Atmos players now have more incentive to fix the air around the station.

Changelog

🆑
balance: Due to budget cuts, we are making all emergency tank smaller, so please seek help from your fellow atmosians workers.
/:cl:

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Feb 17, 2021
@Fikou Fikou added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label Feb 17, 2021
Copy link
Member

@Mothblocks Mothblocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making no statement on the change, just the code itself.

code/modules/clothing/masks/gas_filters.dm Outdated Show resolved Hide resolved
code/modules/clothing/masks/gas_filters.dm Outdated Show resolved Hide resolved
code/modules/clothing/masks/gas_filters.dm Outdated Show resolved Hide resolved
code/modules/clothing/masks/gas_filters.dm Outdated Show resolved Hide resolved
code/modules/clothing/masks/gasmask.dm Outdated Show resolved Hide resolved
code/modules/clothing/masks/gasmask.dm Outdated Show resolved Hide resolved
@Mothblocks Mothblocks marked this pull request as draft February 17, 2021 12:00
@vpellen
Copy link
Contributor

vpellen commented Feb 17, 2021

I don't hate this as much as the previous one, but I'm still not sure what your logic is regarding "why it's good". Why would dependence be motivating? Does it make their job easier? More enjoyable? More interesting? Does it change what their job is? Does it change how they go about doing their job? Because all it seems to do is make it so that other people want them to do their job more, and I'm having a hard time understanding how that's supposed to be a motivating force.

Like, when a hole gets blown in the hull, are there really a bunch of atmos techs sitting in the engineering lobby eating honk pockets going "Man, do I really have to fix that breach? People have internals, right? It's probably fine."

@kriskog
Copy link
Contributor

kriskog commented Feb 17, 2021

Gas masks filter out and trap particulates, cleaning the air you breathe. They don't block most real gases, like co2 and n2o.

@Ghilker Ghilker marked this pull request as ready for review February 17, 2021 14:09
@XDTM
Copy link
Contributor

XDTM commented Feb 17, 2021

Gas masks filter out and trap particulates, cleaning the air you breathe. They don't block most real gases, like co2 and n2o.

In an universe with laser guns, hyperspace travel, and bluespace technology, gas masks have not evolved since the twenty-first century

@maxymax13
Copy link
Contributor

maxymax13 commented Feb 17, 2021

Gas masks filter out and trap particulates, cleaning the air you breathe. They don't block most real gases, like co2 and n2o.

In an universe with laser guns, hyperspace travel, and bluespace technology, gas masks have not evolved since the twenty-first century

cameras use film, recorders use casettes, most employees only get issued pdas from the 2000s, there are still old radios lying around, 90% of the station is made out of regular corrodable iron, the station's intranet is slow enough that downloading a simple application with a few functions takes several seconds, and producing gloves out of thick rubber still is too expensive to meet employee demands. nanotrasen is cheap af, why spend money on new technology when you can just issue 600 year tech that you know works

@wesoda25
Copy link
Contributor

wesoda25 commented Feb 17, 2021

Having a small emergency tank last 14 minutes is awful balance.

Could you elaborate more on this?

Also it would be based if you made gas masks limit visibility. This PR gives people more incentive to powergame them, there should be some drawbacks.

@Ghilker
Copy link
Contributor Author

Ghilker commented Feb 17, 2021

Having a small emergency tank last 14 minutes is awful balance.

Could you elaborate more on this?

Also it would be based if you made gas masks limit visibility. This PR gives people more incentive to powergame them, there should be some drawbacks.

emergency tanks should be used for "emergencies", having a tank last 14 minutes is an awful lot, getting spaced, running in space from sec, shouldn't be something mostly trivial, 5/6 minutes is a long time to recover and re-enter into a save enviroment but short enough so that you can't mindlessy go into hazards.

The limiting masked visibility is something i thought about, i'll see how to do that

@wesoda25
Copy link
Contributor

wesoda25 commented Feb 17, 2021

A worry I have is that atmos is simply an unfun mechanic to interact with. Suffocation gets pretty fucking tired when gas moves at the speed of light. Combined with linda atmos this change feels really unfair to the players. I’m pretty sure that lemon has commented that he’s currently feeling out the new atmos and is going to decide how to proceed afterwards - I really think you should wait with this PR until after linda atmos has been tweaked (assuming it will be).

Also I’m pretty sure the degraded helmet limits visibility a bit, you could look at that.

@Ghilker
Copy link
Contributor Author

Ghilker commented Feb 17, 2021

A worry I have is that atmos is simply an unfun mechanic to interact with. Suffocation gets pretty fucking tired when gas moves at the speed of light. Combined with linda atmos this change feels really unfair to the players. I’m pretty sure that lemon has commented that he’s currently feeling out the new atmos and is going to decide how to proceed afterwards - I really think you should wait with this PR until after linda atmos has been tweaked (assuming it will be).

Also I’m pretty sure the degraded helmet limits visibility a bit, you could look at that.

Aye, managed that, now when wearing a gasmask the screen darkens (except for mime and clown masks)

@Livrah
Copy link

Livrah commented Feb 17, 2021

Plasmaman main.

@ATH1909
Copy link
Contributor

ATH1909 commented Feb 17, 2021

A worry I have is that atmos is simply an unfun mechanic to interact with. Suffocation gets pretty fucking tired when gas moves at the speed of light. Combined with linda atmos this change feels really unfair to the players. I’m pretty sure that lemon has commented that he’s currently feeling out the new atmos and is going to decide how to proceed afterwards - I really think you should wait with this PR until after linda atmos has been tweaked (assuming it will be).
Also I’m pretty sure the degraded helmet limits visibility a bit, you could look at that.

Aye, managed that, now when wearing a gasmask the screen darkens (except for mime and clown masks)

Er, I don't think that tint actually makes you screen darker. IIRC, it's used for determining the vision impediment from stacking sunglasses, welding gear, etc.

Basically, you've made it so that wearing sunglasses under your gas mask will make it about as hard to see as if you were wearing a welding helmet with a flipped down visor, from what I can tell, which is why I've given this PR a 👎 .

@ATH1909
Copy link
Contributor

ATH1909 commented Feb 17, 2021

I don't hate this as much as the previous one, but I'm still not sure what your logic is regarding "why it's good". Why would dependence be motivating? Does it make their job easier? More enjoyable? More interesting? Does it change what their job is? Does it change how they go about doing their job? Because all it seems to do is make it so that other people want them to do their job more, and I'm having a hard time understanding how that's supposed to be a motivating force.

Like, when a hole gets blown in the hull, are there really a bunch of atmos techs sitting in the engineering lobby eating honk pockets going "Man, do I really have to fix that breach? People have internals, right? It's probably fine."

This is also something to consider, although to play devil's advocate, atmos techs being more critical to people not dying could make atmos tech players feel more appreciated when continuing to play atmos tech/do their job, which in turn could cause them to stick around longer.

Alternatively, it could just cause more "well, our (possibly nonexistent) engineers didn't bother to set up the SM this shift, screwing the shift over, so I guess it's time to speedcall the shuttle again" moments.

I'm also not sure that halving the capacities of emergency oxygen tanks will actually cause people to yell at the atmos techs more (or, knowing our playerbase, break into atmos and do their jobs for them as the atmos techs struggle to figure out how to switch hands), or if it'll just cause them to consume more emergency oxygen tanks.

@ATH1909
Copy link
Contributor

ATH1909 commented Feb 17, 2021

It'd be nice if you could atomize the gas mask stuff out of this PR.

@RaveRadbury
Copy link
Member

It'd be nice if you could atomize the gas mask stuff out of this PR.

Yeah when I saw the comment on the last version of this I assumed you were just nerfing emergency internals amount, which sounds like an interesting idea that I would be in favor of trying.

@Zytolg
Copy link
Contributor

Zytolg commented Feb 17, 2021

I honestly don't see what this accomplishes besides encouraging players to just go and replace their oxytanks out of the lockers at the earliest possible convenience, and therefore creating scarcity on the o2 front when things go south. It already takes several minutes to repair breaches, and in my own experience, I find myself grabbing tanks to swap out my now empty O2 tank while waiting for the air to refill.

From a mapppers standpoint, I wouldn't be surprised if after this went through, we had issues requesting us to add more spare tanks to the oxylockers because there aren't enough and people keep dying of oxyloss.

@Pugie
Copy link

Pugie commented Feb 17, 2021

roleplayer pr

@RaveRadbury
Copy link
Member

I mean, i could atomize the gas filtering thing from this so this PR would only be about the emergency tank nerf, if requested

Nerfing the air tank time only has a better chance of going through, imo.

@optimumtact
Copy link
Member

It's unrelated but I have wanted gasmasks to obscure vision for some time to stop people wearing them in all circumstances

@SkeletalElite
Copy link
Contributor

It's far too easy to fuck up the atmosphere and far too much of a PITA to fix it for this to be good IMO.

@kriskog
Copy link
Contributor

kriskog commented Feb 18, 2021

It's unrelated but I have wanted gasmasks to obscure vision for some time to stop people wearing them in all circumstances

Making them incompatible with eyewear is probably a good compromise, and would make a lot of sense. Make sure the security one cannot be raised while wearing huds, or declassify it as a gas mask entirely since sec usually has that on permanently.

@Ghilker
Copy link
Contributor Author

Ghilker commented Feb 18, 2021

Ok i'm going to atomize this PR to make it easier to review, so this one will only deal with the reduced emergency tanks, i'll make another PR with the gas masks changes

@maxymax13
Copy link
Contributor

It's unrelated but I have wanted gasmasks to obscure vision for some time to stop people wearing them in all circumstances

i can't believe oranges is trying to make peak tider fashion inconvenient :(

@RaveRadbury
Copy link
Member

i can't believe oranges is trying to make peak tider fashion inconvenient :(

There's usually a price to pay for style and looking good.

@cacogen
Copy link
Contributor

cacogen commented Feb 18, 2021

People don't wear these very often nowadays (unless it's part of their character). If you want to obscure your face, there are less obvious ways of doing it and if you want to wear a breath mask at all times, then the type in your box can be toggled off to eat instead of having to remove it.

@RaveRadbury
Copy link
Member

@Ghilker
image
This is left over, gotta clear it

@wesoda25
Copy link
Contributor

People don't wear these very often nowadays (unless it's part of their character). If you want to obscure your face, there are less obvious ways of doing it and if you want to wear a breath mask at all times, then the type in your box can be toggled off to eat instead of having to remove it.

They go like hotcakes on the lrp servers

@LemonInTheDark
Copy link
Member

LemonInTheDark commented Feb 19, 2021

I'm not totally sure we should be doing this at this stage, since the station can already get quite cold quite quickly, so even if you do have internals you're not really safe. I suppose I'm making an assumption here, is your target to effect how people react to o2 loss? or toxins in the air supply/on the station

@Ghilker
Copy link
Contributor Author

Ghilker commented Feb 19, 2021

This is mainly targeting deficit of o2 and toxins in the air, being able to survive in a toxic ambient for 14 minutes with a small tank doesn't make it balanced at all, emergency tanks should be just that, emergency
Coldness won't be affected since there isn't much difference with the tanks from before and after this PR

@Ghilker
Copy link
Contributor Author

Ghilker commented Feb 19, 2021

@Ghilker
image
This is left over, gotta clear it

is not showing up for me, it's already removed

@RaveRadbury
Copy link
Member

I'm still seeing it on my end.

@Twaticus
Copy link
Contributor

same

@cacogen
Copy link
Contributor

cacogen commented Feb 20, 2021

I like scarcity too. It makes everything more valuable and meaningful. But not in this. The station is suffocation central at the moment with atmos as fast as it is (and people either not playing it, not having access, or not knowing how to do it) and these tanks don't last very long because of it.

@YakumoChen
Copy link
Contributor

I would think this is a good idea if, say, oxygen tanks were easily and readily refilled by anyone outside of engi/sci, but in actuality the vast majority of the station is going to run out of air and be forced to scavenge for tanks in whatever lockers are lying around because there's no free refills on air.

Any breach is going to be that much quicker of a shuttle call because people will start dying of oxygen loss after about 10 minutes and you can't just epi yourself or whatever anymore for that free 'I'm about to be fucked but gimmie another minute' pick me up when they realize their tank's gone dry.

People don't appreciate Atmosia anyway so this won't exactly change public opinion on that when they're choking for air and they have a monopoly on o2 they can't easily distribute.

@Jhyrachy
Copy link

I would think this is a good idea if, say, oxygen tanks were easily and readily refilled by anyone outside of engi/sci,

This could be a fun idea for a change:
remove air closet and replace them for a new machine, the Air Dispenser.

It must be connected to air pipline
At round start it could have the same items of a closet, but also in addition using a tank on it will be refilled (like a fire extinguisher on a water tank)

Extra stuff: could possibly be used to help repressurizing and refilling rooms

Pro: new stuff to build, less clutter, more easy access too air, more eco friendly since you can refill your equipment

@RaveRadbury
Copy link
Member

I played one of my first rounds on Tramstation and I latejoined to plasma in the air, as a cook I had no idea where atmos was or if they were doing their job, plus I had to get to the kitchen. After some time I was able to remove my O2 mask but I still had to deal with low levels of N2O for the remainder of the shift I think.

This would have been far more unpleasant with a 5-minute air tank, I do not believe that the atmos will solve an air contamination issue within five minutes, if there is an atmos tech on station in the first place. A 66% reduction in emergency internal air is too big of a first step, This should be a nerf to 10-minutes instead of 5.

@Learner10
Copy link

Learner10 commented Feb 22, 2021

I do not believe that the atmos will solve an air contamination issue within five minutes, if there is an atmos tech on station in the first place. A 66% reduction in emergency internal air is too big of a first step, This should be a nerf to 10-minutes instead of 5.

Gotta agree. I tend to encounter situations where air tanks end up becoming scarce quite frequently because someone left a window open and froze the station. Fact of the matter is, the emergency air tanks aren't just used for low pressures. They're used for temperature differences as well, so your lungs do not freeze. And considering how 30-40% the rounds is just nonstop fire alarms, this means that on a crew of 40, at least 10-20 of them are using an emergency air tank to avoid the slowdown from a large tank slotted on their back, or are losing one of their two hands just to carry a tank. In fact...

This level of a nerf is going to make conscription kits a daily purchase so people can get the "large air tank holder that doesn't have slowdown" clothing, and a free gas mask.

Other things to note, if you're going to do this, understand that this also makes the emergency cargo crate purchases way weaker, since you're taking 27 minutes of oxygen out from each crate. And yes, I have purchased internal crates quite frequently these days.

And really... why not just make each emergency oxygen can just START with less air inside, but be able to be filled up to their current maximum value? That's a nerf that doesn't say 'please die' to the players who didn't choose to be an engineer for their extended air tanks.

I would think this is a good idea if, say, oxygen tanks were easily and readily refilled by anyone outside of engi/sci,

They technically are refillable outside engineering. It's just never set up by anyone on any round. It just goes to show how little a concern refilling tanks is to an atmos tech, since all it takes is one pressure valve to be maxed for the air pumps outside engineering to be usable at filling tanks.

@RaveRadbury
Copy link
Member

I think it might be worthwhile to compare atmos to the kitchen. The kitchen is easily accessible, has donk pockets, fridges that can be opened via violence, silicon, or HOP, and we have countless vendors all over the station. Cargo can order food, too. We have intense redundancy and failsafe for our food system, despite hunger not being fatal.

How does atmos compare? Is it occupied as frequently as the kitchen is? How about atmos' accessibility, especially in terms of the security issues that come with handing out access to it. Why is atmos set up in such a way that it does not require player intervention? What are the current consequences of no atmos techs, and what would be the consequences in the aftermath of this change? Do we have oxygen redundancy that is comparable to food redundancy?

I'd really like to believe in the friendly atmosian that sets up a tank filling station at the start of every round, but I'm not sure even the wiki informs new players about such a feature beyond "yeah you can fill air tanks".

@cacogen
Copy link
Contributor

cacogen commented Feb 24, 2021

It is difficult to get inside to turn up the pump to the external ports or get someone with access to do it.

@kriskog
Copy link
Contributor

kriskog commented Feb 24, 2021

There is no "tank filling station" as those pumps are hooked to air mix as opposed to pure oxygen. They allow you to fill a pump you can move around to refill areas without air.
That said, having public (paid for) O2 refill stations around the station would be pretty cool, assuming you give atmos techs control over cost and what goes into them.

@Ghilker Ghilker closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet