Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboards: tgui and better functionality #57289

Merged
merged 15 commits into from
Mar 4, 2021

Conversation

mozi-h
Copy link
Contributor

@mozi-h mozi-h commented Feb 28, 2021

About The Pull Request

  • Clipboards now use tgui
  • View / write on paper on the chipboard using an attached pen
  • Rename paper on the clipboard
  • Attach a pen by clicking on a clipboard with one
  • Attach paper by either clicking on a clipboard with some or:
  • Rapidly attach paper by clicking on paper with the clipboard 🚀
  • Fixes Clipboards don't let you write on the paper that they hold #56456

Why It's Good For The Game

The clipboard was borderline useless: janky to use and not even functioning like a proper clipboard, as you couldn't write on or look at the contents. You were just better off using folders most of the time (which I'll be improving next).
Clipboard 2.0 doesn't just look snazzier but helps keep you on top of your paperwork, so the nightmare is not in your personal paper-mess, but in the crew needing to fill out R-500 then requesting I-700 before having filled out the wrong form and suiciding! (Needing to suicide? The clipboard's clip is surprisingly strong!)

grafik

Changelog

🆑 mozi_h
add: Clipboards have a snazzy new look.
refactor: Gave clipboards some purpose in life: Edit, rename and sort to your hearts' desire! Insert a pen by just clicking it in. Rapidly pick up paper by clicking on it with the clipboard.
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges labels Feb 28, 2021
@mozi-h

This comment has been minimized.

@MrDoomBringer
Copy link
Contributor

good stuff

@mozi-h mozi-h changed the title TGUI for clipboards and better functionality Clipboards tgui and better functionality Feb 28, 2021
@mozi-h mozi-h changed the title Clipboards tgui and better functionality Clipboards: tgui and better functionality Feb 28, 2021
@maxymax13
Copy link
Contributor

what about related items like folders and noticeboards and filing cabinets

@mozi-h
Copy link
Contributor Author

mozi-h commented Feb 28, 2021

I'll tackle them next, @maxymax13. Especially folders and filing cabinets will follow rather quickly once this is merged (as they're basically discount clipboards). The notice board may need a bit more functionality to actually get used though; pinning notices to airlocks is just way more effective at the moment.
Don't worry, I'll give all the paperwork the love it deserves!

Copy link
Member

@stylemistake stylemistake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks and feels great!

tgui/packages/tgui/interfaces/Clipboard.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Clipboard.js Show resolved Hide resolved
@maxymax13
Copy link
Contributor

maxymax13 commented Feb 28, 2021

pinning notices to airlocks if just way more effective at the moment.

is that a thing?

@mozi-h
Copy link
Contributor Author

mozi-h commented Feb 28, 2021

pinning notices to airlocks is just way more effective at the moment.

is that a thing?

Yeah. Just click paper onto airlocks. Remove them with wire cutters.

@cacogen
Copy link
Contributor

cacogen commented Mar 1, 2021

This is really cool. I already use this a lot as cargo to organise those pointless pieces of paper the consoles print. I prefer it to a folder because what it's being used for is visually obvious to other people.

@maxymax13
Copy link
Contributor

i appreciate the ability to rename paper, is there actually a way of renaming paper normally?

@mozi-h
Copy link
Contributor Author

mozi-h commented Mar 1, 2021

i appreciate the ability to rename paper, is there actually a way of renaming paper normally?

Yes, the intended rename is an object verb (shift-m2, rename or hold paper, Object tab). Additionally, labelers work (on everything).

@mozi-h mozi-h mentioned this pull request Mar 1, 2021
3 tasks
@RaveRadbury
Copy link
Member

I didn't expect this to be taken care of so soon, thank you!

@TheBonded
Copy link
Contributor

Folders next?

Copy link
Member

@Mothblocks Mothblocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
code/modules/paperwork/clipboard.dm Outdated Show resolved Hide resolved
@Mothblocks Mothblocks marked this pull request as draft March 1, 2021 22:29
Copy link
Member

@Mothblocks Mothblocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last style quirk.

@Mothblocks Mothblocks marked this pull request as draft March 4, 2021 00:08
@mozi-h mozi-h marked this pull request as ready for review March 4, 2021 16:12
@stylemistake stylemistake merged commit 6fe4e92 into tgstation:master Mar 4, 2021
github-actions bot added a commit that referenced this pull request Mar 4, 2021
@mozi-h mozi-h deleted the fix-clipboards branch March 4, 2021 17:50
@mozi-h
Copy link
Contributor Author

mozi-h commented Mar 4, 2021

Let the records say, that this failed test is not my fault.

FAIL: /datum/unit_test/gun_go_bang 0s
    REASON #1: Expected 32.4 to be equal to 30. Victim took incorrect amount of damage, expected 30, got 32.4.

The clipboard is not a gun and I advise against using it as a ranged weapon.


However, NT officials are investigating an increase in suicides using the clipboard's (surprisingly strong) clip.
Research station Clown-Comet 13 has been tasked with researching a safer clip. Until results arrive, be advised to always place the clipboard facing down onto tables. Thank you.

github-merge-queue bot pushed a commit to shiptest-ss13/Shiptest that referenced this pull request Mar 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This pull request ports the following PRs:
* tgstation/tgstation#57289
* tgstation/tgstation#57320
* tgstation/tgstation#57400
* tgstation/tgstation#60792
* tgstation/tgstation#74329

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
cool paperwork

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/2181a771-290a-4919-9b49-f7ff80ac00ce)

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/600c656e-68d4-41ee-8225-2a52bd2d0925)


<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: mozi_h, DrDiasyl aka DrTuxedo#0931, GoldenAlpharex
add: Clipboards have a snazzy new look.
refactor: Gave clipboards some purpose in life: Edit, rename and sort to
your hearts' desire! Insert a pen by just clicking it in. Rapidly pick
up paper by clicking on it with the clipboard.
add: Folders have a snazzy new look. (Check out those colours!)
qol: Rapidly pick up paper by clicking on it with a folder. Alt-click to
remove an item from a folder.
refactor: Split and cleaned up folder code.
refactor: Tidied up folder UI code
fix: Paper that's on a clipboard doesn't need to be poked to realise
that its appearance has changed and to properly display it on a
clipboard.
fix: You finally figured that using a stamp on a clipboard was more
important than using the pen that's currently attached to it.
Congratulations!
code: Added support for preventing a pen from being removed from a
clipboard.
add: Added 'biscuit' cards! They can contain documents and can only be
accessed by cracking them open, you can't close them back. Nanotrasen
now stores spare ID safe codes in them.
add: Placed paper cutters around the station. They're in Bridge, HoP
office, Warden office, and Cargo.
add: Now you can order paper cutters at cargo.
fix: Now the paper slip is actually paper.
imageadd: The paper slips sprite was slightly tweaked to have text lay
more logically, added the corporate paper slip.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
github-merge-queue bot pushed a commit to shiptest-ss13/Shiptest that referenced this pull request Mar 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This pull request ports the following PRs:
* tgstation/tgstation#57289
* tgstation/tgstation#57320
* tgstation/tgstation#57400
* tgstation/tgstation#60792
* tgstation/tgstation#74329

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
cool paperwork

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/2181a771-290a-4919-9b49-f7ff80ac00ce)

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/600c656e-68d4-41ee-8225-2a52bd2d0925)


<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: mozi_h, DrDiasyl aka DrTuxedo#0931, GoldenAlpharex
add: Clipboards have a snazzy new look.
refactor: Gave clipboards some purpose in life: Edit, rename and sort to
your hearts' desire! Insert a pen by just clicking it in. Rapidly pick
up paper by clicking on it with the clipboard.
add: Folders have a snazzy new look. (Check out those colours!)
qol: Rapidly pick up paper by clicking on it with a folder. Alt-click to
remove an item from a folder.
refactor: Split and cleaned up folder code.
refactor: Tidied up folder UI code
fix: Paper that's on a clipboard doesn't need to be poked to realise
that its appearance has changed and to properly display it on a
clipboard.
fix: You finally figured that using a stamp on a clipboard was more
important than using the pen that's currently attached to it.
Congratulations!
code: Added support for preventing a pen from being removed from a
clipboard.
add: Added 'biscuit' cards! They can contain documents and can only be
accessed by cracking them open, you can't close them back. Nanotrasen
now stores spare ID safe codes in them.
add: Placed paper cutters around the station. They're in Bridge, HoP
office, Warden office, and Cargo.
add: Now you can order paper cutters at cargo.
fix: Now the paper slip is actually paper.
imageadd: The paper slips sprite was slightly tweaked to have text lay
more logically, added the corporate paper slip.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 23, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
This pull request ports the following PRs:
* tgstation/tgstation#57289
* tgstation/tgstation#57320
* tgstation/tgstation#57400
* tgstation/tgstation#60792
* tgstation/tgstation#74329

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
cool paperwork

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/2181a771-290a-4919-9b49-f7ff80ac00ce)

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/600c656e-68d4-41ee-8225-2a52bd2d0925)

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl: mozi_h, DrDiasyl aka DrTuxedo#0931, GoldenAlpharex
add: Clipboards have a snazzy new look.
refactor: Gave clipboards some purpose in life: Edit, rename and sort to
your hearts' desire! Insert a pen by just clicking it in. Rapidly pick
up paper by clicking on it with the clipboard.
add: Folders have a snazzy new look. (Check out those colours!)
qol: Rapidly pick up paper by clicking on it with a folder. Alt-click to
remove an item from a folder.
refactor: Split and cleaned up folder code.
refactor: Tidied up folder UI code
fix: Paper that's on a clipboard doesn't need to be poked to realise
that its appearance has changed and to properly display it on a
clipboard.
fix: You finally figured that using a stamp on a clipboard was more
important than using the pen that's currently attached to it.
Congratulations!
code: Added support for preventing a pen from being removed from a
clipboard.
add: Added 'biscuit' cards! They can contain documents and can only be
accessed by cracking them open, you can't close them back. Nanotrasen
now stores spare ID safe codes in them.
add: Placed paper cutters around the station. They're in Bridge, HoP
office, Warden office, and Cargo.
add: Now you can order paper cutters at cargo.
fix: Now the paper slip is actually paper.
imageadd: The paper slips sprite was slightly tweaked to have text lay
more logically, added the corporate paper slip.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboards don't let you write on the paper that they hold
10 participants